Skip to content

Commit 2f4a8bc

Browse files
committed
fix docker dep build order.
1 parent aaa6778 commit 2f4a8bc

File tree

3 files changed

+11
-20
lines changed

3 files changed

+11
-20
lines changed

Dockerfile-minimal

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@ RUN apt-get update \
66
&& rm -rf /var/lib/apt/lists/*
77

88
WORKDIR /pygraphblas
9-
ADD minimal-requirements.txt /pygraphblas
10-
RUN pip3 install -r minimal-requirements.txt
119

1210
ADD . /pygraphblas
1311

14-
RUN python3 setup.py develop
12+
RUN python3 setup.py install
13+
RUN pip3 install -r minimal-requirements.txt
1514
RUN ldconfig

Dockerfile-notebook

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@ RUN conda install -y graphviz
88

99
WORKDIR /home/jovyan
1010

11-
ADD notebook-requirements.txt /home/jovyan
12-
RUN pip3 install -r notebook-requirements.txt
13-
1411
ADD . /home/jovyan
1512

16-
RUN python setup.py develop
13+
RUN python setup.py install
14+
RUN pip3 install -r notebook-requirements.txt
1715
RUN chown -R jovyan /home/jovyan
1816

1917
RUN ldconfig

docker_build.sh

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,16 @@
11
if [ $# -eq 0 ]
22
then
3-
echo "Usage: ./docker_build.sh SS_RELEASE PY_RELEASE BASE_NAME BRANCH [LOCATION PUSH]"
3+
echo "Usage: ./docker_build.sh PY_RELEASE BASE_NAME BRANCH [LOCATION PUSH]"
44
echo
5-
echo "Example: ./docker_build.sh v3.3.3 v3.4.0 notebook main clone push"
5+
echo "Example: ./docker_build.sh 5.1.7.1 notebook main clone push"
66
exit 1
77
fi
88

9-
SS_RELEASE=$1
10-
PY_RELEASE=$2
11-
BASE_NAME=$3
12-
BRANCH=$4
13-
LOCATION=$5
14-
PUSH=$6
15-
16-
# for BASE_NAME=notebook image
17-
# set env var to 1 for faster SuiteSparse compilation, but the code will be slower
18-
SS_COMPACT=${SS_COMPACT:-0}
19-
SS_BURBLE=${SS_BURBLE:-0}
9+
PY_RELEASE=$1
10+
BASE_NAME=$2
11+
BRANCH=$3
12+
LOCATION=$4
13+
PUSH=$5
2014

2115
if [ "$LOCATION" = "clone" ]
2216
then

0 commit comments

Comments
 (0)