Replace string_view with const string& #74

Author: deccer

src/Cpp/1-getting-started/1-1-1-HelloWindow/Application.cpp

@@ -2,7 +2,7 @@
 
 #include <GLFW/glfw3.h>
 
-Application::Application(const std::string_view title)
+Application::Application(const std::string& title)
 {
     _title = title;
 }

src/Cpp/1-getting-started/1-1-1-HelloWindow/Application.hpp

@@ -1,15 +1,15 @@
 #pragma once
 
 #include <cstdint>
-#include <string_view>
+#include <string>
 
 // ReSharper disable once CppInconsistentNaming
 struct GLFWwindow;
 
 class Application
 {
 public:
-    Application(const std::string_view title);
+    Application(const std::string& title);
     virtual ~Application();
     void Run();
 
@@ -25,5 +25,5 @@ class Application
     GLFWwindow* _window = nullptr;
     int32_t _width = 0;
     int32_t _height = 0;
-    std::string_view _title;
+    std::string _title;
 };

src/Cpp/1-getting-started/1-1-1-HelloWindow/HelloWindowApplication.cpp

@@ -2,7 +2,7 @@
 
 #include <string>
 
-HelloWindowApplication::HelloWindowApplication(const std::string_view title)
+HelloWindowApplication::HelloWindowApplication(const std::string& title)
     : Application(title)
 {
 }

src/Cpp/1-getting-started/1-1-1-HelloWindow/HelloWindowApplication.hpp

@@ -5,7 +5,7 @@
 class HelloWindowApplication final : public Application
 {
 public:
-    HelloWindowApplication(const std::string_view title);
+    HelloWindowApplication(const std::string& title);
 
 protected:
     bool Load() override;

src/Cpp/1-getting-started/1-1-2-HelloD3D11-Raw/Main.cpp

@@ -5,7 +5,6 @@
 #define GLFW_EXPOSE_NATIVE_WIN32
 #include <GLFW/glfw3native.h>
 
-#include <string_view>
 #include <iostream>
 
 #pragma comment(lib, "d3d11.lib")

src/Cpp/1-getting-started/1-1-2-HelloD3D11/HelloD3D11Application.cpp

@@ -15,7 +15,7 @@
 #pragma comment(lib, "winmm.lib")
 #pragma comment(lib, "dxguid.lib")
 
-HelloD3D11Application::HelloD3D11Application(const std::string_view title)
+HelloD3D11Application::HelloD3D11Application(const std::string& title)
     : Application(title)
 {
 }

src/Cpp/1-getting-started/1-1-2-HelloD3D11/HelloD3D11Application.hpp

@@ -6,14 +6,12 @@
 
 #include <Application.hpp>
 
-#include <string_view>
-
 class HelloD3D11Application final : public Application
 {
     template <typename T>
     using ComPtr = Microsoft::WRL::ComPtr<T>;
 public:
-    HelloD3D11Application(const std::string_view title);
+    HelloD3D11Application(const std::string& title);
     ~HelloD3D11Application() override;
 
 protected:

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/HelloTriangleApplication.cpp

@@ -21,7 +21,7 @@
 #pragma comment(lib, "winmm.lib")
 #pragma comment(lib, "dxguid.lib")
 
-HelloTriangleApplication::HelloTriangleApplication(const std::string_view title)
+HelloTriangleApplication::HelloTriangleApplication(const std::string& title)
     : Application(title)
 {
 }

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/HelloTriangleApplication.hpp

@@ -5,7 +5,6 @@
 
 #include <d3d11_2.h>
 
-#include <string_view>
 #include <memory>
 
 class DeviceContext;
@@ -15,7 +14,7 @@ class PipelineFactory;
 class HelloTriangleApplication final : public Application
 {
 public:
-    HelloTriangleApplication(const std::string_view title);
+    HelloTriangleApplication(const std::string& title);
     ~HelloTriangleApplication() override;
 
 protected:

src/Cpp/1-getting-started/1-1-3-HelloTriangle-Refactored/PipelineFactory.hpp

@@ -7,7 +7,7 @@
 #include <d3d11_2.h>
 
 #include <unordered_map>
-#include <string_view>
+#include <string>
 #include <memory>
 
 struct PipelineDescriptor