Skip to content

Commit 8c5accc

Browse files
authored
Clean up node catalog by adding missing units, more tooltips; fix 'Line' node missing parameters (#2813)
* Fix unit usages * Add node and parameter doc comments * Fix the parameters panel for the 'Line' node when added from the graph * Clean up nodes * Fix tests * Update the demo artwork
1 parent 0febfaf commit 8c5accc

21 files changed

+366
-89
lines changed

demo-artwork/changing-seasons.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/isometric-fountain.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/marbled-mandelbrot.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/painted-dreams.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/parametric-dunescape.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/procedural-string-lights.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/red-dress.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo-artwork/valley-of-spires.graphite

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1016,7 +1016,9 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> {
10161016
..Default::default()
10171017
},
10181018
},
1019-
description: Cow::Borrowed("TODO"),
1019+
description: Cow::Borrowed(
1020+
"Decomposes the X and Y components of a 2D coordinate.\n\nThe inverse of this node is \"Coordinate Value\", which can have either or both its X and Y exposed as graph inputs.",
1021+
),
10201022
properties: None,
10211023
},
10221024
// TODO: Remove this and just use the proto node definition directly
@@ -1856,7 +1858,7 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> {
18561858
NodeInput::network(concrete!(graphene_std::vector::VectorDataTable), 0),
18571859
NodeInput::network(concrete!(vector::misc::PointSpacingType), 1),
18581860
NodeInput::network(concrete!(f64), 2),
1859-
NodeInput::network(concrete!(f64), 3),
1861+
NodeInput::network(concrete!(u32), 3),
18601862
NodeInput::network(concrete!(f64), 4),
18611863
NodeInput::network(concrete!(f64), 5),
18621864
NodeInput::network(concrete!(bool), 6),
@@ -1895,7 +1897,7 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> {
18951897
NodeInput::value(TaggedValue::VectorData(graphene_std::vector::VectorDataTable::default()), true),
18961898
NodeInput::value(TaggedValue::PointSpacingType(Default::default()), false),
18971899
NodeInput::value(TaggedValue::F64(100.), false),
1898-
NodeInput::value(TaggedValue::F64(100.), false),
1900+
NodeInput::value(TaggedValue::U32(100), false),
18991901
NodeInput::value(TaggedValue::F64(0.), false),
19001902
NodeInput::value(TaggedValue::F64(0.), false),
19011903
NodeInput::value(TaggedValue::Bool(false), false),

editor/src/messages/portfolio/document/node_graph/node_properties.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1427,6 +1427,7 @@ pub(crate) fn rectangle_properties(node_id: NodeId, context: &mut NodeProperties
14271427
} else {
14281428
NumberInput::default()
14291429
.value(Some(uniform_val))
1430+
.unit(" px")
14301431
.on_update(update_value(move |x: &NumberInput| TaggedValue::F64(x.value.unwrap()), node_id, CornerRadiusInput::<f64>::INDEX))
14311432
.on_commit(commit_value)
14321433
.widget_holder()

0 commit comments

Comments
 (0)