Skip to content

Commit c68026d

Browse files
committed
Cleanup unused surface rendering code
1 parent c40cee5 commit c68026d

File tree

2 files changed

+5
-51
lines changed

2 files changed

+5
-51
lines changed

node-graph/interpreted-executor/src/util.rs

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,10 @@ pub fn wrap_network_in_scope(mut network: NodeNetwork, editor_api: Arc<WasmEdito
2626
// .document_node;
2727

2828
let render_node = DocumentNode {
29-
inputs: vec![NodeInput::node(NodeId(0), 0), NodeInput::node(NodeId(2), 0)],
29+
inputs: vec![NodeInput::node(NodeId(0), 0)],
3030
implementation: DocumentNodeImplementation::Network(NodeNetwork {
31-
exports: vec![NodeInput::node(NodeId(4), 0)],
31+
exports: vec![NodeInput::node(NodeId(2), 0)],
3232
nodes: [
33-
DocumentNode {
34-
inputs: vec![NodeInput::scope("editor-api")],
35-
implementation: DocumentNodeImplementation::ProtoNode(ProtoNodeIdentifier::new("wgpu_executor::CreateGpuSurfaceNode")),
36-
skip_deduplication: true,
37-
..Default::default()
38-
},
39-
DocumentNode {
40-
inputs: vec![NodeInput::node(NodeId(0), 0)],
41-
implementation: DocumentNodeImplementation::ProtoNode(graphene_core::memo::memo::IDENTIFIER),
42-
..Default::default()
43-
},
4433
DocumentNode {
4534
call_argument: concrete!(Context),
4635
inputs: vec![NodeInput::import(core_types::Type::Fn(Box::new(concrete!(Context)), Box::new(generic!(T))), 0)],
@@ -54,7 +43,7 @@ pub fn wrap_network_in_scope(mut network: NodeNetwork, editor_api: Arc<WasmEdito
5443
// Keep this in sync with the protonode in valid_input_types
5544
DocumentNode {
5645
call_argument: concrete!(Context),
57-
inputs: vec![NodeInput::scope("editor-api"), NodeInput::node(NodeId(2), 0), NodeInput::node(NodeId(1), 0)],
46+
inputs: vec![NodeInput::scope("editor-api"), NodeInput::node(NodeId(0), 0)],
5847
implementation: DocumentNodeImplementation::ProtoNode(graphene_std::render_node::render::IDENTIFIER),
5948
context_features: graphene_std::ContextDependencies {
6049
extract: ContextFeatures::FOOTPRINT | ContextFeatures::VARARGS,
@@ -64,7 +53,7 @@ pub fn wrap_network_in_scope(mut network: NodeNetwork, editor_api: Arc<WasmEdito
6453
},
6554
DocumentNode {
6655
call_argument: concrete!(graphene_std::application_io::RenderConfig),
67-
inputs: vec![NodeInput::node(NodeId(3), 0)],
56+
inputs: vec![NodeInput::node(NodeId(1), 0)],
6857
implementation: DocumentNodeImplementation::ProtoNode(graphene_std::render_node::create_context::IDENTIFIER),
6958
context_features: graphene_std::ContextDependencies {
7059
extract: ContextFeatures::empty(),

node-graph/wgpu-executor/src/lib.rs

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ pub use rendering::RenderContext;
1313
use std::sync::Arc;
1414
use vello::{AaConfig, AaSupport, RenderParams, Renderer, RendererOptions, Scene};
1515
use wgpu::util::TextureBlitter;
16-
use wgpu::{Origin3d, SurfaceConfiguration, TextureAspect};
16+
use wgpu::{Origin3d, TextureAspect};
1717

1818
pub use context::Context as WgpuContext;
1919
pub use context::ContextBuilder as WgpuContextBuilder;
@@ -66,41 +66,6 @@ unsafe impl StaticType for Surface {
6666
const VELLO_SURFACE_FORMAT: wgpu::TextureFormat = wgpu::TextureFormat::Rgba8Unorm;
6767

6868
impl WgpuExecutor {
69-
pub async fn render_vello_scene(&self, scene: &Scene, surface: &WgpuSurface, size: UVec2, context: &RenderContext, background: Color) -> Result<()> {
70-
let mut guard = surface.surface.target_texture.lock().await;
71-
72-
let surface_inner = &surface.surface.inner;
73-
let surface_caps = surface_inner.get_capabilities(&self.context.adapter);
74-
surface_inner.configure(
75-
&self.context.device,
76-
&SurfaceConfiguration {
77-
usage: wgpu::TextureUsages::RENDER_ATTACHMENT | wgpu::TextureUsages::STORAGE_BINDING,
78-
format: VELLO_SURFACE_FORMAT,
79-
width: size.x,
80-
height: size.y,
81-
present_mode: surface_caps.present_modes[0],
82-
alpha_mode: wgpu::CompositeAlphaMode::Opaque,
83-
view_formats: vec![],
84-
desired_maximum_frame_latency: 2,
85-
},
86-
);
87-
88-
self.render_vello_scene_to_target_texture(scene, size, context, background, &mut guard).await?;
89-
90-
let surface_texture = surface_inner.get_current_texture()?;
91-
let mut encoder = self.context.device.create_command_encoder(&wgpu::CommandEncoderDescriptor { label: Some("Surface Blit") });
92-
surface.surface.blitter.copy(
93-
&self.context.device,
94-
&mut encoder,
95-
&guard.as_ref().unwrap().view,
96-
&surface_texture.texture.create_view(&wgpu::TextureViewDescriptor::default()),
97-
);
98-
self.context.queue.submit([encoder.finish()]);
99-
surface_texture.present();
100-
101-
Ok(())
102-
}
103-
10469
pub async fn render_vello_scene_to_texture(&self, scene: &Scene, size: UVec2, context: &RenderContext, background: Color) -> Result<wgpu::Texture> {
10570
let mut output = None;
10671
self.render_vello_scene_to_target_texture(scene, size, context, background, &mut output).await?;

0 commit comments

Comments
 (0)