Add stroke scaling option to Stroke node #2961
Conversation
Add a "Scaling" field to the Stroke node that allows users to toggle whether strokes should scale with shape transformations or maintain a constant visual width. * Add StrokeScaling enum with ScaleWithShape and NonScaling options * Add new "Scaling" parameter to the Stroke node * Update document migration to handle the new parameter * Fix migration bug that caused index out of bounds error * Remove duplicate apply_stroke call in shape_tool.rs Closes GraphiteEditor#2960 Apply cargo fmt
chbornman
force-pushed
the
stroke-scaling
branch
from
75e0b76 to
361efce
Compare
Keavon
changed the title
|
Sorry for being backed up on code review, I'm working through my backlog now. There is still an open question as to whether we want to have this via the Stroke node (a property of the stroke to not scale, as you've implemented) or via the Transform node (an option to skip affecting strokes, but also other future things like shadows and other appearance effects). I think it is too premature to decide on that quite yet, so I'm inclined to take no action on this yet rather than committing to potentially the wrong approach and having to deal with the migrations for undoing it later on. So with that in mind, and because this is a relatively small PR that could be recreated again in the future when the time is right, my preference is to close this for the moment. Thanks for your understanding! |
Add a "Scaling" field to the Stroke node that allows users to toggle whether strokes should scale with shape transformations or maintain a constant visual width.
Closes #2960