Desktop: Add File > Save As… #3034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Keavon We fixed the open issue this is now waiting on your thoughts regarding how the save process flow should work and if the implemented behaviour is desired |
|
Let's discuss in a call so I know more about what's to be considered. Also, this PR has a conflict. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@Keavon what is the status on this? I can review the code you just have to say if you are happy with the behaviour |
timon-schelling
force-pushed
the
improve-save-document
branch
from
5b2b7d0 to
a44de05
Compare
Keavon
changed the title
Keavon
changed the title
Keavon
approved these changes
Aug 20, 2025
timon-schelling
force-pushed
the
improve-save-document
branch
from
e267413 to
6e26af9
Compare
TrueDoctor
changed the title
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.graphite) as the document nameSave asactionIssue: Save as shourtcutCtrl + Shift + Snot working (help wanted)