refactor: Fix clippy warnings

Author: GrayJack

README.md

@@ -173,7 +173,7 @@ Without them, this project would not be what it is today.
 - [@Celeo](https://github.com/Celeo) - _Celeo_
 - [@FedericoPonzi](https://github.com/FedericoPonzi) - _Federico Ponzi_
 - [@Larisho](https://github.com/Larisho) - _Gab David_
-- [@silverweed](https://github.com/silverweed) - _Giacomo Parolini_
+- [@silverweed](https://github.com/silverweed)
 - [@marcospb19](https://github.com/marcospb19) - _João M. Bezerra_
 - [@kegesch](https://github.com/kegesch) - _Jonas Geschke_
 - Ladysamantha

basename/build.rs

@@ -28,6 +28,7 @@ fn main() {
                 .read(true)
                 .write(true)
                 .create(true)
+                .truncate(false)
                 .open(file_name)
                 .expect("Unable to open file"),
         );

cat/build.rs

@@ -27,6 +27,7 @@ fn main() {
                 .read(true)
                 .write(true)
                 .create(true)
+                .truncate(false)
                 .open(file_name)
                 .expect("Unable to open file"),
         );

chroot/build.rs

@@ -28,6 +28,7 @@ fn main() {
                 .read(true)
                 .write(true)
                 .create(true)
+                .truncate(false)
                 .open(file_name)
                 .expect("Unable to open file"),
         );

clear/build.rs

@@ -28,6 +28,7 @@ fn main() {
                 .read(true)
                 .write(true)
                 .create(true)
+                .truncate(false)
                 .open(file_name)
                 .expect("Unable to open file"),
         );

clear/src/main.rs

@@ -1,5 +1,5 @@
 use std::{
-    io::{stdout, Write},
+    io::{Write, stdout},
     process,
 };
 
@@ -11,7 +11,7 @@ fn main() {
     let x_flag = matches.is_present("x");
 
     if x_flag {
-        match stdout().lock().write(b"\x1b[H\x1b[3J") {
+        match stdout().lock().write_all(b"\x1b[H\x1b[3J") {
             Ok(_) => (),
             Err(err) => {
                 eprintln!("clear: failed to execute: {}", err);
@@ -21,7 +21,7 @@ fn main() {
         return;
     }
 
-    match stdout().lock().write(b"\x1b[3J\x1b[H\x1b[2J") {
+    match stdout().lock().write_all(b"\x1b[3J\x1b[H\x1b[2J") {
         Ok(_) => (),
         Err(err) => {
             eprintln!("clear: failed to execute: {}", err);

coreutils_core/src/backup.rs

@@ -105,7 +105,7 @@ impl From<&str> for BackupMode {
 pub fn create_numbered_backup(file: &Path) -> Result<PathBuf, Error> {
     let mut index = 1_u64;
     loop {
-        if index == std::u64::MAX {
+        if index == u64::MAX {
             return Err(Error::new(
                 ErrorKind::AlreadyExists,
                 "Cannot create backup: too many backup files",

coreutils_core/src/os/audit.rs

@@ -149,9 +149,8 @@ extern "C" {
 #[inline]
 pub fn audit_info() -> io::Result<AuditInfo> {
     let mut auditinfo: MaybeUninit<AuditInfo> = MaybeUninit::zeroed();
-    let address = auditinfo.as_mut_ptr() as *mut AuditInfo;
 
-    if unsafe { getaudit(address) } == -1 {
+    if unsafe { getaudit(auditinfo.as_mut_ptr()) } == -1 {
         return Err(io::Error::last_os_error());
     }
 

coreutils_core/src/os/resource.rs

@@ -3,7 +3,7 @@
 //! Also holds utility functions for summarizing the data returned by getrusage(2)
 #[cfg(not(target_os = "fuchsia"))]
 use libc::getrusage;
-use libc::{c_int, rusage, RUSAGE_CHILDREN, RUSAGE_SELF};
+use libc::{RUSAGE_CHILDREN, RUSAGE_SELF, c_int, rusage};
 use time::Duration;
 
 use super::TimeVal;
@@ -69,6 +69,7 @@ pub struct IOUsage {
     pub num_signals: u64,
 }
 
+#[allow(clippy::unnecessary_cast, reason = "OS divergence")]
 fn timeval_to_duration(t: TimeVal) -> Duration {
     // This type cast is realistically safe because the number of
     // microseconds in a second cannot exceed `1e+6`, which at

csplit/build.rs

@@ -28,6 +28,7 @@ fn main() {
                 .read(true)
                 .write(true)
                 .create(true)
+                .truncate(false)
                 .open(file_name)
                 .expect("Unable to open file"),
         );