Skip changelog generation if the the target path already exists

bernd · bernd · commit 73996d0fa197 · 2023-02-01T14:36:13.000+01:00
This avoids a build error when we have to rebuild a release and the
changelog was already rotated in a previous build attempt.
diff --git a/changelog/release.go b/changelog/release.go
@@ -39,7 +39,9 @@ func ReleaseInPath(path string, version string, versionPattern *regexp.Regexp) e
 		}
 
 		if utils.FileExists(versionChangelogPath) {
-			return fmt.Errorf("target path already exists: %s", filepath.Join(path, versionChangelogPath))
+			logger.Info("Target path already exists - skipping changelog release (%s)",
+				filepath.Join(path, versionChangelogPath))
+			return nil
 		}
 
 		out, err := git.GitE("mv", "-v", unreleasedChangelogPath, versionChangelogPath)

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,9 @@ func ReleaseInPath(path string, version string, versionPattern *regexp.Regexp) e`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`if utils.FileExists(versionChangelogPath) {`
`42`		`- return fmt.Errorf("target path already exists: %s", filepath.Join(path, versionChangelogPath))`
	`42`	`+ logger.Info("Target path already exists - skipping changelog release (%s)",`
	`43`	`+ filepath.Join(path, versionChangelogPath))`
	`44`	`+ return nil`
`43`	`45`	`}`
`44`	`46`
`45`	`47`	`out, err := git.GitE("mv", "-v", unreleasedChangelogPath, versionChangelogPath)`