Refactor FlowDefinitionRegistry and StepResolver for improved type handling and code clarity

Author: Grazulex

src/Registry/FlowDefinitionRegistry.php

@@ -15,14 +15,14 @@ final class FlowDefinitionRegistry
 
     public function __construct(?string $path = null)
     {
-        $this->path = base_path(config('flowpipe.definitions_path', 'flow_definitions'));
+        $this->path = $path ?? base_path(config('flowpipe.definitions_path', 'flow_definitions'));
     }
 
     public function list(): Collection
     {
         return collect(File::files($this->path))
-            ->filter(fn ($f) => str_ends_with($f->getFilename(), '.yaml'))
-            ->map(fn ($f) => $f->getFilenameWithoutExtension());
+            ->filter(fn ($f): bool => str_ends_with($f->getFilename(), '.yaml'))
+            ->map(fn ($f): string => $f->getFilenameWithoutExtension());
     }
 
     public function get(string $name): array

src/Support/StepResolver.php

@@ -14,14 +14,14 @@ final class StepResolver
     /**
      * Resolve a given step into a FlowStep instance or Closure.
      */
-    public static function resolve(FlowStep|Closure|string $step): FlowStep|Closure
+    public static function resolve(mixed $step): FlowStep|Closure
     {
-        // Already a usable instance
-        if ($step instanceof Closure || $step instanceof FlowStep) {
+        // Step is already an instance or closure
+        if ($step instanceof FlowStep || $step instanceof Closure) {
             return $step;
         }
 
-        // Try resolving by class name or configured namespace
+        // Step is a string → resolve class
         if (is_string($step)) {
             $class = class_exists($step)
                 ? $step
@@ -40,6 +40,7 @@ public static function resolve(FlowStep|Closure|string $step): FlowStep|Closure
             return $instance;
         }
 
+        // Step is invalid
         throw new InvalidArgumentException('Invalid step type: '.gettype($step));
     }
 }