EncodeTFBS getposition

[rojinsafavi]

Not sure if this is a bug, or if I am missing something here.
I added "EncodeTFBS":
projHeme2 <- addArchRAnnotations(ArchRProj = projHeme2, collection = "EncodeTFBS")
but when I try getting the motif position, I get this error:

[rcorces]

This is an obscure one. Had to dig into the code a bit.
The difference is between addPeakAnnotations() and addArchRAnnotations(). The former adds a record for the actual position, the later does not. So, as written, none of the results from addArchRAnnotations() are compatible with getPositions()

ArchR/R/AnnotationPeaks.R

Line 759 in 968e442

ArchRProj@peakAnnotation[[name]]$Positions <- "None"

vs

ArchR/R/AnnotationPeaks.R

Line 224 in 968e442

ArchRProj@peakAnnotation[[name]]$Positions <- savePositions

I'm not 100% sure what the original rationale for this would have been. Seems like something that should be addressed. I'm moving this to Issues.