refactor QueueService

Author: yunchipang

server/handlers/walletHandler/index.js

@@ -1,5 +1,5 @@
 const csvtojson = require('csvtojson');
-const queueService = require('../../services/QueueService');
+const QueueService = require('../../services/QueueService');
 
 const WalletService = require('../../services/WalletService');
 const TrustService = require('../../services/TrustService');
@@ -162,7 +162,7 @@ const walletPost = async (req, res) => {
     );
   }
 
-  await queueService.sendWalletCreationNotification(returnedWallet);
+  await QueueService.sendWalletCreationNotification(returnedWallet);
 
   res.status(201).json(returnedWallet);
 };

server/services/QueueService.js

@@ -3,20 +3,15 @@ const queue = require('treetracker-wallet-app/packages/queue');
 const knex = require('../infra/database/knex');
 
 class QueueService {
-  constructor() {
-    this.queue = queue;
-    this.knex = knex;
-  }
-
   /**
    * Publishes a wallet creation event to the queue.
    * @param {Object} wallet - The wallet object that was just created.
    * @returns {Promise<void>}
    */
-  sendWalletCreationNotification(wallet) {
+  static async sendWalletCreationNotification(wallet) {
     try {
-      this.queue.publish({
-        pgClient: this.knex,
+      queue.publish({
+        pgClient: knex,
         channel: 'wallet_created',
         data: {
           walletId: wallet.id,
@@ -33,4 +28,4 @@ class QueueService {
   }
 }
 
-module.exports = new QueueService();
+module.exports = QueueService;

server/services/QueueService.spec.js

@@ -1,8 +1,9 @@
 const sinon = require('sinon');
 const { expect } = require('chai');
 const log = require('loglevel');
-
 const queue = require('treetracker-wallet-app/packages/queue');
+const knex = require('../infra/database/knex');
+const QueueService = require('./QueueService');
 
 describe('QueueService', () => {
   let publishStub;
@@ -17,9 +18,6 @@ describe('QueueService', () => {
     sinon.restore();
   });
 
-  const queueService = require('./QueueService');
-  const knex = require('../infra/database/knex');
-
   describe('sendWalletCreationNotification', () => {
     it('should publish a wallet creation message to the queue', async () => {
       const wallet = {
@@ -28,7 +26,7 @@ describe('QueueService', () => {
         createdAt: '2025-04-29T00:00:00Z',
       };
 
-      await queueService.sendWalletCreationNotification(wallet);
+      await QueueService.sendWalletCreationNotification(wallet);
 
       expect(publishStub.calledOnce).to.be.true;
       expect(publishStub.firstCall.args[0]).to.deep.equal({
@@ -42,7 +40,7 @@ describe('QueueService', () => {
       });
     });
 
-    it('should not throw error if publish fails', () => {
+    it('should not throw error if publish fails', async () => {
       publishStub.throws(new Error('publish failed'));
 
       const wallet = {
@@ -53,7 +51,7 @@ describe('QueueService', () => {
 
       let errorCaught = false;
       try {
-        queueService.sendWalletCreationNotification(wallet);
+        await QueueService.sendWalletCreationNotification(wallet);
       } catch (err) {
         errorCaught = true;
       }