Fix equipment removal (#646)

Author: GregHib

engine/src/main/kotlin/world/gregs/voidps/engine/inv/ItemRemoved.kt

@@ -9,8 +9,8 @@ import world.gregs.voidps.network.login.protocol.visual.update.player.EquipSlot
 
 /**
  * An item slot updated to an item in an inventory.
- * @param inventory the inventory id the item is from
- * @param index the index in the inventory the item was from
+ * @param inventory the inventory id the item was removed from
+ * @param index the index in the inventory the item was in
  * @param item the previous state of the item before it was removed
  */
 data class ItemRemoved(

engine/src/main/kotlin/world/gregs/voidps/engine/inv/transact/ChangeManager.kt

@@ -25,7 +25,7 @@ class ChangeManager(
      */
     fun track(from: String, index: Int, previous: Item, fromIndex: Int, item: Item) {
         if (previous.isNotEmpty()) {
-            changes.add(ItemRemoved(from, fromIndex, previous))
+            changes.add(ItemRemoved(inventory.id, index, previous))
         }
         if (item.isNotEmpty()) {
             changes.add(ItemAdded(inventory.id, index, item))

engine/src/test/kotlin/world/gregs/voidps/engine/inv/InventorySlotChangedTest.kt

@@ -51,7 +51,7 @@ class InventorySlotChangedTest  {
     @Test
     fun `Track removals`() {
         var removals = 0
-        itemRemoved("coins", inventory = "bank") {
+        itemRemoved("coins", inventory = "inventory") {
             removals++
         }