Add Clan Wars Free-For-All (Safe & Dangerous) portals (#949)

HarleyGilpin · GregHib · web-flow · commit 7e544515062b · 2026-04-14T13:45:05.000+01:00
* Fix: NPCs spawned under a target couldn't attack

* Fix: character creation screen skipped for new accounts

* Fix: game loop crash when dying to TzTok-Jad in Fight Cave

* chore: add missing dragon arrow items to ammo_groups.toml

* Fix: dragon claws special attack damage and hit timing

* Fix: dragon claws special attack damage and hit timing

* feat: add clan wars safe and dangerous free-for-all portals.

* Fix: bank tab creation and collapse

* chore: replaced redundant code with stepOut function.

* Update game/src/main/kotlin/content/minigame/clan_wars/ClanWarsFreeForAll.kt

Co-authored-by: Greg &lt;GregHib@users.noreply.github.com&gt;

* Update game/src/main/kotlin/content/minigame/clan_wars/ClanWarsFreeForAll.kt

Co-authored-by: Greg &lt;GregHib@users.noreply.github.com&gt;

* Fix: Clan Wars FFA "Don't show gain" toggle

* bug: fixed the dragon claws delayed special attack.

* chore: spotlessApply ran

* Fix: Iterate cardinal directions in random order and queue the first walkable one, so a single blocked direction no longer traps the NPC.

---------

Co-authored-by: Greg &lt;GregHib@users.noreply.github.com&gt;
diff --git a/data/area/wilderness/wilderness.areas.toml b/data/area/wilderness/wilderness.areas.toml
@@ -89,3 +89,8 @@ tags = ["teleport", "obelisk"]
 [wilderness_fishing_area]
 x = [3347, 3368]
 y = [3793, 3817]
+
+[clan_wars]
+x = [3264, 3279]
+y = [3672, 3695]
+tags = ["safe_zone"]
diff --git a/data/area/wilderness/wilderness.npc-spawns.toml b/data/area/wilderness/wilderness.npc-spawns.toml
@@ -295,10 +295,6 @@ spawns = [
     { id = "black_salamander", x = 3321, y = 3661 },
     { id = "red_dragon", x = 3212, y = 3820 },
     { id = "red_dragon", x = 3222, y = 3829 },
-    { id = "skeleton_axe_shield", x = 3275, y = 3686 },
-    { id = "skeleton_sword_shield", x = 3270, y = 3681 },
-    { id = "skeleton_longsword", x = 3275, y = 3676 },
-    { id = "skeleton_flail", x = 3269, y = 3672 },
     { id = "waterfiend", x = 3362, y = 3642, members = true },
     { id = "waterfiend", x = 3363, y = 3647, members = true },
     { id = "waterfiend", x = 3365, y = 3639, members = true },
@@ -375,7 +371,6 @@ spawns = [
     { id = "giant_rat_wilderness_2", x = 3248, y = 3553, members = true },
     { id = "giant_rat_wilderness_2", x = 3256, y = 3541, members = true },
     { id = "goblin_musician", x = 3140, y = 3642 },
-    { id = "skeleton_mace_shield", x = 3268, y = 3688 },
     { id = "green_dragon", x = 2982, y = 3618 },
     { id = "green_dragon", x = 3118, y = 3820 },
     { id = "green_dragon", x = 3338, y = 3676 },
diff --git a/data/entity/player/modal/chat_box/warning.varbits.toml b/data/entity/player/modal/chat_box/warning.varbits.toml
@@ -101,7 +101,7 @@ format = "int"
 [warning_clan_wars_ffa_safe]
 id = 5294
 persist = true
-format = "boolean"
+format = "int"
 
 [warning_ranging_guild_tower]
 id = 3871
@@ -146,7 +146,7 @@ format = "int"
 [warning_clan_wars_ffa_dangerous]
 id = 5295
 persist = true
-format = "boolean"
+format = "int"
 
 [warning_living_rock_caverns]
 id = 6500
diff --git a/data/entity/player/modal/chat_box/warnings.ifaces.toml b/data/entity/player/modal/chat_box/warnings.ifaces.toml
@@ -441,6 +441,19 @@ id = 82
 [.living_rock_caverns]
 id = 83
 
+[warning_clan_wars_ffa_safe]
+id = 793
+type = "main_screen"
+
+[.yes]
+id = 15
+
+[.no]
+id = 14
+
+[.dont_ask]
+id = 9
+
 [warning_godwars_wilderness_agility_route]
 id = 600
 type = "main_screen"
diff --git a/data/minigame/clan_wars/clan_wars.areas.toml b/data/minigame/clan_wars/clan_wars.areas.toml
@@ -2,3 +2,25 @@
 x = [3266, 3270]
 y = [3679, 3682]
 tags = ["teleport"]
+
+[clan_wars_ffa]
+x = [2740, 3090]
+y = [5490, 5640]
+
+[clan_wars_ffa_safe_arena]
+x = [2756, 2878]
+y = [5512, 5630]
+
+[clan_wars_ffa_safe_multi]
+x = [2756, 2878]
+y = [5571, 5630]
+tags = ["multi_combat"]
+
+[clan_wars_ffa_dangerous_arena]
+x = [2948, 3071]
+y = [5512, 5631]
+
+[clan_wars_ffa_dangerous_multi]
+x = [2948, 3071]
+y = [5571, 5631]
+tags = ["multi_combat"]
diff --git a/data/minigame/clan_wars/clan_wars.ifaces.toml b/data/minigame/clan_wars/clan_wars.ifaces.toml
@@ -1,5 +1,6 @@
 [clan_wars]
 id = 789
+type = "overlay"
 
 [clan_wars_defeat]
 id = 790
@@ -10,6 +11,3 @@ id = 791
 [clan_wars_overview]
 id = 792
 
-[clan_wars_respawn]
-id = 793
-
diff --git a/data/minigame/clan_wars/clan_wars.objs.toml b/data/minigame/clan_wars/clan_wars.objs.toml
@@ -0,0 +1,15 @@
+[clan_wars_portal_ffa_safe]
+id = 38698
+examine = "A portal to a safe free-for-all fighting area."
+
+[clan_wars_portal_ffa_dangerous]
+id = 38699
+examine = "A portal to a dangerous free-for-all fighting area."
+
+[clan_wars_challenge_portal]
+id = 28213
+examine = "A portal to the Clan Wars arena."
+
+[clan_wars_portal_ffa_safe_exit]
+id = 38700
+examine = "Leave the free-for-all fighting area."
diff --git a/data/minigame/clan_wars/clan_wars.varbits.toml b/data/minigame/clan_wars/clan_wars.varbits.toml
@@ -0,0 +1,3 @@
+[clan_wars_ffa_portal]
+id = 5279
+format = "int"
diff --git a/data/skill/range/ammo_groups.toml b/data/skill/range/ammo_groups.toml
@@ -72,6 +72,10 @@ items = [
     "rune_arrow",
     "rune_fire_arrows_lit",
     "rune_fire_arrows_unlit",
+    "dragon_arrow",
+    "dragon_arrow_p",
+    "dragon_arrow_p+",
+    "dragon_arrow_p++",
     "ice_arrows",
     "broad_arrows",
     "saradomin_arrows",
diff --git a/engine/src/main/kotlin/world/gregs/voidps/engine/data/AccountManager.kt b/engine/src/main/kotlin/world/gregs/voidps/engine/data/AccountManager.kt
@@ -41,7 +41,6 @@ class AccountManager(
         get() = Tile(Settings["world.home.x", 0], Settings["world.home.y", 0], Settings["world.home.level", 0])
 
     fun create(name: String, passwordHash: String): Player = Player(tile = homeTile, accountName = name, passwordHash = passwordHash).apply {
-        this["creation"] = System.currentTimeMillis()
         this["new_player"] = true
     }
 
diff --git a/engine/src/main/kotlin/world/gregs/voidps/engine/entity/character/mode/combat/CombatMovement.kt b/engine/src/main/kotlin/world/gregs/voidps/engine/entity/character/mode/combat/CombatMovement.kt
@@ -16,9 +16,7 @@ import world.gregs.voidps.engine.entity.character.player.chat.cantReach
 import world.gregs.voidps.engine.entity.item.Item
 import world.gregs.voidps.engine.get
 import world.gregs.voidps.engine.map.Overlap
-import world.gregs.voidps.type.Direction
 import world.gregs.voidps.type.Tile
-import world.gregs.voidps.type.random
 import kotlin.math.abs
 
 /**
@@ -60,7 +58,6 @@ class CombatMovement(
         if (!attack()) {
             var skip: Boolean
             if (Overlap.isUnder(character.tile, character.size, target.tile, target.size)) {
-                stepOut()
                 skip = true
             } else {
                 val wasEmpty = character.steps.isEmpty()
@@ -81,17 +78,8 @@ class CombatMovement(
         }
     }
 
-    private fun stepOut() {
-        clearSteps()
-        if (target.mode is CombatMovement || target.mode is Interact) {
-            return
-        }
-        val direction = Direction.cardinal.random(random)
-        if (!canStep(direction.delta.x, direction.delta.y)) {
-            return
-        }
-        character.steps.queueStep(strategy.tile.add(direction))
-    }
+    override fun shouldQueueStepOut(): Boolean =
+        target.mode !is CombatMovement && target.mode !is Interact
 
     private fun attack(): Boolean {
         val attackRange = attackRange()
diff --git a/engine/src/main/kotlin/world/gregs/voidps/engine/entity/character/mode/interact/Interact.kt b/engine/src/main/kotlin/world/gregs/voidps/engine/entity/character/mode/interact/Interact.kt
@@ -86,6 +86,11 @@ open class Interact(
             return
         }
         updateRange = false
+        val target = target
+        if (stepOut()) {
+            super.tick()
+            return
+        }
         calculate()
         val interacted = processInteraction()
         if (interacted && interactionFinished()) {
diff --git a/engine/src/main/kotlin/world/gregs/voidps/engine/entity/character/mode/move/Movement.kt b/engine/src/main/kotlin/world/gregs/voidps/engine/entity/character/mode/move/Movement.kt
@@ -26,6 +26,7 @@ import world.gregs.voidps.type.Delta
 import world.gregs.voidps.type.Direction
 import world.gregs.voidps.type.Tile
 import world.gregs.voidps.type.equals
+import world.gregs.voidps.type.random
 import kotlin.math.sign
 
 open class Movement(
@@ -53,6 +54,32 @@ open class Movement(
         needsCalculation = false
     }
 
+    /**
+     * Clears steps and queues a random cardinal step when an NPC overlaps its character target and isn't permitted to stand there.
+     */
+    protected open fun stepOut(): Boolean {
+        val strategy = strategy ?: return false
+        if (strategy.shape != -2) return false
+        val npc = character as? NPC ?: return false
+        if (npc.def["allowed_under", false]) return false
+        if (!Overlap.isUnder(npc.tile, npc.size, npc.size, strategy.tile, strategy.width, strategy.height)) return false
+        clearSteps()
+        if (shouldQueueStepOut()) {
+            for (direction in Direction.cardinal.shuffled(random)) {
+                if (canStep(direction.delta.x, direction.delta.y)) {
+                    character.steps.queueStep(npc.tile.add(direction))
+                    break
+                }
+            }
+        }
+        return true
+    }
+
+    /**
+     * Whether [stepOut] should queue a random step after clearing, or let normal recalculation handle repositioning.
+     */
+    protected open fun shouldQueueStepOut(): Boolean = true
+
     override fun tick() {
         val character = character
         if (character is Player && character.viewport?.loaded == false) {
@@ -61,7 +88,9 @@ open class Movement(
         if (hasDelay() && !canMove() && !character.steps.destination.noCollision) {
             return
         }
-        calculate()
+        if (!stepOut()) {
+            calculate()
+        }
         if (step(runStep = false) && character.running) {
             if (character.steps.isNotEmpty()) {
                 step(runStep = true)
diff --git a/engine/src/test/kotlin/world/gregs/voidps/engine/data/AccountManagerTest.kt b/engine/src/test/kotlin/world/gregs/voidps/engine/data/AccountManagerTest.kt
@@ -85,9 +85,7 @@ class AccountManagerTest : KoinMock() {
 
     @Test
     fun `Create a new player`() {
-        val start = System.currentTimeMillis()
         val player = manager.create("name", "hash")
-        assertTrue(player["creation", 0L] >= start)
         assertTrue(player["new_player", false])
         assertEquals(Tile(1234, 5432), player.tile)
     }
diff --git a/game/src/main/kotlin/content/area/karamja/tzhaar_city/TzhaarFightCave.kt b/game/src/main/kotlin/content/area/karamja/tzhaar_city/TzhaarFightCave.kt
@@ -123,6 +123,9 @@ class TzhaarFightCave(
                 return@npcDespawn
             }
             val wave = killer.wave
+            if (wave == -1) {
+                return@npcDespawn
+            }
             if (wave == 63 && id == "tztok_jad") {
                 killer.leave(wave, true)
             } else if (wave < 63) {
diff --git a/game/src/main/kotlin/content/entity/player/bank/BankTabCollapse.kt b/game/src/main/kotlin/content/entity/player/bank/BankTabCollapse.kt
@@ -2,7 +2,6 @@ package content.entity.player.bank
 
 import content.entity.player.bank.Bank.tabIndex
 import world.gregs.voidps.engine.Script
-import world.gregs.voidps.engine.inv.transact.operation.ShiftItem.shiftToFreeIndex
 
 class BankTabCollapse : Script {
 
@@ -11,9 +10,17 @@ class BankTabCollapse : Script {
             val tab = it.component.removePrefix("tab_").toInt() - 1
             val tabIndex = tabIndex(this, tab)
             val count: Int = get("bank_tab_$tab", 0)
+            val lastIndex = bank.count - 1
             val collapsed = bank.transaction {
-                repeat(count) {
-                    shiftToFreeIndex(tabIndex)
+                // Save the tab items being collapsed
+                val tabItems = (0 until count).map { inventory[tabIndex + it] }
+                // Shift all items after the tab left by count to close the gap
+                for (i in tabIndex until lastIndex - count + 1) {
+                    set(i, inventory[i + count])
+                }
+                // Place the collapsed tab items at the end
+                for (i in tabItems.indices) {
+                    set(lastIndex - count + 1 + i, tabItems[i])
                 }
             }
             if (collapsed) {
diff --git a/game/src/main/kotlin/content/entity/player/bank/BankTabs.kt b/game/src/main/kotlin/content/entity/player/bank/BankTabs.kt
@@ -38,7 +38,7 @@ class BankTabs : Script {
             set("bank_item_mode", if (value == "insert") "swap" else "insert")
         }
 
-        interfaceSwap("bank:tab_#") { _, toId, fromSlot, _ ->
+        interfaceSwap("bank:inventory", "bank:tab_#") { _, toId, fromSlot, _ ->
             val fromTab = Bank.getTab(this, fromSlot)
             val toTab = toId.substringAfter(":").removePrefix("tab_").toInt() - 1
             val toIndex = if (toTab == Bank.MAIN_TAB) bank.freeIndex() else Bank.tabIndex(this, toTab + 1)
diff --git a/game/src/main/kotlin/content/minigame/clan_wars/ClanWarsFreeForAll.kt b/game/src/main/kotlin/content/minigame/clan_wars/ClanWarsFreeForAll.kt
diff --git a/game/src/main/kotlin/content/skill/melee/weapon/special/DragonClaws.kt b/game/src/main/kotlin/content/skill/melee/weapon/special/DragonClaws.kt
diff --git a/game/src/test/kotlin/content/entity/combat/CombatMovementTest.kt b/game/src/test/kotlin/content/entity/combat/CombatMovementTest.kt

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+[clan_wars_ffa_portal]`
	`2`	`+id = 5279`
	`3`	`+format = "int"`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,6 @@ class AccountManager(`
`41`	`41`	`get() = Tile(Settings["world.home.x", 0], Settings["world.home.y", 0], Settings["world.home.level", 0])`
`42`	`42`
`43`	`43`	`fun create(name: String, passwordHash: String): Player = Player(tile = homeTile, accountName = name, passwordHash = passwordHash).apply {`
`44`		`- this["creation"] = System.currentTimeMillis()`
`45`	`44`	`this["new_player"] = true`
`46`	`45`	`}`
`47`	`46`