so it turns out you shouldn't reuse the same filter instance for everything

Author: ghzdude

src/main/java/gregtech/common/covers/filter/BaseFilter.java

@@ -26,6 +26,11 @@ public BaseFilterReader getFilterReader() {
             return reader;
         }
 
+        @Override
+        public BaseFilter copy() {
+            return this;
+        }
+
         @Override
         public FilterType getType() {
             return FilterType.ERROR;
@@ -34,6 +39,8 @@ public FilterType getType() {
 
     public abstract BaseFilterReader getFilterReader();
 
+    public abstract BaseFilter copy();
+
     public final void updateFilterReader(ItemStack stack) {
         getFilterReader().readStack(stack);
     }
@@ -55,6 +62,7 @@ public final ItemStack getContainerStack() {
         if (stack.getItem() instanceof MetaItem<?>metaItem) {
             return Optional.ofNullable(metaItem.getItem(stack))
                     .map(MetaItem.MetaValueItem::getFilterBehavior)
+                    .map(BaseFilter::copy)
                     .orElse(ERROR_FILTER);
         }
         return ERROR_FILTER;

src/main/java/gregtech/common/covers/filter/OreDictionaryItemFilter.java

@@ -113,4 +113,9 @@ public boolean matchesItemStack(@NotNull ItemStack itemStack) {
     public boolean showGlobalTransferLimitSlider() {
         return true;
     }
+
+    @Override
+    public BaseFilter copy() {
+        return new OreDictionaryItemFilter();
+    }
 }

src/main/java/gregtech/common/covers/filter/SimpleFluidFilter.java

@@ -62,4 +62,9 @@ public int getTransferLimit(FluidStack fluidStack, int transferSize) {
     public FilterType getType() {
         return FilterType.FLUID;
     }
+
+    @Override
+    public BaseFilter copy() {
+        return new SimpleFluidFilter();
+    }
 }

src/main/java/gregtech/common/covers/filter/SimpleItemFilter.java

@@ -48,6 +48,11 @@ public int getTransferLimit(ItemStack stack, int transferSize) {
         return getTransferLimit(matchedSlot, transferSize);
     }
 
+    @Override
+    public BaseFilter copy() {
+        return new SimpleItemFilter();
+    }
+
     public static int itemFilterMatch(IItemHandler filterSlots, boolean ignoreDamage,
                                       boolean ignoreNBTData, ItemStack itemStack) {
         for (int i = 0; i < filterSlots.getSlots(); i++) {

src/main/java/gregtech/common/covers/filter/SmartItemFilter.java

@@ -76,6 +76,11 @@ public boolean showGlobalTransferLimitSlider() {
         return true;
     }
 
+    @Override
+    public BaseFilter copy() {
+        return new SmartItemFilter();
+    }
+
     private static class ItemAndMetadataAndStackSize {
 
         public final ItemAndMetadata itemAndMetadata;