clean out mte holder

should theoretically still work if anyone extended the class
clean up GTBaseTileEntity

Author: ghzdude

src/main/java/gregtech/api/metatileentity/GTBaseTileEntity.java

@@ -217,17 +217,12 @@ protected void addAdditionalData(NBTTagCompound updateTag) {
     @Override
     public void writeInitialSyncData(@NotNull PacketBuffer buf) {
         buf.writeString(getName());
-        // below this might not be necessary anymore ?
-        buf.writeBoolean(true);
-        buf.writeVarInt(getRegistry().getNetworkId());
-        buf.writeVarInt(getRegistry().getIdByObjectName(getMetaID()));
         writeInitialSyncDataMTE(buf);
     }
 
     @Override
     public void receiveInitialSyncData(@NotNull PacketBuffer buf) {
         setCustomName(buf.readString(Short.MAX_VALUE));
-        buf.readBoolean();
         receiveMTEInitializationData(buf);
     }
 
@@ -244,10 +239,8 @@ public void receiveCustomData(int discriminator, @NotNull PacketBuffer buffer) {
      * @param buf the buffer to read data from
      */
     private void receiveMTEInitializationData(@NotNull PacketBuffer buf) {
-        int networkId = buf.readVarInt();
-        int metaTileEntityId = buf.readVarInt();
-        this.onPlacement();
         this.receiveInitialSyncDataMTE(buf);
+        this.onPlacement();
         scheduleRenderUpdate();
         this.needToUpdateLightning = true;
     }
@@ -338,7 +331,7 @@ public boolean shouldRenderInPass(int pass) {
     @NotNull
     @Override
     public AxisAlignedBB getRenderBoundingBox() {
-        if (this instanceof IFastRenderMetaTileEntity fastRender) {
+        if (getMetaTileEntity() instanceof IFastRenderMetaTileEntity fastRender) {
             return fastRender.getRenderBoundingBox();
         }
         return new AxisAlignedBB(getPos());
@@ -541,11 +534,7 @@ public DimensionalCoord getLocation() {
 
     @Override
     @Optional.Method(modid = Mods.Names.APPLIED_ENERGISTICS2)
-    public void gridChanged() {
-        // if (metaTileEntity != null) {
-        // metaTileEntity.gridChanged();
-        // }
-    }
+    public void gridChanged() {}
 
     @Optional.Method(modid = Mods.Names.APPLIED_ENERGISTICS2)
     public void readFromNBT_AENetwork(NBTTagCompound data) {

src/main/java/gregtech/api/metatileentity/MetaTileEntity.java

@@ -178,6 +178,7 @@ public abstract class MetaTileEntity extends GTBaseTileEntity
 
     protected MetaTileEntity(@NotNull ResourceLocation metaTileEntityId) {
         this.metaTileEntityId = metaTileEntityId;
+        this.holder = this;
         this.registry = GregTechAPI.mteManager.getRegistry(metaTileEntityId.getNamespace());
         initializeInventory();
     }
@@ -194,8 +195,9 @@ protected void initializeInventory() {
 
     // todo remove this
     @Deprecated
+    @ApiStatus.ScheduledForRemoval(inVersion = "2.10")
     public IGregTechTileEntity getHolder() {
-        return this;
+        return this.holder;
     }
 
     @Deprecated
@@ -1229,11 +1231,6 @@ public final void setOutputRedstoneSignal(EnumFacing side, int strength) {
         }
     }
 
-    @Override
-    public void notifyBlockUpdate() {
-        if (holder != null) holder.notifyBlockUpdate();
-    }
-
     @Override
     public void scheduleRenderUpdate() {
         super.scheduleRenderUpdate(); // this call is required