Yeet some things and clarify others

Author: M-W-K

src/main/java/gregtech/api/pipenet/block/BlockPipe.java

@@ -175,7 +175,6 @@ public ItemStack getItem(@NotNull World world, @NotNull BlockPos pos, @NotNull I
 
     protected abstract NodeDataType getFallbackType();
 
-    // TODO this has no reason to need an ItemStack parameter
     public abstract PipeType getPipeType();
 
     public abstract void setTileEntityData(TileEntityPipeBase<PipeType, NodeDataType> pipeTile, ItemStack itemStack);

src/main/java/gregtech/client/renderer/pipe/cover/CoverRendererBuilder.java

@@ -37,7 +37,7 @@ public class CoverRendererBuilder {
     private static final ColorQuadCache[] PLATE_QUADS;
     private static final EnumMap<EnumFacing, SubListAddress> PLATE_COORDS = new EnumMap<>(EnumFacing.class);
 
-    private static final UVMapper defaultMapper = UVMapper.standard(0);
+    private static final UVMapper DEFAULT_MAPPER = UVMapper.standard(0);
 
     static {
         PLATE_QUADS = new ColorQuadCache[Textures.VOLTAGE_CASINGS.length];
@@ -64,7 +64,7 @@ protected static SubListAddress buildPlates(List<RecolorableBakedQuad> quads, En
         int start = quads.size();
         Pair<Vector3f, Vector3f> box = CoverRendererValues.PLATE_BOXES.get(facing);
         for (EnumFacing dir : EnumFacing.values()) {
-            quads.add(QuadHelper.buildQuad(dir, box, CoverRendererBuilder.defaultMapper, sprite));
+            quads.add(QuadHelper.buildQuad(dir, box, CoverRendererBuilder.DEFAULT_MAPPER, sprite));
         }
         return new SubListAddress(start, quads.size());
     }
@@ -78,8 +78,8 @@ protected static void addPlates(List<BakedQuad> quads, List<BakedQuad> plateQuad
     protected final TextureAtlasSprite sprite;
     protected final TextureAtlasSprite spriteEmissive;
 
-    protected UVMapper mapper = defaultMapper;
-    protected UVMapper mapperEmissive = defaultMapper;
+    protected UVMapper mapper = DEFAULT_MAPPER;
+    protected UVMapper mapperEmissive = DEFAULT_MAPPER;
 
     protected ColorQuadCache plateQuads = PLATE_QUADS[1];
 

src/main/java/gregtech/client/renderer/pipe/util/ActivableCacheKey.java

@@ -25,5 +25,6 @@ public boolean isActive() {
         return active;
     }
 
-    // activeness is merely a way to pass information onwards, it does not result in separate mappings.
+    // activeness is merely a way to pass information onwards, it does not require a separate cache to be built.
+    // thus we do not override equals() and hashCode() to account for the active field.
 }