Skip to content

Commit a27080c

Browse files
committed
Only create and register sync handlers if the rows are enabled
1 parent 082470c commit a27080c

File tree

2 files changed

+22
-20
lines changed

2 files changed

+22
-20
lines changed

src/main/java/gregtech/common/covers/CoverConveyor.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -499,24 +499,14 @@ public ModularPanel buildUI(SidedPosGuiData guiData, PanelSyncManager guiSyncMan
499499

500500
protected Flow createUI(GuiData data, PanelSyncManager guiSyncManager) {
501501
// noinspection DuplicatedCode
502-
EnumSyncValue<ManualImportExportMode> manualIOModeSync = new EnumSyncValue<>(ManualImportExportMode.class,
503-
this::getManualImportExportMode, this::setManualImportExportMode);
504-
EnumSyncValue<IOMode> conveyorModeSync = new EnumSyncValue<>(IOMode.class, this::getIOMode, this::setIOMode);
505-
EnumSyncValue<DistributionMode> distributionModeSync = new EnumSyncValue<>(DistributionMode.class,
506-
this::getDistributionMode, this::setDistributionMode);
507-
IntSyncValue throughputSync = new IntSyncValue(this::getTransferRate, this::setTransferRate);
508-
509-
guiSyncManager.syncValue("manual_io", manualIOModeSync);
510-
guiSyncManager.syncValue("conveyor_mode", conveyorModeSync);
511-
guiSyncManager.syncValue("distribution_mode", distributionModeSync);
512-
513502
Flow column = Flow.column()
514503
.top(24)
515504
.widthRel(1f)
516505
.margin(7, 0)
517506
.coverChildrenHeight();
518507

519508
if (createThroughputRow()) {
509+
IntSyncValue throughputSync = new IntSyncValue(this::getTransferRate, this::setTransferRate);
520510
column.child(Flow.row()
521511
.widthRel(1f)
522512
.coverChildrenHeight()
@@ -553,7 +543,14 @@ protected Flow createUI(GuiData data, PanelSyncManager guiSyncManager) {
553543
column.child(getItemFilterContainer().initUI(data, guiSyncManager));
554544
}
555545

546+
EnumSyncValue<IOMode> conveyorModeSync = new EnumSyncValue<>(IOMode.class, this::getIOMode, this::setIOMode);
547+
guiSyncManager.syncValue("conveyor_mode", conveyorModeSync);
548+
556549
if (createManualIOModeRow()) {
550+
EnumSyncValue<ManualImportExportMode> manualIOModeSync = new EnumSyncValue<>(ManualImportExportMode.class,
551+
this::getManualImportExportMode, this::setManualImportExportMode);
552+
guiSyncManager.syncValue("manual_io", manualIOModeSync);
553+
557554
// noinspection DuplicatedCode
558555
column.child(new EnumRowBuilder<>(ManualImportExportMode.class)
559556
.value(manualIOModeSync)
@@ -581,6 +578,10 @@ protected Flow createUI(GuiData data, PanelSyncManager guiSyncManager) {
581578
}
582579

583580
if (createDistributionModeRow()) {
581+
EnumSyncValue<DistributionMode> distributionModeSync = new EnumSyncValue<>(DistributionMode.class,
582+
this::getDistributionMode, this::setDistributionMode);
583+
guiSyncManager.syncValue("distribution_mode", distributionModeSync);
584+
584585
column.child(new EnumRowBuilder<>(DistributionMode.class)
585586
.value(distributionModeSync)
586587
.rowDescription(IKey.lang("cover.conveyor.distribution.name"))

src/main/java/gregtech/common/covers/CoverPump.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -187,21 +187,14 @@ public ModularPanel buildUI(SidedPosGuiData guiData, PanelSyncManager guiSyncMan
187187

188188
protected Flow createUI(GuiData data, PanelSyncManager syncManager) {
189189
// noinspection DuplicatedCode
190-
EnumSyncValue<ManualImportExportMode> manualIOModeSync = new EnumSyncValue<>(ManualImportExportMode.class,
191-
this::getManualImportExportMode, this::setManualImportExportMode);
192-
EnumSyncValue<IOMode> pumpModeSync = new EnumSyncValue<>(IOMode.class, this::getIoMode, this::setIoMode);
193-
IntSyncValue throughputSync = new IntSyncValue(this::getTransferRate, this::setTransferRate);
194-
195-
syncManager.syncValue("manual_io", manualIOModeSync);
196-
syncManager.syncValue("pump_mode", pumpModeSync);
197-
198190
Flow column = Flow.column()
199191
.top(24)
200192
.margin(7, 0)
201193
.widthRel(1f)
202194
.coverChildrenHeight();
203195

204-
if (createThroughputRow())
196+
if (createThroughputRow()) {
197+
IntSyncValue throughputSync = new IntSyncValue(this::getTransferRate, this::setTransferRate);
205198
column.child(Flow.row()
206199
.widthRel(1f)
207200
.marginBottom(2)
@@ -230,12 +223,20 @@ protected Flow createUI(GuiData data, PanelSyncManager syncManager) {
230223
return true;
231224
})
232225
.onUpdateListener(w -> w.overlay(createAdjustOverlay(true)))));
226+
}
233227

234228
if (createFilterRow()) {
235229
column.child(getFluidFilterContainer().initUI(data, syncManager));
236230
}
237231

232+
EnumSyncValue<IOMode> pumpModeSync = new EnumSyncValue<>(IOMode.class, this::getIoMode, this::setIoMode);
233+
syncManager.syncValue("pump_mode", pumpModeSync);
234+
238235
if (createManualIOModeRow()) {
236+
EnumSyncValue<ManualImportExportMode> manualIOModeSync = new EnumSyncValue<>(ManualImportExportMode.class,
237+
this::getManualImportExportMode, this::setManualImportExportMode);
238+
syncManager.syncValue("manual_io", manualIOModeSync);
239+
239240
// noinspection DuplicatedCode
240241
column.child(new EnumRowBuilder<>(ManualImportExportMode.class)
241242
.value(manualIOModeSync)

0 commit comments

Comments
 (0)