-
Notifications
You must be signed in to change notification settings - Fork 419
chore: update datafusion to 50 #7076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: luofucong <[email protected]>
Signed-off-by: luofucong <[email protected]>
e271446
to
b39a712
Compare
ea669bd
to
73eac59
Compare
Signed-off-by: luofucong <[email protected]>
73eac59
to
5b5f280
Compare
Signed-off-by: luofucong <[email protected]>
Signed-off-by: luofucong <[email protected]>
a08af4f
to
1f9a060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the DataFusion dependency from version 49 to version 50, along with related dependencies like Arrow and SQLParser to keep the codebase in sync with upstream changes.
- Dependency version updates for DataFusion ecosystem (datafusion, arrow, sqlparser)
- API compatibility updates for DataFusion 50's breaking changes
- Test result updates reflecting changes in query output formatting and behavior
Reviewed Changes
Copilot reviewed 62 out of 63 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
Cargo.toml | Updates DataFusion from v49 to v50, Arrow to v56.2, and SQLParser to v0.58.0 |
tests/cases/standalone/common/* | Test result updates reflecting new DataFusion output formatting |
src/sql/src/parser.rs | Updates canonicalize_object_name to return Result type for error handling |
src/query/src/part_sort.rs | Adds TopKDynamicFilters parameter to TopK::try_new calls |
src/common/function/src/scalars/udf.rs | Implements PartialEq, Eq, and Hash traits for ScalarUdf |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you!
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
just trying to keep up with our dependency
PR Checklist
Please convert it to a draft if some of the following conditions are not met.