Skip to content

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

just trying to keep up with our dependency

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@github-actions github-actions bot added size/L docs-not-required This change does not impact docs. labels Oct 13, 2025
Signed-off-by: luofucong <[email protected]>
@MichaelScofield MichaelScofield force-pushed the chore/update-datafusion branch from e271446 to b39a712 Compare October 13, 2025 13:37
@MichaelScofield MichaelScofield force-pushed the chore/update-datafusion branch 5 times, most recently from ea669bd to 73eac59 Compare October 15, 2025 03:43
Signed-off-by: luofucong <[email protected]>
@MichaelScofield MichaelScofield force-pushed the chore/update-datafusion branch from 73eac59 to 5b5f280 Compare October 15, 2025 05:07
Signed-off-by: luofucong <[email protected]>
@MichaelScofield MichaelScofield force-pushed the chore/update-datafusion branch from a08af4f to 1f9a060 Compare October 20, 2025 11:07
@MichaelScofield MichaelScofield marked this pull request as ready for review October 20, 2025 11:09
@MichaelScofield MichaelScofield requested review from a team and zhongzc as code owners October 20, 2025 11:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the DataFusion dependency from version 49 to version 50, along with related dependencies like Arrow and SQLParser to keep the codebase in sync with upstream changes.

  • Dependency version updates for DataFusion ecosystem (datafusion, arrow, sqlparser)
  • API compatibility updates for DataFusion 50's breaking changes
  • Test result updates reflecting changes in query output formatting and behavior

Reviewed Changes

Copilot reviewed 62 out of 63 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Cargo.toml Updates DataFusion from v49 to v50, Arrow to v56.2, and SQLParser to v0.58.0
tests/cases/standalone/common/* Test result updates reflecting new DataFusion output formatting
src/sql/src/parser.rs Updates canonicalize_object_name to return Result type for error handling
src/query/src/part_sort.rs Adds TopKDynamicFilters parameter to TopK::try_new calls
src/common/function/src/scalars/udf.rs Implements PartialEq, Eq, and Hash traits for ScalarUdf

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants