fix lint

Author: MichaelScofield

.golangci.yaml

@@ -2,44 +2,10 @@ version: "2"
 
 # Options for analysis running.
 run:
-  # Timeout for analysis, e.g. 30s, 5m.
-  # Default: 1m
-  timeout: 10m
-
-  # The default concurrency value is the number of available CPU.
-  concurrency: 4
-
-  # Which dirs to skip: issues from them won't be reported.
-  # Can use regexp here: `generated.*`, regexp is applied on full path,
-  # including the path prefix if one is set.
-  # Default value is empty list,
-  # but default dirs are skipped independently of this option's value (see skip-dirs-use-default).
-  # "/" will be replaced by current OS file path separator to properly work on Windows.
-  skip-dirs:
-    - bin
-    - docs
-    - examples
-    - hack
-
-# output configuration options.
-output:
-  # Format: colored-line-number|line-number|json|colored-tab|tab|checkstyle|code-climate|junit-xml|github-actions|teamcity
-  #
-  # Multiple can be specified by separating them by comma, output can be provided
-  # for each of them by separating format name and path by colon symbol.
-  # Output path can be either `stdout`, `stderr` or path to the file to write to.
-  # Example: "checkstyle:report.xml,json:stdout,colored-line-number"
-  #
-  # Default: colored-line-number
-  format: colored-line-number
-
-  # Print lines of code with issue.
-  # Default: true
-  print-issued-lines: true
-
-  # Print linter name in the end of issue text.
-  # Default: true
-  print-linter-lines: true
+  # Timeout for total work, e.g. 30s, 5m, 5m30s.
+  # If the value is lower or equal to 0, the timeout is disabled.
+  # Default: 0 (disabled)
+  timeout: 5m
 
 linters:
   # Default set of linters.
@@ -49,107 +15,9 @@ linters:
   # - `none`: disables all linters by default.
   # - `fast`: enables only linters considered as "fast" (`golangci-lint help linters --json | jq '[ .[] | select(.fast==true) ] | map(.name)'`).
   # Default: standard
-  default: all
-  # All available settings of specific linters.
-  settings:
-    # See the dedicated "linters.settings" documentation section.
-    option: value
-  # Defines a set of rules to ignore issues.
-  # It does not skip the analysis, and so does not ignore "typecheck" errors.
-  exclusions:
-    # Mode of the generated files analysis.
-    #
-    # - `strict`: sources are excluded by strictly following the Go generated file convention.
-    #    Source files that have lines matching only the following regular expression will be excluded: `^// Code generated .* DO NOT EDIT\.$`
-    #    This line must appear before the first non-comment, non-blank text in the file.
-    #    https://go.dev/s/generatedcode
-    # - `lax`: sources are excluded if they contain lines like `autogenerated file`, `code generated`, `do not edit`, etc.
-    # - `disable`: disable the generated files exclusion.
-    #
-    # Default: strict
-    generated: lax
-    # Log a warning if an exclusion rule is unused.
-    # Default: false
-    warn-unused: true
-    # Predefined exclusion rules.
-    # Default: []
-    presets:
-      - comments
-      - std-error-handling
-      - common-false-positives
-      - legacy
-    # Excluding configuration per-path, per-linter, per-text and per-source.
-    rules:
-      # Exclude some linters from running on tests files.
-      - path: _test\.go
-        linters:
-          - gocyclo
-          - errcheck
-          - dupl
-          - gosec
-      # Run some linter only for test files by excluding its issues for everything else.
-      - path-except: _test\.go
-        linters:
-          - forbidigo
-      # Exclude known linters from partially hard-vendored code,
-      # which is impossible to exclude via `nolint` comments.
-      # `/` will be replaced by the current OS file path separator to properly work on Windows.
-      - path: internal/hmac/
-        text: "weak cryptographic primitive"
-        linters:
-          - gosec
-      # Exclude some `staticcheck` messages.
-      - linters:
-          - staticcheck
-        text: "SA9003:"
-      # Exclude `lll` issues for long lines with `go:generate`.
-      - linters:
-          - lll
-        source: "^//go:generate "
-    # Which file paths to exclude: they will be analyzed, but issues from them won't be reported.
-    # "/" will be replaced by the current OS file path separator to properly work on Windows.
-    # Default: []
-    paths:
-      - ".*\\.my\\.go$"
-      - lib/bad.go
-    # Which file paths to not exclude.
-    # Default: []
-    paths-except:
-      - ".*\\.my\\.go$"
-      - lib/bad.go
+  default: standard
 
 formatters:
   # Enable specific formatter.
   # Default: [] (uses standard Go formatting)
-  enable:
-    - gci
-    - gofmt
-    - gofumpt
-    - goimports
-    - golines
-    - swaggo
-  # Formatters settings.
-  settings:
-    # See the dedicated "formatters.settings" documentation section.
-    option: value
-  exclusions:
-    # Log a warning if an exclusion path is unused.
-    # Default: false
-    warn-unused: true
-    # Mode of the generated files analysis.
-    #
-    # - `strict`: sources are excluded by strictly following the Go generated file convention.
-    #    Source files that have lines matching only the following regular expression will be excluded: `^// Code generated .* DO NOT EDIT\.$`
-    #    This line must appear before the first non-comment, non-blank text in the file.
-    #    https://go.dev/s/generatedcode
-    # - `lax`: sources are excluded if they contain lines like `autogenerated file`, `code generated`, `do not edit`, etc.
-    # - `disable`: disable the generated files exclusion.
-    #
-    # Default: lax
-    generated: strict
-    # Which file paths to exclude.
-    # This option is ignored when using `--stdin` as the path is unknown.
-    # Default: []
-    paths:
-      - ".*\\.my\\.go$"
-      - lib/bad.go
+  enable: []

go.mod

@@ -1,6 +1,6 @@
 module github.com/GreptimeTeam/gtctl
 
-go 1.18
+go 1.25
 
 require (
 	github.com/GreptimeTeam/greptimedb-operator v0.1.0-alpha.9

pkg/artifacts/manager.go

@@ -246,7 +246,7 @@ func (m *manager) downloadFromHTTP(ctx context.Context, httpURL string, dest str
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("download failed, status code: %d", resp.StatusCode)
 	}
-	defer resp.Body.Close()
+	defer fileutils.MustClose(resp.Body)
 
 	data, err := io.ReadAll(resp.Body)
 	if err != nil {
@@ -306,7 +306,7 @@ func (m *manager) chartIndexFile(ctx context.Context, indexURL string) (*repo.In
 	if err != nil {
 		return nil, err
 	}
-	defer rsp.Body.Close()
+	defer fileutils.MustClose(rsp.Body)
 
 	data, err := io.ReadAll(rsp.Body)
 	if err != nil {
@@ -431,7 +431,7 @@ func (m *manager) installBinaries(downloadFile, installDir string) error {
 	if err != nil {
 		return err
 	}
-	defer os.RemoveAll(tempDir)
+	defer fileutils.RemoveAll(tempDir)
 
 	if err := fileutils.Uncompress(downloadFile, tempDir); err != nil {
 		return err
@@ -525,7 +525,7 @@ func (m *manager) getVersionInfoFromS3(typ ArtifactType, name string, nightly bo
 	if resp.StatusCode != http.StatusOK {
 		return "", fmt.Errorf("get latest info from '%s' failed, status code: %d", latestVersionInfoURL, resp.StatusCode)
 	}
-	defer resp.Body.Close()
+	defer fileutils.MustClose(resp.Body)
 
 	data, err := io.ReadAll(resp.Body)
 	if err != nil {

pkg/artifacts/manager_test.go

@@ -26,14 +26,15 @@ import (
 	"sigs.k8s.io/kind/pkg/log"
 
 	"github.com/GreptimeTeam/gtctl/pkg/logger"
+	"github.com/GreptimeTeam/gtctl/pkg/utils/file"
 )
 
 func TestDownloadCharts(t *testing.T) {
 	tempDir, err := os.MkdirTemp("/tmp", "gtctl-ut-")
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.RemoveAll(tempDir)
+	defer file.RemoveAll(tempDir)
 
 	m, err := NewManager(logger.New(os.Stdout, log.Level(4), logger.WithColored()))
 	if err != nil {
@@ -79,7 +80,7 @@ func TestDownloadChartsFromCNRegion(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.RemoveAll(tempDir)
+	defer file.RemoveAll(tempDir)
 
 	m, err := NewManager(logger.New(os.Stdout, log.Level(4), logger.WithColored()))
 	if err != nil {
@@ -125,7 +126,7 @@ func TestDownloadBinariesFromCNRegion(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.RemoveAll(tempDir)
+	defer file.RemoveAll(tempDir)
 
 	m, err := NewManager(logger.New(os.Stdout, log.Level(4), logger.WithColored()))
 	if err != nil {
@@ -171,7 +172,7 @@ func TestDownloadBinaries(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.RemoveAll(tempDir)
+	defer file.RemoveAll(tempDir)
 
 	m, err := NewManager(logger.New(os.Stdout, log.Level(4), logger.WithColored()))
 	if err != nil {
@@ -218,7 +219,7 @@ func TestArtifactsCache(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.RemoveAll(tempDir)
+	defer file.RemoveAll(tempDir)
 
 	m, err := NewManager(logger.New(os.Stdout, log.Level(4), logger.WithColored()))
 	if err != nil {

pkg/helm/loader_test.go

@@ -26,6 +26,7 @@ import (
 	"github.com/GreptimeTeam/gtctl/pkg/artifacts"
 	opt "github.com/GreptimeTeam/gtctl/pkg/cluster"
 	"github.com/GreptimeTeam/gtctl/pkg/logger"
+	"github.com/GreptimeTeam/gtctl/pkg/utils/file"
 )
 
 const (
@@ -37,7 +38,7 @@ func TestLoadAndRenderChart(t *testing.T) {
 	if err != nil {
 		t.Errorf("failed to create render: %v", err)
 	}
-	defer cleanMetadataDir()
+	defer file.RemoveAll(testMetadataDir)
 
 	opts := &LoadOptions{
 		ReleaseName:  "gtctl-ut",
@@ -73,7 +74,3 @@ func TestLoadAndRenderChart(t *testing.T) {
 		t.Errorf("expected %s, got %s", string(wantedManifests), string(manifests))
 	}
 }
-
-func cleanMetadataDir() {
-	os.RemoveAll(testMetadataDir)
-}

pkg/kube/client.go

@@ -109,7 +109,7 @@ func NewClient(kubeconfig string) (*Client, error) {
 
 	kubeVersion, err := kubeClient.ServerVersion()
 	if err != nil {
-		return nil, fmt.Errorf("failed to get kubernetes server version: %v\n", err)
+		return nil, fmt.Errorf("failed to get kubernetes server version: %v", err)
 	}
 	helm.KubeVersion = kubeVersion.String()
 

pkg/metadata/manager_test.go

@@ -26,14 +26,15 @@ import (
 
 	"github.com/GreptimeTeam/gtctl/pkg/artifacts"
 	"github.com/GreptimeTeam/gtctl/pkg/config"
+	"github.com/GreptimeTeam/gtctl/pkg/utils/file"
 )
 
 func TestMetadataManager(t *testing.T) {
 	tempDir, err := os.MkdirTemp("/tmp", "gtctl-ut-")
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer os.RemoveAll(tempDir)
+	defer file.RemoveAll(tempDir)
 
 	m, err := New(tempDir)
 	if err != nil {

pkg/utils/file/file.go

@@ -73,13 +73,13 @@ func CopyFile(src, dst string) error {
 	if err != nil {
 		return err
 	}
-	defer r.Close()
+	defer MustClose(r)
 
 	w, err := os.Create(dst)
 	if err != nil {
 		return err
 	}
-	defer w.Close()
+	defer MustClose(w)
 
 	_, err = io.Copy(w, r)
 	if err != nil {
@@ -115,7 +115,7 @@ func unzip(file, dst string) error {
 	if err != nil {
 		return err
 	}
-	defer archive.Close()
+	defer MustClose(archive)
 
 	for _, f := range archive.File {
 		filePath := filepath.Join(dst, f.Name)
@@ -210,3 +210,15 @@ func untar(file, dst string) error {
 
 	return nil
 }
+
+func MustClose(c io.Closer) {
+	if err := c.Close(); err != nil {
+		_ = fmt.Errorf("failed to close: %v", err)
+	}
+}
+
+func RemoveAll(path string) {
+	if err := os.RemoveAll(path); err != nil {
+		_ = fmt.Errorf("failed to remove path %s: %v", path, err)
+	}
+}

pkg/utils/file/file_test.go

@@ -39,9 +39,7 @@ func TestUncompress(t *testing.T) {
 	}
 
 	// Clean up output dir.
-	defer func() {
-		os.RemoveAll(outputDir)
-	}()
+	defer RemoveAll(outputDir)
 
 	for _, test := range tests {
 		if err := Uncompress(test.path, test.dst); err != nil {