Skip to content

Commit ff6c070

Browse files
authored
fix: fix to datanode datahome args (#168)
* fix: fix to datanode datahome args * refactor: delete datahome args * chore: change image version * refactor: change create table sql
1 parent 0daeecd commit ff6c070

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

pkg/deployer/baremetal/component/datanode.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func (d *datanode) Start(ctx context.Context, binary string) error {
6060
for i := 0; i < d.config.Replicas; i++ {
6161
dirName := fmt.Sprintf("%s.%d", d.Name(), i)
6262

63-
dataHomeDir := path.Join(d.workingDirs.DataDir, config.DataHomeDir)
63+
dataHomeDir := path.Join(d.workingDirs.DataDir, dirName, config.DataHomeDir)
6464
if err := fileutils.EnsureDir(dataHomeDir); err != nil {
6565
return err
6666
}
@@ -121,7 +121,7 @@ func (d *datanode) BuildArgs(ctx context.Context, params ...interface{}) []strin
121121
logLevel = config.DefaultLogLevel
122122
}
123123

124-
nodeID_, walDir, dataHomeDir := params[0], params[1], params[2]
124+
nodeID_, _, dataHomeDir := params[0], params[1], params[2]
125125
nodeID := nodeID_.(int)
126126

127127
args := []string{
@@ -132,7 +132,6 @@ func (d *datanode) BuildArgs(ctx context.Context, params ...interface{}) []strin
132132
fmt.Sprintf("--rpc-addr=%s", generateDatanodeAddr(d.config.RPCAddr, nodeID)),
133133
fmt.Sprintf("--http-addr=%s", generateDatanodeAddr(d.config.HTTPAddr, nodeID)),
134134
fmt.Sprintf("--data-home=%s", dataHomeDir),
135-
fmt.Sprintf("--wal-dir=%s", walDir),
136135
}
137136

138137
if len(d.config.Config) > 0 {

pkg/helm/testdata/db-manifests.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ metadata:
88
spec:
99
base:
1010
main:
11-
image: 'registry.cn-hangzhou.aliyuncs.com/greptime/greptimedb:0.3.2'
11+
image: 'registry.cn-hangzhou.aliyuncs.com/greptime/greptimedb:v0.4.0'
1212
resources:
1313
limits:
1414
cpu: 500m
@@ -34,6 +34,6 @@ spec:
3434
postgresServicePort: 4003
3535
openTSDBServicePort: 4242
3636
initializer:
37-
image: 'registry.cn-hangzhou.aliyuncs.com/greptime/greptimedb-initializer:0.1.0-alpha.14'
37+
image: 'registry.cn-hangzhou.aliyuncs.com/greptime/greptimedb-initializer:0.1.0-alpha.16'
3838
storage:
3939
{}

tests/e2e/greptimedbcluster_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@ const (
3434
ts TIMESTAMP DEFAULT current_timestamp(),
3535
n INT,
3636
row_id INT,
37-
TIME INDEX (ts)
37+
TIME INDEX (ts),
38+
PRIMARY KEY(n)
3839
)
3940
PARTITION BY RANGE COLUMNS (n) (
4041
PARTITION r0 VALUES LESS THAN (5),
4142
PARTITION r1 VALUES LESS THAN (9),
4243
PARTITION r2 VALUES LESS THAN (MAXVALUE),
43-
)
44-
engine=mito`
44+
)`
4545

4646
insertDataSQLStr = "INSERT INTO dist_table(n, row_id) VALUES (%d, %d)"
4747

0 commit comments

Comments
 (0)