fixing issue #713

Signed-off-by: DONNOT Benjamin <[email protected]>

Author: BDonnot

grid2op/Environment/environment.py

@@ -5,6 +5,7 @@
 # you can obtain one at http://mozilla.org/MPL/2.0/.
 # SPDX-License-Identifier: MPL-2.0
 # This file is part of Grid2Op, Grid2Op a testbed platform to model sequential decision making in power systems.
+import datetime
 import os
 import copy
 import warnings
@@ -413,13 +414,22 @@ def _init_backend(
             names_chronics_to_backend = self.backend.names_target_to_source
 
         self.chronics_handler = chronics_handler
+        if self._init_obs is not None:
+            # env init from an observation, I must update date and time
+            # from the chronics handler
+            delta_t_step = datetime.timedelta(minutes=float(self._init_obs.delta_time))
+            init_dt = self._init_obs.get_time_stamp() - delta_t_step
+            self.chronics_handler._real_data.start_datetime = init_dt
+            self.chronics_handler._real_data.current_datetime = init_dt
+            self.chronics_handler._real_data.time_interval = delta_t_step
         self.chronics_handler.initialize(
             self.name_load,
             self.name_gen,
             self.name_line,
             self.name_sub,
             names_chronics_to_backend=names_chronics_to_backend,
         )
+            
         # new in grdi2op 1.10.2: used
         self.chronics_handler.action_space = self._helper_action_env
         self._names_chronics_to_backend = names_chronics_to_backend
@@ -1381,7 +1391,6 @@ def reset(self,
         else:
             # reset previous max iter to value set with `env.set_max_iter(...)` (or -1 by default)
             self.chronics_handler._set_max_iter(self._max_iter)
-            
         self.chronics_handler.next_chronics()
         self.chronics_handler.initialize(
             self.backend.name_load,

grid2op/Observation/baseObservation.py

@@ -5029,9 +5029,17 @@ def _make_env_from_arays(self,
                              load_q=load_q,
                              prod_p=prod_p,
                              prod_v=prod_v,
-                             maintenance=maintenance)
+                             maintenance=maintenance,
+                             )
         ch.max_iter = ch.real_data.max_iter
 
+
+        delta_t_step = datetime.timedelta(minutes=float(self.delta_time))
+        init_dt = self.get_time_stamp() - delta_t_step
+        ch._real_data.start_datetime = init_dt
+        ch._real_data.current_datetime = init_dt
+        ch._real_data.time_interval = delta_t_step
+        
         backend = self._obs_env.backend.copy_public()
         backend._is_loaded = True
         nb_highres_called = self._obs_env.highres_sim_counter.nb_highres_called

grid2op/tests/test_issue_713.py

@@ -0,0 +1,63 @@
+# Copyright (c) 2025, RTE (https://www.rte-france.com)
+# See AUTHORS.txt and https://github.com/Grid2Op/grid2op/pull/319
+# This Source Code Form is subject to the terms of the Mozilla Public License, version 2.0.
+# If a copy of the Mozilla Public License, version 2.0 was not distributed with this file,
+# you can obtain one at http://mozilla.org/MPL/2.0/.
+# SPDX-License-Identifier: MPL-2.0
+# This file is part of Grid2Op, Grid2Op a testbed platform to model sequential decision making in power systems.
+
+import warnings
+import grid2op
+from grid2op.Action import BaseAction
+import unittest
+
+
+class TestIssue713(unittest.TestCase):
+    def setUp(self) -> None:
+        with warnings.catch_warnings():
+            warnings.filterwarnings("ignore")
+            self.env = grid2op.make("educ_case14_storage",
+                                    test=True,
+                                    action_class=BaseAction,
+                                    _add_to_name=type(self).__name__)
+        self.init_obs = self.env.reset(seed=0, options={"time serie id":0})
+        return super().setUp()
+    
+    def test_proper_date_time_after_reset(self):
+        for_env = self.init_obs.get_forecast_env()
+        for_obs = for_env.reset()
+        self.assertEqual(for_obs.hour_of_day, 0)
+        self.assertEqual(for_obs.minute_of_hour, 0)
+        self.assertEqual(for_obs.year, 2019)
+        self.assertEqual(for_obs.day, 12)
+        self.assertEqual(for_obs.day_of_week, 5)
+        
+    def test_proper_date_time_after_step(self):
+        for_env = self.init_obs.get_forecast_env()
+        for_obs = for_env.reset()
+        for_obs, *_ = for_env.step(self.env.action_space())
+        self.assertEqual(for_obs.hour_of_day, 0)
+        self.assertEqual(for_obs.minute_of_hour, 5)
+        self.assertEqual(for_obs.year, 2019)
+        self.assertEqual(for_obs.day, 12)
+        self.assertEqual(for_obs.day_of_week, 5)
+        
+    def test_proper_date_time_wuithout_reset(self):
+        for_env = self.init_obs.get_forecast_env()
+        for_obs = for_env.get_obs()
+        self.assertEqual(for_obs.hour_of_day, 0)
+        self.assertEqual(for_obs.minute_of_hour, 0)
+        self.assertEqual(for_obs.year, 2019)
+        self.assertEqual(for_obs.day, 12)
+        self.assertEqual(for_obs.day_of_week, 5)
+        
+        for_obs, *_ = for_env.step(self.env.action_space())
+        self.assertEqual(for_obs.hour_of_day, 0)
+        self.assertEqual(for_obs.minute_of_hour, 5)
+        self.assertEqual(for_obs.year, 2019)
+        self.assertEqual(for_obs.day, 12)
+        self.assertEqual(for_obs.day_of_week, 5)
+        
+        
+if __name__ == "__main__":
+    unittest.main()

grid2op/typing_variables.py

@@ -41,7 +41,9 @@
                                "hazards",
                                "maintenance",
                                "shunt",
-                               "detach_load"],
+                               "detach_load",
+                               "detach_gen",
+                               "detach_storage"],
                        Any]
 # TODO improve that (especially the Any part)