Remove old gfx/screen.h video API

Only use the new adapter->monitor->buffer API

Author: GrieferAtWork

kos/include/libvideo/gfx/anim.h

@@ -83,25 +83,24 @@ struct video_anim_ops {
 	 * >> struct timeval frame_start, frame_end;
 	 * >> struct timeval tv_delay, tv_spent, showfor;
 	 * >> struct timespec ts_delay;
-	 * >> REF struct video_screen *screen;
+	 * >> REF struct video_buffer *screen;
 	 * >> REF struct video_anim *anim;
 	 * >> struct video_anim_frame *data;
 	 * >>
-	 * >> screen = screen_buffer_create(NULL);
+	 * >> screen = ...;
 	 * >> anim = video_anim_open("/var/anim.gif");
 	 * >> data = (struct video_anim_frame *)malloca(video_anim_sizeof_frame(anim));
 	 * >>
 	 * >> video_anim_firstframe(anim, data);
-	 * >> video_buffer_getgfx((struct video_buffer *)screen, &screen_gfx, GFX_BLENDMODE_OVERRIDE);
+	 * >> video_buffer_getgfx(screen, &screen_gfx, GFX_BLENDMODE_OVERRIDE);
 	 * >> gettimeofday(&frame_start, NULL);
 	 * >> for (;;) {
 	 * >>
 	 * >>     // Display current frame on-screen (here: stretched)
 	 * >>     video_buffer_getgfx(data->vaf_frame, &frame_gfx, GFX_BLENDMODE_OVERRIDE);
 	 * >>     video_gfx_stretch(&screen_gfx, 0, 0, VIDEO_DIM_MAX, VIDEO_DIM_MAX,
 	 * >>                       &frame_gfx, 0, 0, VIDEO_DIM_MAX, VIDEO_DIM_MAX);
-	 * >>     struct video_crect update_rect = VIDEO_CRECT_INIT_FULL;
-	 * >>     screen_buffer_updaterect(screen, &update_rect);
+	 * >>     video_display_updaterect(...);
 	 * >>
 	 * >>     // Load next frame as part of render delay
 	 * >>     showfor = data->vaf_showfor;

kos/include/libvideo/gfx/display.h

@@ -63,6 +63,8 @@ struct video_display_ops {
 	(LIBVIDEO_GFX_CC *vdo_getbuffer)(struct video_display *__restrict __self);
 
 	/* TODO: Operator for changing/updating the palette used by `vdo_getbuffer' */
+	/* TODO: Operator to test if display is in V-blank right now (non-monitor-buffers always return "true" here)
+	 *       Using  this operator, code can then wait for  V-blank to happen in order to prevent screen-tearing. */
 
 	/* Indicate  that the contents of a given physical rect have changed.
 	 * Chipset drivers might need this  to propagate changes to  actually

kos/include/libvideo/gfx/screen.h

@@ -1213,6 +1213,7 @@ incdir("");
 #include <libvideo/gfx/api.h>
 #include <libvideo/gfx/blend.h>
 #include <libvideo/gfx/blendcolors.h>
+#include <libvideo/gfx/buffer/rambuffer.h>
 #include <libvideo/gfx/buffer.h>
 #include <libvideo/gfx/codec/codec-extra.h>
 #include <libvideo/gfx/codec/codec.h>
@@ -1223,7 +1224,6 @@ incdir("");
 #include <libvideo/gfx/fonts/tlft.h>
 #include <libvideo/gfx/gfx-flags.h>
 #include <libvideo/gfx/gfx.h>
-#include <libvideo/gfx/screen.h>
 #include <libvideo/gfx/surface-defs.h>
 #include <libvideo/gfx/surface.h>
 #include <libvideo/rect.h>

kos/src/_verify/include-everything.h

@@ -48,7 +48,6 @@
 #include <libvideo/gfx/buffer.h>
 #include <libvideo/gfx/font.h>
 #include <libvideo/gfx/gfx.h>
-#include <libvideo/gfx/screen.h>
 #include <libvideo/gfx/surface.h>
 #include <libvideo/rect.h>
 

kos/src/apps/gfx/main.c

@@ -541,7 +541,7 @@ svga_setmode(struct video_monitor *__restrict self,
 	if (old_modeinfo)
 		video_monitor_mode_fini(&me->sva_mode);
 	memcpy(&me->sva_mode, mode, sizeof(struct video_monitor_mode));
-	axref_clear(&me->sva_buffer);
+	axref_clear(&me->sva_buffer); /* Discard old display buffer to force creation of a new one */
 	svga_adapter_cs_release(me);
 	free(old_modeinfo);
 	return 0;

kos/src/libvideo/driver/adapter/svga.c

@@ -75,7 +75,7 @@ struct svga_adapter: video_adapter {
 	void                             *sva_libsvgadrv;    /* [1..1][const] Handle for libsvgadrv */
 	struct svga_chipset_driver const *sva_drv;           /* [1..1][const] SVGA driver */
 #define svga_adapter_modeset(self) ((self)->sva_modeinfo != NULL)
-	struct svga_modeinfo             *sva_modeinfo;      /* [0..1][lock(sva_cslock)] Descriptor for currently active video mode */
+	struct svga_modeinfo             *sva_modeinfo;      /* [0..1][lock(sva_cslock)] Descriptor for currently active video mode ("NULL" means that no mode has been set, yet) */
 	struct video_monitor_mode         sva_mode;          /* [valid_if(sva_modeinfo != NULL)][lock(sva_cslock)] Currently active video mode */
 	struct svga_buffer_axref          sva_buffer;        /* [0..1][lock(READ(ATOMIC), WRITE(ATOMIC && sva_cslock))] Display buffer (or "NULL" if not allocated or display mode was just set) */
 	struct shared_lock                sva_cslock;        /* Lock for interfacing with `sva_cs' */