Fix bad free in default_video_palette_destroy()

Author: GrieferAtWork

kos/include/libvideo/gfx/anim.h

@@ -58,7 +58,7 @@ struct video_anim_frame {
 	/* Animation-specific frame data goes here... */
 };
 
-#define video_anim_frame_fini(self) ((self)->vaf_fini)(self)
+#define video_anim_frame_fini(self) (*(self)->vaf_fini)(self)
 
 
 struct video_anim_ops {

kos/src/apps/showpic/main.c

@@ -653,7 +653,7 @@ int main(int argc, char *argv[]) {
 	 * - dst format caching: ~97% spent sleeping  (=> x30 pixel output possible) */
 #if 0
 	anim = video_anim_cached(anim, NULL, NULL);
-#elif 1
+#elif 0
 	{
 		struct video_buffer_format format;
 		video_buffer_getformat(bscreen, &format);

kos/src/libvideo/gfx/anim.c

@@ -334,9 +334,9 @@ cached_anim_nextframe(struct video_anim const *__restrict self,
 		me->ca_bbuf = NULL;
 		me->ca_base = NULL;
 		shared_lock_release(&me->ca_lock);
-		video_anim_decref(old_base);
 		video_anim_frame_fini(old_bbuf);
 		free(old_bbuf);
+		video_anim_decref(old_base);
 		next_id = 0;
 		goto return_next_cached_frame;
 	}
@@ -368,7 +368,8 @@ cached_anim_nextframe(struct video_anim const *__restrict self,
 	assert(cframe == &me->ca_framev[next_id]);
 unlock_and_return_frame:
 	assert(next_id < me->ca_framec);
-	assertf(atomic_read(&frame->vaf_frame->vb_refcnt) >= 2, "1 by the cache, and one by the caller");
+	assertf(atomic_read(&frame->vaf_frame->vb_refcnt) >= 2,
+	        "1 by the cache, and one by the caller");
 	atomic_dec(&frame->vaf_frame->vb_refcnt);
 	video_buffer_incref(cframe->cf_frame);
 	cframe = &me->ca_framev[next_id];

kos/src/libvideo/gfx/codec/palette.c

@@ -425,7 +425,8 @@ libvideo_palette_optimize(/*inherited(always)*/ REF struct video_palette *__rest
 
 PRIVATE NONNULL((1)) void
 NOTHROW(CC default_video_palette_destroy)(struct video_palette *__restrict self) {
-	free(self);
+	struct video_palette_object *me = video_palette_asobject(self);
+	free(me);
 }
 
 
@@ -453,8 +454,9 @@ libvideo_generic_palette_create(struct video_domain const *__restrict domain,
 	                                                   (count * sizeof(struct video_palette_cache)));
 	if unlikely(!result)
 		goto err;
-	result->vp_color2pixel = video_palette_get_special_color2pixel(count)
-	                         ?: &linear_video_palette_color2pixel;
+	result->vp_color2pixel = video_palette_get_special_color2pixel(count);
+	if (result->vp_color2pixel == NULL)
+		result->vp_color2pixel = &linear_video_palette_color2pixel;
 	result->vp_ops    = _generic_palette_ops();
 	result->vp_refcnt = 1;
 	result->vp_cnt    = count;