Fix write-past-end in DeeDecWriter_PackEhdr()

GrieferAtWork · GrieferAtWork · commit d8beaade0728 · 2026-01-10T15:03:23.000+01:00
diff --git a/.vs/deemon-v141.sln b/.vs/deemon-v141.sln
@@ -97,6 +97,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "lib", "lib", "{2360741E-FB4
 		..\lib\LANGUAGE.txt = ..\lib\LANGUAGE.txt
 		..\lib\annotations.dee = ..\lib\annotations.dee
 		..\lib\codecs.dee = ..\lib\codecs.dee
+		..\lib\d200.dee = ..\lib\d200.dee
 		..\lib\doc.dee = ..\lib\doc.dee
 		..\lib\doctext.dee = ..\lib\doctext.dee
 		..\lib\errors.dee = ..\lib\errors.dee
diff --git a/.vs/deemon-v142.sln b/.vs/deemon-v142.sln
@@ -97,6 +97,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "lib", "lib", "{2360741E-FB4
 		..\lib\LANGUAGE.txt = ..\lib\LANGUAGE.txt
 		..\lib\annotations.dee = ..\lib\annotations.dee
 		..\lib\codecs.dee = ..\lib\codecs.dee
+		..\lib\d200.dee = ..\lib\d200.dee
 		..\lib\doc.dee = ..\lib\doc.dee
 		..\lib\doctext.dee = ..\lib\doctext.dee
 		..\lib\errors.dee = ..\lib\errors.dee
diff --git a/.vs/deemon-v143.sln b/.vs/deemon-v143.sln
@@ -97,6 +97,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "lib", "lib", "{2360741E-FB4
 		..\lib\LANGUAGE.txt = ..\lib\LANGUAGE.txt
 		..\lib\annotations.dee = ..\lib\annotations.dee
 		..\lib\codecs.dee = ..\lib\codecs.dee
+		..\lib\d200.dee = ..\lib\d200.dee
 		..\lib\doc.dee = ..\lib\doc.dee
 		..\lib\doctext.dee = ..\lib\doctext.dee
 		..\lib\errors.dee = ..\lib\errors.dee
diff --git a/src/deemon/execute/dec.c b/src/deemon/execute/dec.c
@@ -1365,12 +1365,9 @@ DeeDecWriter_PackEhdr(DeeDecWriter *__restrict self,
 				addrof_outname += offsetof(Dec_Dstr, ds_string);
 				addrof_outname += (out_name->ds_length + 1) * sizeof(char);
 			}
+
 			/* Emit terminating "d_modspec.d_mod==NULL"-entry */
 			out_dep->d_modspec.d_mod = NULL;
-
-			addrof_outname = CEIL_ALIGN(addrof_outname, Dee_ALIGNOF_DEC_DSTR);
-			out_name = (Dec_Dstr *)((byte_t *)ehdr + addrof_outname);
-			out_name->ds_length = 0; /* "terminated by a ds_length==0-entry" */
 		}
 
 		/* Relocations against self. */

Original file line number	Diff line number	Diff line change
`@@ -1365,12 +1365,9 @@ DeeDecWriter_PackEhdr(DeeDecWriter *__restrict self,`
`1365`	`1365`	`addrof_outname += offsetof(Dec_Dstr, ds_string);`
`1366`	`1366`	`addrof_outname += (out_name->ds_length + 1) * sizeof(char);`
`1367`	`1367`	`}`
	`1368`	`+`
`1368`	`1369`	`/* Emit terminating "d_modspec.d_mod==NULL"-entry */`
`1369`	`1370`	`out_dep->d_modspec.d_mod = NULL;`
`1370`		`-`
`1371`		`- addrof_outname = CEIL_ALIGN(addrof_outname, Dee_ALIGNOF_DEC_DSTR);`
`1372`		`- out_name = (Dec_Dstr )((byte_t )ehdr + addrof_outname);`
`1373`		`- out_name->ds_length = 0; /* "terminated by a ds_length==0-entry" */`
`1374`	`1371`	`}`
`1375`	`1372`
`1376`	`1373`	`/* Relocations against self. */`