Move PropertyHooks document classes to the PropertyHooksTest to prevent invalid document from polluting the other tests

Author: GromNaN

phpcs.xml.dist

@@ -20,6 +20,9 @@
     <exclude-pattern>tests/Hydrators*</exclude-pattern>
     <exclude-pattern>tests/PersistentCollections*</exclude-pattern>
 
+    <!-- Property Hooks aren't supported yet -->
+    <exclude-pattern>tests/Tests/Functional/PropertyHooksTest.php</exclude-pattern>
+
     <rule ref="Doctrine">
         <!-- Traversable type hints often end up as mixed[], so we skip them for now -->
         <exclude name="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingTraversableTypeHintSpecification" />

tests/Documents/PropertyHooks/MappingVirtualProperty.php

@@ -4,10 +4,11 @@
 
 namespace Doctrine\ODM\MongoDB\Tests\Functional;
 
+use Doctrine\ODM\MongoDB\Mapping\Annotations\Document;
+use Doctrine\ODM\MongoDB\Mapping\Annotations\Field;
+use Doctrine\ODM\MongoDB\Mapping\Annotations\Id;
 use Doctrine\ODM\MongoDB\Mapping\MappingException;
 use Doctrine\ODM\MongoDB\Tests\BaseTestCase;
-use Documents\PropertyHooks\MappingVirtualProperty;
-use Documents\PropertyHooks\User;
 
 class PropertyHooksTest extends BaseTestCase
 {
@@ -91,8 +92,74 @@ public function testTriggerLazyLoadingWhenAccessingPropertyHooks(): void
     public function testMappingVirtualPropertyIsNotSupported(): void
     {
         $this->expectException(MappingException::class);
-        $this->expectExceptionMessage('Mapping virtual property "fullName" on document "Documents84\PropertyHooks\MappingVirtualProperty" is not allowed.');
+        $this->expectExceptionMessage('Mapping virtual property "fullName" on document "' . __NAMESPACE__ . '\MappingVirtualProperty" is not allowed.');
 
         $this->dm->getClassMetadata(MappingVirtualProperty::class);
     }
 }
+
+#[Document(collection: 'property_hooks_user')]
+class User
+{
+    #[Id]
+    public ?string $id;
+
+    #[Field]
+    public string $first {
+        set {
+            if (strlen($value) === 0) {
+                throw new ValueError("Name must be non-empty");
+            }
+            $this->first = $value;
+        }
+    }
+
+    #[Field]
+    public string $last {
+        set {
+            if (strlen($value) === 0) {
+                throw new ValueError("Name must be non-empty");
+            }
+            $this->last = $value;
+        }
+    }
+
+    public string $fullName {
+        get => $this->first . " " . $this->last;
+        set {
+            [$this->first, $this->last] = explode(' ', $value, 2);
+        }
+    }
+
+    #[Field]
+    public string $language = 'de' {
+        // Override the "read" action with arbitrary logic.
+        get => strtoupper($this->language);
+
+        // Override the "write" action with arbitrary logic.
+        set {
+            $this->language = strtolower($value);
+        }
+    }
+}
+
+#[Document(collection: 'property_hooks_user')]
+class MappingVirtualProperty
+{
+    #[Id]
+    public ?string $id;
+
+    #[Field]
+    public string $first;
+
+    #[Field]
+    public string $last;
+
+    #[Field]
+    public string $fullName {
+        get => $this->first . " " . $this->last;
+        set {
+            [$this->first, $this->last] = explode(' ', $value, 2);
+        }
+    }
+}