Update tests to ensure the document is inserted, not upserted

Author: GromNaN

tests/Doctrine/ODM/MongoDB/Tests/Functional/Ticket/GH2730Test.php

@@ -13,10 +13,11 @@ class GH2730Test extends BaseTestCase
 {
     public function testUniqueObjectIdentifier(): void
     {
-        $document = new GH2730Document();
+        $document = new GH2730();
         $oid      = spl_object_hash($document);
         $this->dm->persist($document);
         $this->dm->flush();
+        $id = $document->id;
 
         // Remove the document
         $this->dm->remove($document);
@@ -26,57 +27,72 @@ public function testUniqueObjectIdentifier(): void
         unset($document);
 
         // Create a new document
-        $document = new GH2730Document();
+        $document = new GH2730();
         $this->dm->persist($document);
+
+        // If this assertion fails in a future version of PHP, this test case can be skipped.
+        self::assertSame($oid, spl_object_hash($document), 'PHP created a new object with the same object hash');
+        self::assertNotEquals($document->id, $id, 'New ID generated');
+        self::assertCount(1, $this->dm->getUnitOfWork()->getScheduledDocumentInsertions());
+        self::assertCount(0, $this->dm->getUnitOfWork()->getScheduledDocumentUpserts());
+
         $this->dm->flush();
 
         self::assertSame(1, $this->countDocuments());
-
-        // If this assertion fails in a future version of PHP, this test case can be skipped.
-        self::assertSame($oid, spl_object_hash($document), 'PHP created a new object wit the same object hash');
     }
 
     public function testRemoveFlushPersist(): void
     {
-        $document = new GH2730Document();
+        $document = new GH2730();
         $this->dm->persist($document);
         $this->dm->flush();
+        $id = $document->id;
 
         // Remove the document
         $this->dm->remove($document);
         $this->dm->flush();
 
         // Re-persist the same document
         $this->dm->persist($document);
+        self::assertEquals($document->id, $id, 'ID not regenerated');
+        self::assertCount(0, $this->dm->getUnitOfWork()->getScheduledDocumentInsertions());
+        self::assertCount(1, $this->dm->getUnitOfWork()->getScheduledDocumentUpserts());
+
         $this->dm->flush();
 
         self::assertSame(1, $this->countDocuments());
     }
 
     public function testRemovePersist(): void
     {
-        $document = new GH2730Document();
+        $document = new GH2730();
         $this->dm->persist($document);
         $this->dm->flush();
+        $id = $document->id;
 
         // Remove the document
         $this->dm->remove($document);
 
         // Re-persist the same document
         $this->dm->persist($document);
+
+        self::assertEquals($document->id, $id, 'ID not regenerated');
+        self::assertCount(0, $this->dm->getUnitOfWork()->getScheduledDocumentInsertions());
+        self::assertCount(1, $this->dm->getUnitOfWork()->getScheduledDocumentUpserts());
+
         $this->dm->flush();
 
         self::assertSame(1, $this->countDocuments());
     }
 
     private function countDocuments(): int
     {
-        return $this->dm->getDocumentCollection(GH2730Document::class)->countDocuments();
+        return $this->dm->getDocumentCollection(GH2730::class)->countDocuments();
     }
 }
 
 #[ODM\Document]
-class GH2730Document
+class GH2730
 {
     #[ODM\Id]
     public ?string $id = null;