Tweaks

javiereguiluz · javiereguiluz · commit ea28f5703230 · 2025-07-25T17:00:42.000+02:00
diff --git a/assets/styles/_rtl.scss b/assets/styles/_rtl.scss
@@ -342,7 +342,7 @@
     direction: rtl;
     text-align: right;
   }
-  
+
   .rtl .d-print-none {
     display: none !important;
   }
@@ -399,9 +399,9 @@
     margin-right: 0;
     margin-left: 0;
   }
-  
+
   .rtl .dropdown-menu {
     right: auto;
     left: 0;
   }
-} 
+}
diff --git a/assets/styles/app.scss b/assets/styles/app.scss
@@ -609,5 +609,3 @@ body#blog_search .post-metadata {
   padding-bottom: 0;
   padding-top: 0;
 }
-
-
diff --git a/src/Twig/AppExtension.php b/src/Twig/AppExtension.php
@@ -43,8 +43,6 @@ public function getFunctions(): array
         return [
             new TwigFunction('locales', [$this, 'getLocales']),
             new TwigFunction('is_rtl', [$this, 'isRtl']),
-            new TwigFunction('rtl_class', [$this, 'getRtlClass']),
-            new TwigFunction('rtl_dir', [$this, 'getRtlDir']),
         ];
     }
 
@@ -79,20 +77,4 @@ public function isRtl(?string $locale = null): bool
 
         return \in_array($locale, ['ar', 'fa', 'he', 'ur', 'ps', 'sd'], true);
     }
-
-    /**
-     * Get RTL class if the locale is RTL.
-     */
-    public function getRtlClass(?string $locale = null): string
-    {
-        return $this->isRtl($locale) ? 'rtl' : '';
-    }
-
-    /**
-     * Get direction attribute value for RTL support.
-     */
-    public function getRtlDir(?string $locale = null): string
-    {
-        return $this->isRtl($locale) ? 'rtl' : 'ltr';
-    }
 }
diff --git a/templates/base.html.twig b/templates/base.html.twig
@@ -4,7 +4,7 @@
    See https://symfony.com/doc/current/templates.html#template-inheritance-and-layouts
 #}
 <!DOCTYPE html>
-<html lang="{{ app.locale }}" dir="{{ rtl_dir(app.locale) }}">
+<html lang="{{ app.locale }}" dir="{{ is_rtl() ? 'rtl' : 'ltr' }}">
     <head>
         <meta charset="UTF-8" />
         <meta name="viewport" content="width=device-width, initial-scale=1"/>
@@ -23,7 +23,7 @@
         <link rel="shortcut icon" type="image/svg+xml" href="{{ asset('favicon.svg') }}">
     </head>
 
-    <body id="{% block body_id %}{% endblock %}" class="{{ rtl_class(app.locale) }}">
+    <body id="{% block body_id %}{% endblock %}" class="{{ is_rtl(app.locale) ? 'rtl' }}">
 
         {% block header %}
             {% set _route = app.current_route %}
diff --git a/templates/default/_language_selector.html.twig b/templates/default/_language_selector.html.twig
@@ -25,7 +25,7 @@
                     <ul class="locales">
                         {% for locale in locales() %}
                             {% set is_active = app.locale == locale.code %}
-                            <li class="{{ is_active ? 'active' }} {{ rtl_class(locale.code) }}" translate="no">
+                            <li class="{{ is_active ? 'active' }} {{ is_rtl(locale.code) ? 'rtl' }}" translate="no">
                                 <a class="stretched-link" lang="{{ locale.code }}" hreflang="{{ locale.code }}" href="{{ path(app.current_route ?? 'blog_index', app.current_route_parameters|merge({_locale: locale.code})) }}">
                                     {{ locale.name|capitalize }}
                                     <small>{{ locale.code }}</small>

Original file line number	Diff line number	Diff line change
`@@ -342,7 +342,7 @@`
`342`	`342`	`direction: rtl;`
`343`	`343`	`text-align: right;`
`344`	`344`	`}`
`345`		`-`
	`345`	`+`
`346`	`346`	`.rtl .d-print-none {`
`347`	`347`	`display: none !important;`
`348`	`348`	`}`
`@@ -399,9 +399,9 @@`
`399`	`399`	`margin-right: 0;`
`400`	`400`	`margin-left: 0;`
`401`	`401`	`}`
`402`		`-`
	`402`	`+`
`403`	`403`	`.rtl .dropdown-menu {`
`404`	`404`	`right: auto;`
`405`	`405`	`left: 0;`
`406`	`406`	`}`
`407`		`-}`
	`407`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -609,5 +609,3 @@ body#blog_search .post-metadata {`
`609`	`609`	`padding-bottom: 0;`
`610`	`610`	`padding-top: 0;`
`611`	`611`	`}`
`612`		`-`
`613`		`-`