Skip to content

Commit b482743

Browse files
committed
Fix error when id in request params is empty
``` Cast from Avram::Type::FailedCast to Avram::Type::SuccessfulCast(T) failed, at /path/to/lib/avram/src/avram/type.cr:25:5 (TypeCastError) from lib/avram/src/avram/type.cr:25:5 in 'parse!' from lib/avram/src/avram/type.cr:33:20 in 'to_db!' from lib/avram/src/avram/criteria.cr:89:48 in 'perform_eq' from lib/avram/src/avram/criteria.cr:25:5 in 'eq' # ... ```
1 parent d7cb062 commit b482743

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/bill/operations/mixins/update_credit_note_line_items.cr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ module Bill::UpdateCreditNoteLineItems
118118
end
119119

120120
private def credit_note_item_from_hash(hash, credit_note)
121-
hash["id"]?.try do |id|
121+
hash["id"]?.presence.try do |id|
122122
CreditNoteItemQuery.new
123123
.id(id)
124124
.credit_note_id(credit_note.id)

src/bill/operations/mixins/update_finalized_credit_note_line_items.cr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ module Bill::UpdateFinalizedCreditNoteLineItems
3939
end
4040

4141
private def credit_note_item_from_hash(hash, credit_note)
42-
hash["id"]?.try do |id|
42+
hash["id"]?.presence.try do |id|
4343
CreditNoteItemQuery.new
4444
.id(id)
4545
.credit_note_id(credit_note.id)

src/bill/operations/mixins/update_finalized_invoice_line_items.cr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ module Bill::UpdateFinalizedInvoiceLineItems
3636
end
3737

3838
private def invoice_item_from_hash(hash, invoice)
39-
hash["id"]?.try do |id|
39+
hash["id"]?.presence.try do |id|
4040
InvoiceItemQuery.new
4141
.id(id)
4242
.invoice_id(invoice.id)

src/bill/operations/mixins/update_invoice_line_items.cr

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ module Bill::UpdateInvoiceLineItems
112112
end
113113

114114
private def invoice_item_from_hash(hash, invoice)
115-
hash["id"]?.try do |id|
115+
hash["id"]?.presence.try do |id|
116116
InvoiceItemQuery.new
117117
.id(id)
118118
.invoice_id(invoice.id)

0 commit comments

Comments
 (0)