refactor: replace catch any with unknown narrowing and simplify axios config

Author: GuXianWN

server/api/docker/assemble-image.ts

@@ -8,6 +8,7 @@ import {
   getRepoTagName,
   getSafeFileBaseName,
 } from "~/server/utils/imageName";
+import { getErrorMessage } from "~/server/utils/http-error";
 import { logger } from "~/server/utils/logger";
 
 // 请求参数接口
@@ -216,7 +217,8 @@ export default defineEventHandler(async (event) => {
     });
 
     return sendStream(event, tarStream);
-  } catch (error: any) {
+  } catch (error: unknown) {
+    const message = getErrorMessage(error);
     // 清理临时目录
     try {
       await fs.rm(tmpDir, { recursive: true, force: true });
@@ -227,12 +229,12 @@ export default defineEventHandler(async (event) => {
     logger.error("assemble failed", {
       imageName,
       tag,
-      message: error.message,
+      message,
       elapsedMs: Date.now() - startedAt,
     });
     throw createError({
       statusCode: 500,
-      message: error.message,
+      message,
     });
   }
 });

server/api/docker/manifest-detail.ts

@@ -1,6 +1,7 @@
 // 请求参数接口
 import axiosInstance from "~/server/config/axios";
 import { normalizeImageName } from "~/server/utils/imageName";
+import { getErrorMessage, getErrorStatusCode } from "~/server/utils/http-error";
 import { logger } from "~/server/utils/logger";
 
 type QueryParams = {
@@ -62,15 +63,16 @@ export default defineEventHandler(
         layers: result.layers?.length || 0,
       });
       return result;
-    } catch (error: any) {
+    } catch (error: unknown) {
+      const message = getErrorMessage(error);
       logger.error("manifest detail failed", {
         imageName,
         digest,
-        message: error.message,
+        message,
       });
       throw createError({
-        statusCode: error.response?.status || 500,
-        message: error.message,
+        statusCode: getErrorStatusCode(error),
+        message,
       });
     }
   }

server/api/docker/manifest.ts

@@ -1,6 +1,7 @@
 // 请求参数接口
 import axiosInstance from "~/server/config/axios";
 import { normalizeImageName } from "~/server/utils/imageName";
+import { getErrorMessage, getErrorStatusCode } from "~/server/utils/http-error";
 import { logger } from "~/server/utils/logger";
 
 type QueryParams = {
@@ -102,11 +103,12 @@ export default defineEventHandler(async (event): Promise<ManifestResponse> => {
       count: normalized.manifests.length,
     });
     return normalized;
-  } catch (error: any) {
-    logger.error("manifest failed", { imageName, tag, message: error.message });
+  } catch (error) {
+    const message = getErrorMessage(error);
+    logger.error("manifest failed", { imageName, tag, message });
     throw createError({
-      statusCode: error.response?.status || 500,
-      message: error.message,
+      statusCode: getErrorStatusCode(error),
+      message,
     });
   }
 }); 

server/api/docker/pull-image.ts

@@ -1,6 +1,7 @@
 import { createWriteStream, existsSync, mkdirSync, statSync } from "fs";
 import { join } from "path";
 import axiosInstance from "~/server/config/axios";
+import { getErrorMessage } from "~/server/utils/http-error";
 import { normalizeImageName } from "~/server/utils/imageName";
 import { logger } from "~/server/utils/logger";
 
@@ -188,8 +189,9 @@ export default defineEventHandler(async (event) => {
         digest: layer.digest,
         skipped: false,
       };
-    } catch (error: any) {
-      if (String(error?.message).toLowerCase().includes("timeout")) {
+    } catch (error: unknown) {
+      const message = getErrorMessage(error);
+      if (message.toLowerCase().includes("timeout")) {
         return {
           success: false,
           digest: layer.digest,
@@ -199,7 +201,7 @@ export default defineEventHandler(async (event) => {
       return {
         success: false,
         digest: layer.digest,
-        error: error.message,
+        error: message,
       };
     } finally {
       clearTimeout(timeoutId);
@@ -287,11 +289,12 @@ export default defineEventHandler(async (event) => {
 
 
     return;
-  } catch (error: any) {
-    logger.error("pull failed", { imageName, message: error.message });
+  } catch (error: unknown) {
+    const message = getErrorMessage(error);
+    logger.error("pull failed", { imageName, message });
     throw createError({
       statusCode: 500,
-      message: error.message,
+      message,
     });
   }
 }); 

server/api/docker/search.ts

@@ -1,4 +1,5 @@
 import axiosInstance from "~/server/config/axios";
+import { getErrorMessage, getErrorStatusCode } from "~/server/utils/http-error";
 import { logger } from "~/server/utils/logger";
 
 type QueryParams = {
@@ -82,11 +83,12 @@ export default defineEventHandler(async (event): Promise<ApiSearchResponse> => {
       count: response.data.count ?? mapped.length,
       results: sorted,
     };
-  } catch (error: any) {
-    logger.error("search failed", { query: q, page, pageSize, message: error.message });
+  } catch (error: unknown) {
+    const message = getErrorMessage(error);
+    logger.error("search failed", { query: q, page, pageSize, message });
     throw createError({
-      statusCode: error.response?.status || 500,
-      message: error.message,
+      statusCode: getErrorStatusCode(error),
+      message,
     });
   }
 });

server/api/docker/tags.ts

@@ -1,4 +1,5 @@
 import axiosInstance from "~/server/config/axios";
+import { getErrorMessage, getErrorStatusCode } from "~/server/utils/http-error";
 import { normalizeImageName } from "~/server/utils/imageName";
 import { logger } from "~/server/utils/logger";
 
@@ -80,15 +81,16 @@ export default defineEventHandler(async (event): Promise<ApiTagResponse> => {
       count: response.data.count ?? mapped.length,
       results: sorted,
     };
-  } catch (error: any) {
-    const statusCode = error.response?.status || 500;
+  } catch (error: unknown) {
+    const statusCode = getErrorStatusCode(error);
+    const message = getErrorMessage(error);
     if (statusCode === 404) {
       return { count: 0, results: [] };
     }
-    logger.error("tags failed", { imageName, page, pageSize, message: error.message });
+    logger.error("tags failed", { imageName, page, pageSize, message });
     throw createError({
       statusCode,
-      message: error.message,
+      message,
     });
   }
 });

server/api/docker/token.ts

@@ -1,6 +1,7 @@
 // 请求参数接口
 import axiosInstance from "~/server/config/axios";
 import { normalizeImageName } from "~/server/utils/imageName";
+import { getErrorMessage, getErrorStatusCode } from "~/server/utils/http-error";
 import { logger } from "~/server/utils/logger";
 
 type QueryParams = {
@@ -47,11 +48,12 @@ export default defineEventHandler(async (event): Promise<ApiResponse> => {
     return {
       token: authResponse.token,
     };
-  } catch (error: any) {
-    logger.error("token failed", { imageName, scope, message: error.message });
+  } catch (error: unknown) {
+    const message = getErrorMessage(error);
+    logger.error("token failed", { imageName, scope, message });
     throw createError({
-      statusCode: error.response?.status || 500,
-      message: error.message,
+      statusCode: getErrorStatusCode(error),
+      message,
     });
   }
 }); 

server/config/axios.ts

@@ -3,16 +3,11 @@ import axios, {AxiosInstance} from "axios";
 
 const proxyUrl = process.env.HTTPS_PROXY || process.env.HTTP_PROXY
 
-// @ts-ignore
-let axiosInstance: AxiosInstance = undefined;
-if (proxyUrl) {
-    let httpsAgent = new HttpsProxyAgent(proxyUrl);
-    axiosInstance = axios.create({
-        httpsAgent: httpsAgent,
-        proxy: false
-    });
-} else {
-    axiosInstance = axios.create();
-}
+const axiosInstance: AxiosInstance = proxyUrl
+  ? axios.create({
+      httpsAgent: new HttpsProxyAgent(proxyUrl),
+      proxy: false,
+    })
+  : axios.create();
 
-export default axiosInstance
+export default axiosInstance

server/config/pullConfig.ts

@@ -0,0 +1,15 @@
+import axios from "axios";
+
+export const getErrorMessage = (error: unknown): string => {
+  if (error instanceof Error) {
+    return error.message;
+  }
+  return "request failed";
+};
+
+export const getErrorStatusCode = (error: unknown, fallback = 500): number => {
+  if (axios.isAxiosError(error)) {
+    return error.response?.status ?? fallback;
+  }
+  return fallback;
+};