Skip to content

Commit bd72889

Browse files
committed
✅ improve redirect tests
1 parent 403c064 commit bd72889

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

tests/src/RoutesAndParams.test.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,22 +258,26 @@ describe('RoutesAndParams /routes-and-params/inner-html', () => {
258258
describe('RoutesAndParams /routes-and-params/hrefs spa', () => {
259259
beforeEach(async () => {
260260
await page.goto('http://localhost:6969/routes-and-params/hrefs')
261+
await page.waitForSelector(`[data-application-hydrated]`)
261262
})
262263

263264
test('https urls do a full redirect', async () => {
264-
await Promise.all([page.click('[href="https://nullstack.app/"]'), page.waitForNavigation()])
265+
await page.click('[href="https://nullstack.app/"]')
266+
await page.waitForSelector('link[rel="canonical"][href="https://nullstack.app/"]')
265267
const url = await page.url()
266268
expect(url).toMatch('://nullstack.app')
267269
})
268270

269271
test('http urls do a full redirect', async () => {
270-
await Promise.all([page.click('[href="http://nullstack.app/"]'), page.waitForNavigation()])
272+
await page.click('[href="http://nullstack.app/"]')
273+
await page.waitForSelector('link[rel="canonical"][href="https://nullstack.app/"]')
271274
const url = await page.url()
272275
expect(url).toMatch('://nullstack.app')
273276
})
274277

275278
test('// urls do a full redirect', async () => {
276-
await Promise.all([page.click('[href="//nullstack.app/"]'), page.waitForNavigation()])
279+
await page.click('[href="//nullstack.app/"]')
280+
await page.waitForSelector('link[rel="canonical"][href="https://nullstack.app/"]')
277281
const url = await page.url()
278282
expect(url).toMatch('://nullstack.app')
279283
})

0 commit comments

Comments
 (0)