Check if the provided selector is an iframe

Author: GuillaumeGomez

src/commands/context_setters.js

@@ -246,6 +246,12 @@ function parseWithinIFrame(parser) {
 
     const code = `\
 ${getAndSetElements(selector, 'iframe', false)}
+await iframe.evaluate(el => {
+    if (el.tagName !== "IFRAME") {
+        throw "selector \`${selector.value}\` is not an \`<iframe>\` but a \`<" + \
+el.tagName.toLowerCase() + ">\`";
+    }
+});
 pages.push(iframe);`;
 
     return {

tests/api-output/parseWithinIFrame/basic-1.toml

@@ -1,6 +1,11 @@
 instructions = [
   """const iframe = await page.$(\"a\");
 if (iframe === null) { throw '\"a\" not found'; }
+await iframe.evaluate(el => {
+    if (el.tagName !== \"IFRAME\") {
+        throw \"selector `a` is not an `<iframe>` but a `<\" + el.tagName.toLowerCase() + \">`\";
+    }
+});
 pages.push(iframe);""",
 ]
 noPosIncrease = true

tests/api-output/parseWithinIFrame/basic-2.toml

@@ -1,6 +1,11 @@
 instructions = [
   """const iframe = await page.$(\"a\");
 if (iframe === null) { throw '\"a\" not found'; }
+await iframe.evaluate(el => {
+    if (el.tagName !== \"IFRAME\") {
+        throw \"selector `a` is not an `<iframe>` but a `<\" + el.tagName.toLowerCase() + \">`\";
+    }
+});
 pages.push(iframe);""",
 ]
 noPosIncrease = true

tests/ui/within-iframe-2.goml

@@ -0,0 +1,4 @@
+// This test checks what happens if the selected element is not an iframe.
+
+go-to: "file://" + |CURRENT_DIR| + "/" + |DOC_PATH| + "/basic.html"
+within-iframe: ("#the-input", block {})

tests/ui/within-iframe-2.output

@@ -0,0 +1,7 @@
+=> Starting doc-ui tests...
+
+within-iframe-2... FAILED
+[ERROR] `tests/ui/within-iframe-2.goml` line 4: selector `#the-input` is not an `<iframe>` but a `<input>`: for command `within-iframe: ("#the-input", block {})`
+
+
+<= doc-ui tests done: 0 succeeded, 1 failed