Remove --no-sandbox and disable sandbox all the time

Author: GuillaumeGomez

Dockerfile

@@ -32,7 +32,6 @@ COPY ./package*.json ./
 
 RUN npm install
 
-# never use the "--no-sandbox" outside of a container!
-ENTRYPOINT ["node", "./browser-ui-test-src/index.js", "--no-sandbox"]
+ENTRYPOINT ["node", "./browser-ui-test-src/index.js"]
 # to be able to pass arguments to index.js
 CMD []

package.json

@@ -15,7 +15,7 @@
         "browser-ui-test": "src/index.js"
     },
     "scripts": {
-        "test": "node src/index.js --test-folder tests/full-check/ --failure-folder failures --variable DOC_PATH tests/html_files --no-sandbox",
+        "test": "node src/index.js --test-folder tests/full-check/ --failure-folder failures --variable DOC_PATH tests/html_files",
         "all-test": "node tools/all.js",
         "api-test": "node tools/api.js",
         "ui-test": "node tools/ui.js",

src/index.js

@@ -782,8 +782,7 @@ async function runTests(extras = null) {
 }
 
 process.on('browser-ui-test-puppeter-failure', () => {
-    console.error('ERROR: puppeteer failed when trying to create a new page. Please try again with \
-`--no-sandbox`');
+    console.error('ERROR: puppeteer failed when trying to create a new page.');
     process.exit(1);
 });
 

src/options.js

@@ -33,7 +33,6 @@ function helper() {
     print('  --incognito                   : Enable incognito mode');
     print('  --jobs [N]                    : Number of parallel jobs, defaults to number of CPUs');
     print('  --no-headless                 : Disable headless mode');
-    print('  --no-sandbox                  : Disable the sandbox (use with caution!)');
     print('  --pause-on-error [true|false] : Pause execution script until user press ENTER');
     print('  --permission [PERMISSION]     : Add a permission to enable');
     print('  --run-id [id]                 : Id to be used for failed images extension (\'test\'');
@@ -92,7 +91,6 @@ class Options {
         this.showText = false;
         this.debug = false;
         this.screenshotComparison = false;
-        this.noSandbox = false;
         this.allowFileAccessFromFiles = false;
         this.testFiles = [];
         this.variables = Object.create(null);
@@ -125,7 +123,6 @@ class Options {
         copy.showText = this.showText;
         copy.debug = this.debug;
         copy.screenshotComparison = this.screenshotComparison;
-        copy.noSandbox = this.noSandbox;
         copy.allowFileAccessFromFiles = this.allowFileAccessFromFiles;
         copy.testFiles = JSON.parse(JSON.stringify(this.testFiles));
         copy.variables = JSON.parse(JSON.stringify(this.variables));
@@ -194,8 +191,6 @@ class Options {
                 this.debug = true;
             } else if (args[it] === '--enable-screenshot-comparison') {
                 this.screenshotComparison = true;
-            } else if (args[it] === '--no-sandbox') {
-                this.noSandbox = true;
             } else if (args[it] === '--allow-file-access-from-files') {
                 this.allowFileAccessFromFiles = true;
             } else if (args[it] === '--incognito') {
@@ -386,7 +381,6 @@ class Options {
         validateField('onPageCreatedCallback', 'function');
         validateField('failOnJsError', 'boolean');
         validateField('failOnRequestError', 'boolean');
-        validateField('noSandbox', 'boolean');
         validateField('allowFileAccessFromFiles', 'boolean');
         validateField('screenshotOnFailure', 'boolean');
         validateField('nbThreads', 'number');

src/puppeteer-wrapper.js

@@ -12,10 +12,7 @@ function buildPuppeteerOptions(options) {
     for (let i = 0; i < options.extensions.length; ++i) {
         puppeteer_options['args'].push(`--load-extension=${options.extensions[i]}`);
     }
-    if (options.noSandbox === true) {
-        // Highly unsafe! Only use it when you know what you're doing!
-        puppeteer_options['args'].push('--no-sandbox');
-    }
+    puppeteer_options['args'].push('--no-sandbox');
     if (options.allowFileAccessFromFiles === true) {
         puppeteer_options['args'].push('--allow-file-access-from-files');
     }

tools/exported_items.js

@@ -9,17 +9,14 @@ const {Assert, plural, print, removeFolder} = require('./utils.js');
 
 async function wrapRunTests(options = new Options()) {
     options.screenshotComparison = false;
-    options.noSandbox = true;
     return await runTests({'options': options, 'showLogs': false});
 }
 async function wrapRunTest(testPath, options = new Options()) {
     options.screenshotComparison = false;
-    options.noSandbox = true;
     return await runTest(testPath, {'options': options, 'showLogs': false});
 }
 async function wrapRunTestCode(testName, content, options = new Options()) {
     options.screenshotComparison = false;
-    options.noSandbox = true;
     return await runTestCode(testName, content, {'options': options, 'showLogs': false});
 }
 
@@ -305,9 +302,6 @@ async function checkOptions(x) {
     await x.assert(options.screenshotComparison, false);
     await x.assertTry(() => options.parseArguments(['--enable-screenshot-comparison']), [], true);
     await x.assert(options.screenshotComparison, true);
-    await x.assert(options.noSandbox, false);
-    await x.assertTry(() => options.parseArguments(['--no-sandbox']), [], true);
-    await x.assert(options.noSandbox, true);
     await x.assert(options.incognito, false);
     await x.assertTry(() => options.parseArguments(['--incognito']), [], true);
     await x.assert(options.incognito, true);
@@ -451,11 +445,6 @@ async function checkOptions(x) {
     await x.assertTry(() => options.validateFields(), [],
         '`Options.failOnJsError` field is supposed to be a boolean! (Type is string)');
 
-    options = new Options();
-    options.noSandbox = '';
-    await x.assertTry(() => options.validateFields(), [],
-        '`Options.noSandbox` field is supposed to be a boolean! (Type is string)');
-
     options = new Options();
     options.failOnRequestError = '';
     await x.assertTry(() => options.validateFields(), [],

tools/ui.js

@@ -9,9 +9,8 @@ utils.print = function print() {}; // overwriting the print function to avoid th
 const {runTests, Options} = require('../src/index.js');
 const {Assert, plural, print} = require('./utils.js');
 
-async function wrapRunTests(noSandbox, browser, options = new Options()) {
+async function wrapRunTests(browser, options = new Options()) {
     options.screenshotComparison = false;
-    options.noSandbox = noSandbox;
     const ret = await runTests({
         'options': options,
         'browser': browser,
@@ -32,7 +31,7 @@ function runAsyncUiTest(x, file, output, tests_queue, browser) {
 
     const callback = x.assertTryUi(
         wrapRunTests,
-        [x.noSandboxEnabled, browser, options],
+        [browser, options],
         output.replaceAll('$CURRENT_DIR', utils.getCurrentDir()),
         file,
         false,
@@ -75,7 +74,6 @@ async function compareOutput(x) {
     process.setMaxListeners(cpuCount);
     const tests_queue = [];
     const options = new Options();
-    options.noSandbox = x.noSandboxEnabled;
     const browser = await utils.loadPuppeteer(options);
 
     for (const file of filesToTest) {
@@ -149,19 +147,13 @@ if (require.main === module) {
     for (const arg of process.argv.slice(2)) {
         if (arg === '--bless') {
             x.blessEnabled = true;
-        } else if (arg === '--no-sandbox') {
-            x.noSandboxEnabled = true;
         } else {
             x.extraArgs.push(arg);
         }
     }
     if (!x.blessEnabled) {
         x.blessEnabled = process.env.npm_config_bless === 'true';
     }
-    if (!x.noSandboxEnabled) {
-        // The value is `true` if it's enabled.
-        x.noSandboxEnabled = process.env.npm_config_sandbox === '';
-    }
     checkUi(x).then(nbErrors => {
         process.exit(nbErrors !== 0 ? 1 : 0);
     });