Skip to content

Commit 06304ef

Browse files
authored
Rollup merge of rust-lang#149010 - Zalathar:wasm32-bare, r=jieyouxu
compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown` - Follow-up to rust-lang#148969 This "wasm32-bare" alias, understood by compiletest's `//@ ignore-wasm32-bare` and `//@ only-wasm32-bare` directives, dates all the way back to the original introduction of the `wasm32-unknown-unknown` target in rust-lang#45905. But there is no compelling reason to use an alias instead of the full target name. r? jieyouxu
2 parents 0bcf820 + 31902f3 commit 06304ef

File tree

6 files changed

+4
-17
lines changed

6 files changed

+4
-17
lines changed

src/doc/rustc-dev-guide/src/tests/directives.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ Some examples of `X` in `ignore-X` or `only-X`:
141141
- OS: `android`, `emscripten`, `freebsd`, `ios`, `linux`, `macos`, `windows`,
142142
...
143143
- Environment (fourth word of the target triple): `gnu`, `msvc`, `musl`
144-
- WASM: `wasm32-bare` matches `wasm32-unknown-unknown`.
145144
- Pointer width: `32bit`, `64bit`
146145
- Endianness: `endian-big`
147146
- Stage: `stage1`, `stage2`

src/tools/compiletest/src/directives/cfg.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -147,14 +147,6 @@ fn parse_cfg_name_directive<'a>(
147147
message: "when the target family is {name}"
148148
}
149149

150-
// `wasm32-bare` is an alias to refer to just wasm32-unknown-unknown
151-
// (in contrast to `wasm32` which also matches non-bare targets)
152-
condition! {
153-
name: "wasm32-bare",
154-
condition: config.target == "wasm32-unknown-unknown",
155-
message: "when the target is WASM"
156-
}
157-
158150
condition! {
159151
name: "thumb",
160152
condition: config.target.starts_with("thumb"),

src/tools/compiletest/src/directives/directive_names.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ pub(crate) const KNOWN_DIRECTIVE_NAMES: &[&str] = &[
125125
"ignore-wasi",
126126
"ignore-wasm",
127127
"ignore-wasm32",
128-
"ignore-wasm32-bare",
128+
"ignore-wasm32-unknown-unknown",
129129
"ignore-wasm64",
130130
"ignore-watchos",
131131
"ignore-windows",
@@ -240,7 +240,7 @@ pub(crate) const KNOWN_DIRECTIVE_NAMES: &[&str] = &[
240240
"only-unix",
241241
"only-visionos",
242242
"only-wasm32",
243-
"only-wasm32-bare",
243+
"only-wasm32-unknown-unknown",
244244
"only-wasm32-wasip1",
245245
"only-watchos",
246246
"only-windows",

src/tools/compiletest/src/directives/tests.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -710,18 +710,14 @@ fn wasm_special() {
710710
let ignores = [
711711
("wasm32-unknown-unknown", "emscripten", false),
712712
("wasm32-unknown-unknown", "wasm32", true),
713-
("wasm32-unknown-unknown", "wasm32-bare", true),
714713
("wasm32-unknown-unknown", "wasm64", false),
715714
("wasm32-unknown-emscripten", "emscripten", true),
716715
("wasm32-unknown-emscripten", "wasm32", true),
717-
("wasm32-unknown-emscripten", "wasm32-bare", false),
718716
("wasm32-wasip1", "emscripten", false),
719717
("wasm32-wasip1", "wasm32", true),
720-
("wasm32-wasip1", "wasm32-bare", false),
721718
("wasm32-wasip1", "wasi", true),
722719
("wasm64-unknown-unknown", "emscripten", false),
723720
("wasm64-unknown-unknown", "wasm32", false),
724-
("wasm64-unknown-unknown", "wasm32-bare", false),
725721
("wasm64-unknown-unknown", "wasm64", true),
726722
];
727723
for (target, pattern, ignore) in ignores {

tests/assembly-llvm/stack-protector/stack-protector-heuristics-effect.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
//@ ignore-apple slightly different policy on stack protection of arrays
44
//@ ignore-msvc stack check code uses different function names
55
//@ ignore-nvptx64 stack protector is not supported
6-
//@ ignore-wasm32-bare
6+
//@ ignore-wasm32-unknown-unknown
77
//@ [all] compile-flags: -Z stack-protector=all
88
//@ [strong] compile-flags: -Z stack-protector=strong
99
//@ [basic] compile-flags: -Z stack-protector=basic

tests/run-make/wasm-exceptions-nostd/rmake.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//@ only-wasm32-bare
1+
//@ only-wasm32-unknown-unknown
22

33
use std::path::Path;
44

0 commit comments

Comments
 (0)