Skip to content

Commit d2ade4e

Browse files
authored
Rollup merge of rust-lang#146949 - pmur:murp/improve-ppc-inline-asm, r=Amanieu
Add vsx register support for ppc inline asm, and implement preserves_flag option This should address the last(?) missing pieces of inline asm for ppc: * Explicit VSX register support. ISA 2.06 (POWER7) added a 64x128b register overlay extending the fpr's to 128b, and unifies them with the vmx (altivec) registers. Implementations details within gcc/llvm percolate up, and require using the `x` template modifier. I have updated the inline asm to implicitly include this for vsx arguments which do not specify it. ~~Support for the gcc codegen backend is still a todo.~~ * Implement the `preserves_flags` option. All ABI's, and all ISAs store their flags in `cr`, and the carry bit lives inside `xer`. The other status registers hold sticky bits or control bits which do not affect branch instructions. There is some interest in the e500 (powerpcspe) port. Architecturally, it has a very different FP ISA, and includes a simd extension called SPR (which is not IBM's cell SPE). Notably, it does not have altivec/fpr/vsx registers. It also has an SPE accumulator register which its ABI marks as volatile, but I am not sure if the compiler uses it.
2 parents 5f0d88f + d96167f commit d2ade4e

File tree

1 file changed

+21
-6
lines changed

1 file changed

+21
-6
lines changed

src/asm.rs

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -546,9 +546,16 @@ impl<'a, 'gcc, 'tcx> AsmBuilderMethods<'tcx> for Builder<'a, 'gcc, 'tcx> {
546546
}
547547

548548
if !options.contains(InlineAsmOptions::PRESERVES_FLAGS) {
549-
// TODO(@Commeownist): I'm not 100% sure this one clobber is sufficient
550-
// on all architectures. For instance, what about FP stack?
551-
extended_asm.add_clobber("cc");
549+
match asm_arch {
550+
InlineAsmArch::PowerPC | InlineAsmArch::PowerPC64 => {
551+
// "cc" is cr0 on powerpc.
552+
}
553+
// TODO(@Commeownist): I'm not 100% sure this one clobber is sufficient
554+
// on all architectures. For instance, what about FP stack?
555+
_ => {
556+
extended_asm.add_clobber("cc");
557+
}
558+
}
552559
}
553560
if !options.contains(InlineAsmOptions::NOMEM) {
554561
extended_asm.add_clobber("memory");
@@ -698,6 +705,7 @@ fn reg_class_to_gcc(reg_class: InlineAsmRegClass) -> &'static str {
698705
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::reg_nonzero) => "b",
699706
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::freg) => "f",
700707
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::vreg) => "v",
708+
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::vsreg) => "wa",
701709
InlineAsmRegClass::PowerPC(
702710
PowerPCInlineAsmRegClass::cr
703711
| PowerPCInlineAsmRegClass::ctr
@@ -778,9 +786,9 @@ fn dummy_output_type<'gcc, 'tcx>(cx: &CodegenCx<'gcc, 'tcx>, reg: InlineAsmRegCl
778786
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::reg) => cx.type_i32(),
779787
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::reg_nonzero) => cx.type_i32(),
780788
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::freg) => cx.type_f64(),
781-
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::vreg) => {
782-
cx.type_vector(cx.type_i32(), 4)
783-
}
789+
InlineAsmRegClass::PowerPC(
790+
PowerPCInlineAsmRegClass::vreg | PowerPCInlineAsmRegClass::vsreg,
791+
) => cx.type_vector(cx.type_i32(), 4),
784792
InlineAsmRegClass::PowerPC(
785793
PowerPCInlineAsmRegClass::cr
786794
| PowerPCInlineAsmRegClass::ctr
@@ -957,6 +965,13 @@ fn modifier_to_gcc(
957965
InlineAsmRegClass::LoongArch(_) => None,
958966
InlineAsmRegClass::Mips(_) => None,
959967
InlineAsmRegClass::Nvptx(_) => None,
968+
InlineAsmRegClass::PowerPC(PowerPCInlineAsmRegClass::vsreg) => {
969+
if modifier.is_none() {
970+
Some('x')
971+
} else {
972+
modifier
973+
}
974+
}
960975
InlineAsmRegClass::PowerPC(_) => None,
961976
InlineAsmRegClass::RiscV(RiscVInlineAsmRegClass::reg)
962977
| InlineAsmRegClass::RiscV(RiscVInlineAsmRegClass::freg) => None,

0 commit comments

Comments
 (0)