Skip to content

Commit f7defc0

Browse files
committed
Resolve review remarks
1 parent df2da84 commit f7defc0

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

src/bootstrap/src/core/build_steps/compile.rs

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ impl Step for Std {
215215
trace!(
216216
?compiler_to_use,
217217
?build_compiler,
218-
"compiler != compiler_to_use, uplifting library"
218+
"build_compiler != compiler_to_use, uplifting library"
219219
);
220220

221221
builder.std(compiler_to_use, target);
@@ -1609,13 +1609,8 @@ impl Step for GccCodegenBackend {
16091609
let gcc = builder.ensure(Gcc { target });
16101610
add_cg_gcc_cargo_flags(&mut cargo, &gcc);
16111611

1612-
let _guard = builder.msg(
1613-
Kind::Build,
1614-
format_args!("codegen backend gcc"),
1615-
Mode::Codegen,
1616-
build_compiler,
1617-
target,
1618-
);
1612+
let _guard =
1613+
builder.msg(Kind::Build, "codegen backend gcc", Mode::Codegen, build_compiler, target);
16191614
let files = run_cargo(builder, cargo, vec![], &stamp, vec![], false, false);
16201615
write_codegen_backend_stamp(stamp, files, builder.config.dry_run())
16211616
}
@@ -1695,7 +1690,7 @@ impl Step for CraneliftCodegenBackend {
16951690

16961691
let _guard = builder.msg(
16971692
Kind::Build,
1698-
format_args!("codegen backend cranelift"),
1693+
"codegen backend cranelift",
16991694
Mode::Codegen,
17001695
build_compiler,
17011696
target,

src/bootstrap/src/core/build_steps/test.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2232,6 +2232,7 @@ NOTE: if you're sure you want to do this, please open an issue as to why. In the
22322232
let _group = builder.msg(
22332233
Kind::Test,
22342234
format!("compiletest suite={suite} mode={mode}"),
2235+
// FIXME: compiletest sometimes behaves as ToolStd, we could expose that difference here
22352236
Mode::ToolBootstrap,
22362237
compiler,
22372238
target,

0 commit comments

Comments
 (0)