refactor: use member initializer and uniform initializer

Author: Gumichocopengin8

.gitignore

@@ -1,4 +1,5 @@
 .idea
 cmake-build-debug/
+cmake-build-release/
 .vscode/
 .DS_Store

biome/Biome.cpp

@@ -6,13 +6,6 @@
 #include <utility>
 #include "Biome.h"
 
-Biome::Biome(std::string id, int x, int z, BiomeType *type) {
-  this->id = std::move(id);
-  this->x = x;
-  this->z = z;
-  this->type = type;
-}
-
 float Biome::distance_to(float x, float z) const {
   return pow(x - this->x, 2) + pow(z - this->z, 2);
 }

biome/Biome.h

@@ -7,17 +7,18 @@
 
 #include <iostream>
 #include <string>
+#include <utility>
 
 #include "BiomeType.h"
 
 class Biome {
 public:
-  std::string id;
+  [[maybe_unused]] std::string id;
   int x;
   int z;
   BiomeType *type;
 
-  explicit Biome(std::string id, int x, int z, BiomeType *type);
+  explicit Biome(std::string id, int x, int z, BiomeType *type) : id{std::move(id)}, x{x}, z{z}, type{type} {};
 
   [[nodiscard]] float distance_to(float x, float z) const;
 };

block/Block.cpp

@@ -4,21 +4,11 @@
 
 #include "Block.h"
 #include "../texture/Texture.h"
-#include <iostream>
-#include <cstdlib>
 #import <GLUT/glut.h>
 
 #include "../main.h"
 
-Block::Block(int type, int x, int y, int z) {
-  this->type = type;
-  this->x = x;
-  this->y = y;
-  this->z = z;
-}
-
 void Block::render() const {
-
   // Transforms
   glPushMatrix();
   glTranslated(x, y, z);

block/Block.h

@@ -17,7 +17,7 @@ class Block {
   int z;
 
 public:
-  explicit Block(int type, int x, int y, int z);
+  explicit Block(int type, int x, int y, int z) : type{type}, x{x}, y{y}, z{z} {};
 
   void render() const;
 };

camera/Camera.cpp

@@ -18,19 +18,6 @@ namespace {
   constexpr float CAMERA_HEIGHT = 1.5;
 }
 
-
-Camera::Camera(float camera_x, float camera_y, float camera_z, float pitch, float yaw, float roll) {
-  this->camera_x = camera_x;
-  this->camera_y = camera_y;
-  this->camera_z = camera_z;
-  this->pitch = pitch;
-  this->yaw = yaw;
-  this->roll = roll;
-  this->x_speed = 0;
-  this->y_speed = 0;
-  this->z_speed = 0;
-}
-
 void Camera::refresh(Light light) {
   // transformations update
   gluLookAt(0, 0, 0, 0, 0, 1, 0, 1, 0);

camera/Camera.h

@@ -21,7 +21,9 @@ class Camera {
   float y_speed;
   float z_speed;
 
-  explicit Camera(float camera_x, float camera_y, float camera_z, float pitch, float yaw, float roll);
+  explicit Camera(float camera_x, float camera_y, float camera_z, float pitch, float yaw, float roll) :
+    camera_x{camera_x}, camera_y{camera_y}, camera_z{camera_z}, pitch{pitch}, yaw{yaw}, roll{roll},
+    x_speed{0}, y_speed{0}, z_speed{0} {};
 
   void refresh(Light light);
 

light/Light.cpp

@@ -5,8 +5,6 @@
 #include <GLUT/glut.h>
 #include "Light.h"
 
-Light::Light() {}
-
 void Light::ApplyLight() {
   glLightfv(GL_LIGHT0, GL_DIFFUSE, this->diffuse);
   glLightfv(GL_LIGHT0, GL_AMBIENT, this->ambient);

light/Light.h

@@ -16,7 +16,7 @@ class Light {
 public:
   float position[4]{0, 0, 0, 1.0}; // TODO: getter setter
 
-  explicit Light();
+  explicit Light() = default;
 
   void ApplyLight();
 };

main.cpp

@@ -12,7 +12,7 @@
 #include "keyboard/keyboard.h"
 #include "player/Player.h"
 #include "window/Window.h"
-#include "world/world.h"
+#include "world/World.h"
 
 #include "biome/BiomeType.h"