Skip to content

Commit fa1f6d7

Browse files
committed
fix: address Copilot review feedback
- Initialize syncedEmployeeData with undefined instead of potentially undefined employeeData - Use nullish coalescing (??) instead of || for displayedEmployees fallback
1 parent 47cb2f6 commit fa1f6d7

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/components/Payroll/PayrollConfiguration/PayrollConfiguration.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,15 +126,17 @@ export const Root = ({
126126
return employeeUuids.every(uuid => preparedUuids.has(uuid))
127127
}, [preparedPayroll?.employeeCompensations, employeeUuids])
128128

129-
const [syncedEmployeeData, setSyncedEmployeeData] = useState(employeeData)
129+
const [syncedEmployeeData, setSyncedEmployeeData] = useState<typeof employeeData | undefined>(
130+
undefined,
131+
)
130132

131133
useEffect(() => {
132134
if (isDataInSync && employeeData) {
133135
setSyncedEmployeeData(employeeData)
134136
}
135137
}, [isDataInSync, employeeData])
136138

137-
const displayedEmployees = syncedEmployeeData?.showEmployees || []
139+
const displayedEmployees = syncedEmployeeData?.showEmployees ?? []
138140
const isPaginationFetching = isFetchingEmployeeData || isPrepareLoading || !isDataInSync
139141

140142
const pagination = {

0 commit comments

Comments
 (0)