Skip to content

Commit 2e0149c

Browse files
committed
Fixing ComboBox failing tests. Need to properly fire open() only if the widget is attached.
1 parent 6ca6d76 commit 2e0149c

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/test/java/gwt/material/design/addins/client/ui/MaterialComboBoxTest.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ protected void dispatch(ClearEvent.ClearHandler eventHandler) {
267267
}
268268
});
269269
assertTrue(isClearEventFired[0]);
270-
270+
271271
// Clearing Handler
272272
final boolean[] isClearingEventFired = {false};
273273
comboBox.addClearingHandler(event -> {
@@ -336,9 +336,8 @@ public void testAddItemOption() {
336336

337337
}
338338

339-
//TODO: Failed Test
340339
public void testElements() {
341-
/*MaterialComboBox<User> comboBox = getWidget();
340+
MaterialComboBox<User> comboBox = getWidget();
342341

343342
assertNotNull(comboBox.getDropdownContainerElement());
344343
assertEquals(JsComboBox.$(comboBox.getElement()).find(".select2 .selection .select2-selection__rendered").html(), comboBox.getDropdownContainerElement().html());
@@ -348,9 +347,11 @@ public void testElements() {
348347
firedOpenHandler[0] = true;
349348
assertNotNull(comboBox.getDropdownResultElement());
350349
});
351-
comboBox.open();
352350

353-
assertTrue(firedOpenHandler[0]);*/
351+
comboBox.addAttachHandler(attachEvent -> {
352+
comboBox.open();
353+
assertTrue(firedOpenHandler[0]);
354+
});
354355
}
355356

356357
public void testLanguage() {

0 commit comments

Comments
 (0)