Skip to content

Commit bf37a9c

Browse files
committed
Added missing rating test for checkValueChangeEvent.
1 parent 942a71b commit bf37a9c

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

src/test/java/gwt/material/design/addins/client/MaterialRatingTest.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import com.google.gwt.event.dom.client.ClickEvent;
2323
import com.google.gwt.user.client.ui.Widget;
24+
import gwt.material.design.addins.client.base.AbstractValueWidgetTest;
2425
import gwt.material.design.addins.client.base.MaterialAddinsTest;
2526
import gwt.material.design.addins.client.base.constants.AddinsCssName;
2627
import gwt.material.design.addins.client.rating.MaterialRating;
@@ -32,14 +33,14 @@
3233
*
3334
* @author kevzlou7979
3435
*/
35-
public class MaterialRatingTest extends MaterialAddinsTest {
36+
public class MaterialRatingTest extends AbstractValueWidgetTest {
3637

3738
public void init() {
3839
MaterialRating rating = new MaterialRating();
3940
checkWidget(rating);
4041
checkStructure(rating);
4142
checkValue(rating);
42-
checkValueChangeEvent(rating);
43+
checkValueChangeEvent(rating, 5, 2);
4344
checkEditable(rating);
4445
}
4546

@@ -59,17 +60,6 @@ protected <T extends MaterialRating> void checkEditable(T rating) {
5960
assertEquals(Math.toIntExact(rating.getValue()), 5);
6061
}
6162

62-
protected <T extends MaterialRating> void checkValueChangeEvent(T rating) {
63-
final boolean[] isValueChangeFired = {false};
64-
final Integer VALUE = 2;
65-
rating.addValueChangeHandler(valueChangeEvent -> {
66-
assertEquals(valueChangeEvent.getValue(), VALUE);
67-
isValueChangeFired[0] = true;
68-
});
69-
rating.setValue(2, true);
70-
assertTrue(isValueChangeFired[0]);
71-
}
72-
7363
protected <T extends MaterialRating> void checkValue(T rating) {
7464
// Determine the number of selected icons vs. unselected ones
7565
rating.setSelectedRatingIcon(IconType.FAVORITE);

0 commit comments

Comments
 (0)