Skip to content

Commit c961e23

Browse files
committed
Fixed and provided JUnit Test - MaterialComboBox function "public Option addItem(String text, T value)" return null always #228
1 parent 75e8410 commit c961e23

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/main/java/gwt/material/design/addins/client/combobox/MaterialComboBox.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -471,6 +471,7 @@ public Option addItem(String text, T value) {
471471
Option option = buildOption(text, value);
472472
values.add(value);
473473
listbox.add(option);
474+
return option;
474475
}
475476
return null;
476477
}

src/test/java/gwt/material/design/addins/client/MaterialComboBoxTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ protected void checkEmptyOrNullValue(MaterialComboBox comboBox) {
7777
protected <T extends MaterialWidget & HasColors> void checkColor(T widget) {
7878
MaterialComboBox comboBox = new MaterialComboBox();
7979
for (int i = 1; i <= 5; i++) {
80-
comboBox.addItem(String.valueOf(i), String.valueOf(i));
80+
Option option = comboBox.addItem(String.valueOf(i), String.valueOf(i));
81+
assertNotNull(option);
8182
}
8283
comboBox.setTextColor(Color.RED);
8384
RootPanel.get().add(comboBox);

0 commit comments

Comments
 (0)