Remove setEnabled from MaterialDropDown & add example UiBinder test modification.

Author: BenDol

gwt-material/src/main/java/gwt/material/design/client/base/MaterialWidget.java

@@ -38,6 +38,7 @@
 import gwt.material.design.client.events.DragOverEvent;
 import gwt.material.design.client.events.DragStartEvent;
 import gwt.material.design.client.events.DropEvent;
+import gwt.material.design.client.events.OrientationChangeEvent.OrientationChangeHandler;
 import gwt.material.design.jquery.client.api.JQuery;
 import gwt.material.design.jquery.client.api.JQueryElement;
 
@@ -496,18 +497,12 @@ public WavesType getWaves() {
 
     @Override
     public void setDataAttribute(String dataAttr, String value) {
-        if (!dataAttr.startsWith("data-")) {
-            dataAttr = "data-" + dataAttr;
-        }
-        getElement().setAttribute(dataAttr, value);
+        getElement().setAttribute(!dataAttr.startsWith("data-") ? "data-" + dataAttr : dataAttr, value);
     }
 
     @Override
     public String getDataAttribute(String dataAttr) {
-        if (!dataAttr.startsWith("data-")) {
-            dataAttr = "data-" + dataAttr;
-        }
-        return getElement().getAttribute(dataAttr);
+        return getElement().getAttribute(!dataAttr.startsWith("data-") ? "data-" + dataAttr : dataAttr);
     }
 
     @Override
@@ -1276,13 +1271,10 @@ public HandlerRegistration addFocusHandler(FocusHandler handler) {
     }
 
     @Override
-    public HandlerRegistration addOrientationChangeHandler(OrientationChangeEvent.OrientationChangeHandler handler) {
-        return addHandler(new OrientationChangeEvent.OrientationChangeHandler() {
-            @Override
-            public void onOrientationChange(OrientationChangeEvent event) {
-                if (isEnabled()) {
-                    handler.onOrientationChange(event);
-                }
+    public HandlerRegistration addOrientationChangeHandler(OrientationChangeHandler handler) {
+        return addHandler(event -> {
+            if (isEnabled()) {
+                handler.onOrientationChange(event);
             }
         }, OrientationChangeEvent.TYPE);
     }

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialDropDown.java

@@ -117,7 +117,9 @@ protected void registerDropdownItemHandlers() {
                 ListItem item = (ListItem) widget;
                 if (item.getWidget(0) instanceof MaterialWidget) {
                     MaterialWidget child = (MaterialWidget) item.getWidget(0);
-                    registerHandler(child.addDomHandler(event -> SelectionEvent.fire(MaterialDropDown.this, child), ClickEvent.getType()));
+                    registerHandler(child.addDomHandler(event -> {
+                        SelectionEvent.fire(MaterialDropDown.this, child);
+                    }, ClickEvent.getType()));
                 }
             }
         });
@@ -278,16 +280,6 @@ public void setActivator(String activator) {
         setId(activator);
     }
 
-    @Override
-    public void setEnabled(boolean enabled) {
-        super.setEnabled(enabled);
-        Widget parent = getParent();
-        if (parent instanceof HasEnabled) {
-            ((HasEnabled) parent).setEnabled(isEnabled());
-        }
-        reload();
-    }
-
     public List<Widget> getItems() {
         return getChildrenList();
     }

gwt-material/src/test/java/gwt/material/design/client/WidgetTestCase.java

@@ -43,16 +43,20 @@ public T getWidget(boolean tryAttach) {
             widget = createWidget();
         }
         if(!neverAttach() && tryAttach && !widget.isAttached()) {
-            RootPanel.get().add(widget);
-
-            if (unloadThenLoad()) {
-                widget.removeFromParent();
-                RootPanel.get().add(widget);
-            }
+            attachWidget();
         }
         return widget;
     }
 
+    protected void attachWidget() {
+        RootPanel.get().add(widget);
+
+        if (unloadThenLoad()) {
+            widget.removeFromParent();
+            RootPanel.get().add(widget);
+        }
+    }
+
     public boolean neverAttach() {
         return false;
     }

gwt-material/src/test/java/gwt/material/design/client/ui/base/MaterialWidgetTest.java

@@ -60,7 +60,7 @@ protected void checkVerticalAlign(MaterialWidget widget, Style.VerticalAlign val
 
     public void testBorder() {
         // given
-        T widget = getWidget();
+        T widget = getWidget(false);
 
         // when / then
         final String BORDER = "1px solid red";
@@ -69,6 +69,11 @@ public void testBorder() {
         final String BORDER_BOTTOM = "10px solid";
         final String BORDER_TOP = "5px ridge";
 
+        // test before attach
+        widget.setBorder(BORDER);
+
+        attachWidget();
+
         widget.setBorder(BORDER);
         assertEquals(BORDER, widget.getBorder());
         assertEquals(BORDER, widget.getElement().getStyle().getProperty("border"));