Skip to content

Commit 07b34ce

Browse files
committed
Fixed - MaterialLabel does not escape the given text. #497
1 parent bb876a6 commit 07b34ce

File tree

6 files changed

+14
-8
lines changed

6 files changed

+14
-8
lines changed

gwt-material/src/main/java/gwt/material/design/client/base/AbstractTextWidget.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.gwt.editor.client.IsEditor;
2424
import com.google.gwt.editor.client.LeafValueEditor;
2525
import com.google.gwt.editor.ui.client.adapters.HasTextEditor;
26+
import com.google.gwt.safehtml.shared.SafeHtmlUtils;
2627
import com.google.gwt.user.client.ui.HasHTML;
2728

2829
/**
@@ -65,7 +66,7 @@ public String getHTML() {
6566

6667
@Override
6768
public void setHTML(final String html) {
68-
getElement().setInnerHTML(html);
69+
getElement().setInnerSafeHtml(SafeHtmlUtils.fromString(html));
6970
}
7071

7172
@Override

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialBadge.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
package gwt.material.design.client.ui;
2121

2222
import com.google.gwt.dom.client.Document;
23+
import com.google.gwt.safehtml.shared.SafeHtmlUtils;
2324
import gwt.material.design.client.constants.Color;
2425
import gwt.material.design.client.constants.CssName;
2526
import gwt.material.design.client.ui.html.Span;
@@ -88,6 +89,6 @@ public String getText() {
8889

8990
@Override
9091
public void setText(String text) {
91-
getElement().setInnerHTML(text);
92+
getElement().setInnerSafeHtml(SafeHtmlUtils.fromString(text));
9293
}
9394
}

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialCollection.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import com.google.gwt.core.client.GWT;
2323
import com.google.gwt.dom.client.Document;
24+
import com.google.gwt.safehtml.shared.SafeHtmlUtils;
2425
import com.google.gwt.user.client.ui.Widget;
2526
import com.google.web.bindery.event.shared.HandlerRegistration;
2627
import gwt.material.design.client.base.HasActiveParent;
@@ -109,7 +110,7 @@ public MaterialCollection() {
109110
* Sets the header of the collection component.
110111
*/
111112
public void setHeader(String header) {
112-
span.getElement().setInnerHTML(header);
113+
span.getElement().setInnerSafeHtml(SafeHtmlUtils.fromString(header));
113114
addStyleName(CssName.WITH_HEADER);
114115
ListItem item = new ListItem(span);
115116
UiHelper.addMousePressedHandlers(item);

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialLabel.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import com.google.gwt.dom.client.Document;
2323
import com.google.gwt.dom.client.Style.Unit;
24+
import com.google.gwt.safehtml.shared.SafeHtmlUtils;
2425
import com.google.gwt.user.client.ui.HasText;
2526
import gwt.material.design.client.base.HasFontSize;
2627
import gwt.material.design.client.base.MaterialWidget;
@@ -83,6 +84,6 @@ public String getText() {
8384

8485
@Override
8586
public void setText(String text) {
86-
getElement().setInnerHTML(text);
87+
getElement().setInnerSafeHtml(SafeHtmlUtils.fromString(text));
8788
}
8889
}

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialTitle.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
package gwt.material.design.client.ui;
2121

2222
import com.google.gwt.dom.client.Style.Unit;
23+
import com.google.gwt.safehtml.shared.SafeHtmlUtils;
2324
import gwt.material.design.client.base.HasTitle;
2425
import gwt.material.design.client.constants.HeadingSize;
2526
import gwt.material.design.client.ui.html.Div;
@@ -74,6 +75,6 @@ public void setDescription(String description) {
7475

7576
@Override
7677
public void setTitle(String title) {
77-
header.getElement().setInnerHTML(title);
78+
header.getElement().setInnerSafeHtml(SafeHtmlUtils.fromString(title));
7879
}
7980
}

gwt-material/src/main/java/gwt/material/design/client/ui/html/Span.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import com.google.gwt.dom.client.Document;
2323
import com.google.gwt.dom.client.Element;
24+
import com.google.gwt.safehtml.shared.SafeHtmlUtils;
2425
import com.google.gwt.user.client.ui.HasText;
2526
import gwt.material.design.client.base.MaterialWidget;
2627

@@ -35,9 +36,9 @@ public Span(Element e, String... initialClass) {
3536
super(e, initialClass);
3637
}
3738

38-
public Span(String string) {
39+
public Span(String text) {
3940
this();
40-
getElement().setInnerHTML(string);
41+
setText(text);
4142
}
4243

4344
@Override
@@ -48,6 +49,6 @@ public String getText() {
4849
@Override
4950
public void setText(String text) {
5051
this.text = text;
51-
getElement().setInnerHTML(text);
52+
getElement().setInnerSafeHtml(SafeHtmlUtils.fromString(text));
5253
}
5354
}

0 commit comments

Comments
 (0)