Fix #981: DOM breakage in MaterialListValueBox

Medo42 · web-flow · commit 1d9cd6b238e0 · 2020-08-25T16:02:32.000+02:00
Fixes DOM breakage if MaterialListValueBox.setReadOnly(false) is called before attaching
diff --git a/gwt-material/src/main/java/gwt/material/design/client/ui/MaterialListValueBox.java b/gwt-material/src/main/java/gwt/material/design/client/ui/MaterialListValueBox.java
@@ -958,7 +958,7 @@ public void setKeyFactory(KeyFactory<T, String> keyFactory) {
     @Override
     public void setReadOnly(boolean value) {
         getReadOnlyMixin().setReadOnly(value);
-        if (!value) {
+        if (!value && isAttached()) {
             $(listBox.getElement()).material_select("destroy");
             $(listBox.getElement()).material_select();
         }

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ public void setKeyFactory(KeyFactory<T, String> keyFactory) {`
`958`	`958`	`@Override`
`959`	`959`	`public void setReadOnly(boolean value) {`
`960`	`960`	`getReadOnlyMixin().setReadOnly(value);`
`961`		`- if (!value) {`
	`961`	`+ if (!value && isAttached()) {`
`962`	`962`	`$(listBox.getElement()).material_select("destroy");`
`963`	`963`	`$(listBox.getElement()).material_select();`
`964`	`964`	`}`