Skip to content

Commit 3dc64db

Browse files
committed
Fixed MaterialCollapsibleItem.setActive(boolean) not working #719
1 parent b807feb commit 3dc64db

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialCollapsibleItem.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ public boolean remove(Widget w) {
106106
public void expand() {
107107
if (body != null) {
108108
setActive(true);
109-
body.setDisplay(Display.BLOCK);
110109
}
111110
}
112111

@@ -116,7 +115,6 @@ public void expand() {
116115
public void collapse() {
117116
if (body != null) {
118117
setActive(false);
119-
body.setDisplay(Display.NONE);
120118
}
121119
}
122120

@@ -160,6 +158,10 @@ public void setActive(boolean active) {
160158
header.addStyleName(CssName.ACTIVE);
161159
}
162160
}
161+
162+
if (body != null) {
163+
body.setDisplay(active ? Display.BLOCK : Display.NONE);
164+
}
163165
}
164166

165167
@Override

gwt-material/src/test/java/gwt/material/design/client/ui/MaterialCollapsibleTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,13 @@ public void testPreSelection() {
197197
assertTrue(item.isActive());
198198
assertTrue(item.getElement().hasClassName(CssName.ACTIVE));
199199
assertTrue(item.getHeader().getElement().hasClassName(CssName.ACTIVE));
200+
assertEquals(Display.BLOCK.getCssName(), item.getBody().getElement().getStyle().getDisplay());
200201

201202
item.setActive(false);
202203
assertFalse(item.isActive());
203204
assertFalse(item.getElement().hasClassName(CssName.ACTIVE));
204205
assertFalse(item.getHeader().getElement().hasClassName(CssName.ACTIVE));
206+
assertEquals(Display.NONE.getCssName(), item.getBody().getElement().getStyle().getDisplay());
205207
}
206208

207209
collapsible.clearActive();

0 commit comments

Comments
 (0)