Major fixes with JQuery race loading (for addins particularly).

BenDol · BenDol · commit 456bd27280e9 · 2016-11-28T23:55:21.000+13:00
We will always guarantee that jQuery is loaded in any static loading priority.
diff --git a/gwt-material/src/main/java/gwt/material/design/client/JQueryProvider.java b/gwt-material/src/main/java/gwt/material/design/client/JQueryProvider.java
@@ -0,0 +1,56 @@
+/*
+ * #%L
+ * GwtMaterial
+ * %%
+ * Copyright (C) 2015 - 2016 GwtMaterialDesign
+ * %%
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * #L%
+ */
+package gwt.material.design.client;
+
+import com.google.gwt.core.client.GWT;
+import com.google.gwt.resources.client.TextResource;
+import gwt.material.design.client.resources.WithJQueryDebugResources;
+import gwt.material.design.client.resources.WithJQueryResources;
+
+public class JQueryProvider {
+
+    public TextResource jQuery() {
+        return null;
+    }
+
+    public static class JQueryDebug extends JQueryProvider {
+        private WithJQueryDebugResources resources;
+
+        @Override
+        public TextResource jQuery() {
+            if(resources == null) {
+                resources = GWT.create(WithJQueryDebugResources.class);
+            }
+            return resources.jQueryDebug();
+        }
+    }
+
+    public static class JQueryCompressed extends JQueryProvider {
+        private WithJQueryResources resources;
+
+        @Override
+        public TextResource jQuery() {
+            if(resources == null) {
+                resources = GWT.create(WithJQueryResources.class);
+            }
+            return resources.jQuery();
+        }
+    }
+}
diff --git a/gwt-material/src/main/java/gwt/material/design/client/MaterialDesignBase.java b/gwt-material/src/main/java/gwt/material/design/client/MaterialDesignBase.java
@@ -20,6 +20,7 @@
  * #L%
  */
 
+import com.google.gwt.core.client.GWT;
 import com.google.gwt.core.client.ScriptInjector;
 import com.google.gwt.dom.client.StyleInjector;
 import com.google.gwt.resources.client.TextResource;
@@ -41,7 +42,7 @@ public FutureResource(TextResource resource, boolean removeTag, boolean sourceUr
         }
     }
 
-    static TextResource jqueryResource;
+    static final JQueryProvider jQueryProvider = GWT.create(JQueryProvider.class);
     static List<FutureResource> futureResources;
 
     protected void load() {
@@ -93,20 +94,21 @@ public static void injectCss(TextResource resource) {
     }
 
     protected static boolean checkJQuery(boolean debug) {
-        if (!isjQueryLoaded()) {
-            if (jqueryResource != null) {
-                if (debug) {
-                    injectDebugJs(jqueryResource);
-                } else {
-                    injectJs(jqueryResource);
-                }
+        if (!isjQueryLoaded() && isProvidingJQuery()) {
+            if (debug) {
+                injectDebugJs(jQueryProvider.jQuery());
             } else {
-                return false;
+                injectJs(jQueryProvider.jQuery());
             }
         }
         return true;
     }
 
+    public static boolean isProvidingJQuery() {
+        return jQueryProvider instanceof JQueryProvider.JQueryDebug ||
+               jQueryProvider instanceof JQueryProvider.JQueryCompressed;
+    }
+
     /**
      * Check to see if jQuery is loaded already
      *
diff --git a/gwt-material/src/main/java/gwt/material/design/client/MaterialWithJQuery.java b/gwt-material/src/main/java/gwt/material/design/client/MaterialWithJQuery.java
@@ -21,13 +21,11 @@
  */
 
 import com.google.gwt.core.client.EntryPoint;
-import gwt.material.design.client.resources.WithJQueryResources;
 
 public class MaterialWithJQuery extends MaterialDesignBase implements EntryPoint {
 
     @Override
     public void onModuleLoad() {
-        jqueryResource = WithJQueryResources.INSTANCE.jQuery();
         load();
     }
 }
diff --git a/gwt-material/src/main/java/gwt/material/design/client/MaterialWithJQueryDebug.java b/gwt-material/src/main/java/gwt/material/design/client/MaterialWithJQueryDebug.java
@@ -21,7 +21,6 @@
  */
 
 import com.google.gwt.core.client.EntryPoint;
-import gwt.material.design.client.resources.WithJQueryDebugResources;
 
 /**
  * Entry point classes define <code>onModuleLoad()</code>.
@@ -30,7 +29,6 @@ public class MaterialWithJQueryDebug extends MaterialDesignDebugBase implements
 
     @Override
     public void onModuleLoad() {
-        jqueryResource = WithJQueryDebugResources.INSTANCE.jQueryDebug();
         load();
     }
 }
diff --git a/gwt-material/src/main/java/gwt/material/design/client/resources/WithJQueryDebugResources.java b/gwt-material/src/main/java/gwt/material/design/client/resources/WithJQueryDebugResources.java
@@ -19,12 +19,10 @@
  */
 package gwt.material.design.client.resources;
 
-import com.google.gwt.core.client.GWT;
 import com.google.gwt.resources.client.ClientBundle;
 import com.google.gwt.resources.client.TextResource;
 
 public interface WithJQueryDebugResources extends ClientBundle {
-    WithJQueryDebugResources INSTANCE = GWT.create(WithJQueryDebugResources.class);
 
     @Source("js/jquery-2.1.1.js")
     TextResource jQueryDebug();
diff --git a/gwt-material/src/main/java/gwt/material/design/client/resources/WithJQueryResources.java b/gwt-material/src/main/java/gwt/material/design/client/resources/WithJQueryResources.java
@@ -19,12 +19,10 @@
  */
 package gwt.material.design.client.resources;
 
-import com.google.gwt.core.client.GWT;
 import com.google.gwt.resources.client.ClientBundle;
 import com.google.gwt.resources.client.TextResource;
 
 public interface WithJQueryResources extends ClientBundle {
-    WithJQueryResources INSTANCE = GWT.create(WithJQueryResources.class);
 
     @Source("js/jquery-2.1.1.min.js")
     TextResource jQuery();
diff --git a/gwt-material/src/main/resources/gwt/material/design/GwtMaterialBasicWithJQuery.gwt.xml b/gwt-material/src/main/resources/gwt/material/design/GwtMaterialBasicWithJQuery.gwt.xml
@@ -29,6 +29,14 @@
   <inherits name="gwt.material.design.GwtMaterialDesignBase"/>
   <inherits name="gwt.material.design.ResourcesBasic"/>
 
+  <replace-with class="gwt.material.design.client.JQueryProvider.JQueryCompressed">
+    <when-type-is class="gwt.material.design.client.JQueryProvider"/>
+  </replace-with>
+
+  <replace-with class="gwt.material.design.client.resources.WithJQueryResources">
+    <when-type-is class="gwt.material.design.client.resources.JQueryResource"/>
+  </replace-with>
+
   <!-- Specify the app entry point class -->
   <entry-point class="gwt.material.design.client.MaterialWithJQuery"/>
 </module>
diff --git a/gwt-material/src/main/resources/gwt/material/design/GwtMaterialBasicWithJQueryDebug.gwt.xml b/gwt-material/src/main/resources/gwt/material/design/GwtMaterialBasicWithJQueryDebug.gwt.xml
@@ -29,6 +29,14 @@
   <inherits name="gwt.material.design.GwtMaterialDesignBase"/>
   <inherits name="gwt.material.design.ResourcesBasic"/>
 
+  <replace-with class="gwt.material.design.client.JQueryProvider.JQueryDebug">
+    <when-type-is class="gwt.material.design.client.JQueryProvider"/>
+  </replace-with>
+
+  <replace-with class="gwt.material.design.client.resources.WithJQueryDebugResources">
+    <when-type-is class="gwt.material.design.client.resources.JQueryResource"/>
+  </replace-with>
+
   <!-- Specify the app entry point class -->
   <entry-point class="gwt.material.design.client.MaterialWithJQueryDebug"/>
 </module>
diff --git a/gwt-material/src/main/resources/gwt/material/design/GwtMaterialWithJQuery.gwt.xml b/gwt-material/src/main/resources/gwt/material/design/GwtMaterialWithJQuery.gwt.xml
@@ -29,6 +29,14 @@
   <inherits name="gwt.material.design.GwtMaterialDesignBase"/>
   <inherits name="gwt.material.design.Resources"/>
 
+  <replace-with class="gwt.material.design.client.JQueryProvider.JQueryCompressed">
+    <when-type-is class="gwt.material.design.client.JQueryProvider"/>
+  </replace-with>
+
+  <replace-with class="gwt.material.design.client.resources.WithJQueryResources">
+    <when-type-is class="gwt.material.design.client.resources.JQueryResource"/>
+  </replace-with>
+
   <!-- Specify the app entry point class -->
   <entry-point class="gwt.material.design.client.MaterialWithJQuery"/>
 </module>
diff --git a/gwt-material/src/main/resources/gwt/material/design/GwtMaterialWithJQueryDebug.gwt.xml b/gwt-material/src/main/resources/gwt/material/design/GwtMaterialWithJQueryDebug.gwt.xml
@@ -29,6 +29,14 @@
   <inherits name="gwt.material.design.GwtMaterialDesignBase"/>
   <inherits name="gwt.material.design.Resources"/>
 
+  <replace-with class="gwt.material.design.client.JQueryProvider.JQueryDebug">
+    <when-type-is class="gwt.material.design.client.JQueryProvider"/>
+  </replace-with>
+
+  <replace-with class="gwt.material.design.client.resources.WithJQueryDebugResources">
+    <when-type-is class="gwt.material.design.client.resources.JQueryResource"/>
+  </replace-with>
+
   <!-- Specify the app entry point class -->
   <entry-point class="gwt.material.design.client.MaterialWithJQueryDebug"/>
 </module>
diff --git a/gwt-material/src/test/java/gwt/material/design/client/GwtMaterialTestComponent.java b/gwt-material/src/test/java/gwt/material/design/client/GwtMaterialTestComponent.java
@@ -19,6 +19,7 @@
  */
 package gwt.material.design.client;
 
+import com.google.gwt.core.client.GWT;
 import com.google.gwt.junit.client.GWTTestCase;
 import gwt.material.design.client.resources.MaterialResources;
 import gwt.material.design.client.resources.WithJQueryResources;
@@ -49,8 +50,9 @@ protected void gwtSetUp() throws Exception {
     }
 
     public void setup() {
+        WithJQueryResources jquery = GWT.create(WithJQueryResources.class);
         // Test JQuery
-        MaterialDesign.injectJs(WithJQueryResources.INSTANCE.jQuery());
+        MaterialDesign.injectJs(jquery.jQuery());
         assertTrue(MaterialDesign.isjQueryLoaded());
         // Test Materialize
         MaterialDesign.injectJs(MaterialResources.INSTANCE.materializeJs());

Original file line number	Diff line number	Diff line change
`@@ -21,13 +21,11 @@`
`21`	`21`	`*/`
`22`	`22`
`23`	`23`	`import com.google.gwt.core.client.EntryPoint;`
`24`		`-import gwt.material.design.client.resources.WithJQueryResources;`
`25`	`24`
`26`	`25`	`public class MaterialWithJQuery extends MaterialDesignBase implements EntryPoint {`
`27`	`26`
`28`	`27`	`@Override`
`29`	`28`	`public void onModuleLoad() {`
`30`		`- jqueryResource = WithJQueryResources.INSTANCE.jQuery();`
`31`	`29`	`load();`
`32`	`30`	`}`
`33`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@`
`21`	`21`	`*/`
`22`	`22`
`23`	`23`	`import com.google.gwt.core.client.EntryPoint;`
`24`		`-import gwt.material.design.client.resources.WithJQueryDebugResources;`
`25`	`24`
`26`	`25`	`/**`
`27`	`26`	`* Entry point classes define <code>onModuleLoad()</code>.`
`@@ -30,7 +29,6 @@ public class MaterialWithJQueryDebug extends MaterialDesignDebugBase implements`
`30`	`29`
`31`	`30`	`@Override`
`32`	`31`	`public void onModuleLoad() {`
`33`		`- jqueryResource = WithJQueryDebugResources.INSTANCE.jQueryDebug();`
`34`	`32`	`load();`
`35`	`33`	`}`
`36`	`34`	`}`