Autocomplete - Use valuebox.setAutocomplete(ON | OFF | NEW_PASSWORD) instead of valuebox.setAutocomplete(true | false) because of browser new policies.

Author: kevzlou7979

gwt-material/src/main/java/gwt/material/design/client/base/HasAutocomplete.java

@@ -19,9 +19,16 @@
  */
 package gwt.material.design.client.base;
 
+import gwt.material.design.client.constants.Autocomplete;
+
+/**
+ * The autocomplete attribute specifies whether or not an input field should have autocomplete enabled.
+ *
+ * <a href="https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion">Documentation</a>
+ */
 public interface HasAutocomplete {
 
-    void setAutocomplete(boolean value);
+    void setAutocomplete(Autocomplete autocomplete);
 
-    boolean isAutocomplete();
+    Autocomplete getAutocomplete();
 }

gwt-material/src/main/java/gwt/material/design/client/constants/Autocomplete.java

@@ -0,0 +1,43 @@
+/*
+ * #%L
+ * GwtMaterial
+ * %%
+ * Copyright (C) 2015 - 2020 GwtMaterialDesign
+ * %%
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * #L%
+ */
+package gwt.material.design.client.constants;
+
+import java.util.Arrays;
+
+public enum Autocomplete {
+
+    ON("on"),
+    OFF("off"),
+    NEW_PASSWORD("new-password");
+
+    private String name;
+
+    Autocomplete(String name) {
+        this.name = name;
+    }
+
+    public String getName() {
+        return name;
+    }
+
+    public static Autocomplete get(String name) {
+        return name != null && !name.isEmpty() ? Arrays.stream(values()).filter(autocomplete -> autocomplete.getName().equals(name)).findAny().orElse(null) : null;
+    }
+}

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialSearch.java

@@ -29,10 +29,7 @@
 import gwt.material.design.client.base.HasActive;
 import gwt.material.design.client.base.HasSearchHandlers;
 import gwt.material.design.client.base.SearchObject;
-import gwt.material.design.client.constants.Color;
-import gwt.material.design.client.constants.CssName;
-import gwt.material.design.client.constants.IconType;
-import gwt.material.design.client.constants.InputType;
+import gwt.material.design.client.constants.*;
 import gwt.material.design.client.events.SearchFinishEvent;
 import gwt.material.design.client.events.SearchNoResultEvent;
 import gwt.material.design.client.ui.html.Label;
@@ -134,7 +131,7 @@ protected void onLoad() {
         super.onLoad();
 
         setType(InputType.SEARCH);
-        setAutocomplete(false);
+        setAutocomplete(Autocomplete.OFF);
         label.add(iconSearch);
         label.getElement().setAttribute("for", "search");
         add(label);

gwt-material/src/main/java/gwt/material/design/client/ui/MaterialValueBox.java

@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -122,7 +122,7 @@ public MaterialValueBox(ValueBoxBase<T> tValueBox) {
     public void setup(ValueBoxBase<T> tValueBox) {
         valueBoxBase = tValueBox;
         add(valueBoxBase);
-        setAutocomplete(false);
+        setAutocomplete(Autocomplete.OFF);
     }
 
     @Deprecated
@@ -565,13 +565,13 @@ public void setFieldWidth(double percentWidth) {
     }
 
     @Override
-    public void setAutocomplete(boolean value) {
-        valueBoxBase.getElement().setAttribute("autocomplete", value ? "on" : "off");
+    public void setAutocomplete(Autocomplete value) {
+        valueBoxBase.getElement().setAttribute("autocomplete", value.getName());
     }
 
     @Override
-    public boolean isAutocomplete() {
-        return valueBoxBase.getElement().getAttribute("autocomplete").equals("on");
+    public Autocomplete getAutocomplete() {
+        return Autocomplete.get(valueBoxBase.getElement().getAttribute("autocomplete"));
     }
 
     @Override

gwt-material/src/test/java/gwt/material/design/client/ui/MaterialValueBoxTest.java

@@ -22,6 +22,7 @@
 import com.google.gwt.event.shared.HasHandlers;
 import com.google.gwt.user.client.ui.IsWidget;
 import com.google.gwt.user.client.ui.ValueBoxBase;
+import gwt.material.design.client.constants.Autocomplete;
 import gwt.material.design.client.constants.StatusDisplayType;
 import gwt.material.design.client.ui.base.AbstractValueWidgetTest;
 
@@ -120,14 +121,18 @@ protected <W extends MaterialValueBox> void checkMandatoryField(W widget) {
     protected <W extends MaterialValueBox> void checkAutocomplete(W widget) {
         ValueBoxBase valueBoxBase = widget.getValueBoxBase();
 
-        widget.setAutocomplete(true);
-        assertTrue(widget.isAutocomplete());
+        widget.setAutocomplete(Autocomplete.ON);
+        assertEquals(Autocomplete.ON, widget.getAutocomplete());
         assertEquals(valueBoxBase.getElement().getAttribute("autocomplete"), "on");
 
-        widget.setAutocomplete(false);
-        assertFalse(widget.isAutocomplete());
+        widget.setAutocomplete(Autocomplete.OFF);
+        assertEquals(Autocomplete.OFF, widget.getAutocomplete());
         assertEquals(valueBoxBase.getElement().getAttribute("autocomplete"), "off");
 
+        widget.setAutocomplete(Autocomplete.NEW_PASSWORD);
+        assertEquals(Autocomplete.NEW_PASSWORD, widget.getAutocomplete());
+        assertEquals(valueBoxBase.getElement().getAttribute("autocomplete"), "new-password");
+
         valueBoxBase.getElement().removeAttribute("autocomplete");
     }