Fix: minor polishing to get session time o work

Author: GwynethLlewelyn

gwynethllewelyn/postlocalstorage/event/listener.php

@@ -50,7 +50,7 @@ public function __construct(\phpbb\template\template $template, \phpbb\user $use
 		$this->user     = $user;
 		$this->request  = $request;
 		$this->config   = $config;
-		$this->time_now - time();	// assign current time.
+		$this->time_now = time();	// assign current time.
 	}
 
 
@@ -61,7 +61,7 @@ public function __construct(\phpbb\template\template $template, \phpbb\user $use
 	 */
 	static public function getSubscribedEvents()
 	{
-		error_log('[phpBB3 postlocalstorage] my getSubscribedEvents was called!');
+		// error_log('[phpBB3 postlocalstorage] my getSubscribedEvents was called!');
 		return [
 			'core.modify_submit_post_data' => 'check_expiry_time',
 			'core.posting_modify_template_vars' => 'check_expiry_time',
@@ -75,7 +75,8 @@ static public function getSubscribedEvents()
 	 */
 	public function check_expiry_time($event)
 	{
-		error_log('[phpBB3 postlocalstorage] Dumping \$event in check_expiry_time()' + print_r($event, true));
+		// error_log('[phpBB3 postlocalstorage] Dumping \$event in check_expiry_time()' + print_r($event, true));
+		error_log('[phpBB3 postlocalstorage] checking for expiry time...');
 
 		try
 		{
@@ -92,8 +93,11 @@ public function check_expiry_time($event)
 			error_log('[phpBB3 postlocalstorage] Something is wrong with session_length: ' . $e->getMessage());
 			$session_length = 0;
 		}
-		// The extra 60 seconds is really just a safeguard.
-		$session_expiry_time = $this->time_now + $session_length + 60;
+		$session_expiry_time = $this->time_now + $session_length;
+
+		error_log('[phpBB3 postlocalstorage] check_expiry_time: $this->time_now is ' . $this->time_now
+			. ' $session_length is ' . $session_length
+			. '; Total is: ' . $session_expiry_time);
 
 		$this->template->assign_vars(array(
 			'EXPIRY_TIME' => $session_expiry_time,

gwynethllewelyn/postlocalstorage/styles/all/template/event/overall_footer_after.html

@@ -1,9 +1,9 @@
 
 <div id="expiry-time" style="visibility: hidden; display: none;">
-{% if EXPIRY_TIME %}
-{{ EXPIRY_TIME }}
-{% else %}
+{%- if EXPIRY_TIME -%}
+{{- EXPIRY_TIME -}}
+{%- else -%}
 0
-{% endif %}
+{%- endif -%}
 </div>
 {% INCLUDEJS '@gwynethllewelyn_postlocalstorage/postlocalstorage_functions.js' %}

gwynethllewelyn/postlocalstorage/styles/all/template/postlocalstorage_functions.js

@@ -33,7 +33,7 @@
 	var textarea = doc.querySelector('textarea[name="message"]');
 	// no point in being around if this is nil; also: avoids crashing below (gwyneth 20220303)
 	if (!textarea) {
-		console.debug("no phpBB3 content body textarea found");
+		console.debug("no phpBB3 content body textarea found, skipping");
 		return;
 	}
 	/**
@@ -178,8 +178,10 @@
 			 * Retrieve the session expiry time that was stamped on the post submit page.
 			 * @type {number}
 			 */
-			const expiry_time = document.getElementById('expiry-time').innerText;
-			if (Date.now > expiry_time) {
+			const expiry_time = document.getElementById('expiry-time').innerText.trim();
+			const dateNow = Date.now();
+			console.debug("Date.now() is " + dateNow + " and expiry_time is " + expiry_time);
+			if (dateNow > expiry_time) {
 				// We won't clear anything if the session already expired, so return.
 				return;
 			}