Bug: timestamp in secs (PHP) vs. milliseconds (JS)

Author: GwynethLlewelyn

gwynethllewelyn/postlocalstorage/event/listener.php

@@ -81,7 +81,7 @@ public function check_expiry_time($event)
 		try
 		{
 			/**
-			 * Session length, as defined on the configuration parameters.
+			 * Session length, as defined on the configuration parameters, in seconds.
 			 * If it doesn't exist, or throws an error, we'll set it to zero and that's it.
 			 *
 			 * @var int

gwynethllewelyn/postlocalstorage/ext.php

@@ -28,7 +28,7 @@ class ext extends base
 	 */
 	public function is_enableable()
 	{
-		error_log('[phpBB3 postlocalstorage] my is_enableable() was called!');
+		// error_log('[phpBB3 postlocalstorage] my is_enableable() was called!');
 		return phpbb_version_compare(PHPBB_VERSION, '3.3', '>=');
 	}
 }

gwynethllewelyn/postlocalstorage/styles/all/template/postlocalstorage_functions.js

@@ -176,11 +176,13 @@
 		function() {
 			/**
 			 * Retrieve the session expiry time that was stamped on the post submit page.
+			 * Force it to a number!
+			 *
 			 * @type {number}
 			 */
-			const expiry_time = document.getElementById('expiry-time').innerText.trim();
-			const dateNow = Date.now();
-			console.debug("Date.now() is " + dateNow + " and expiry_time is " + expiry_time);
+			const expiry_time = parseInt(document.getElementById('expiry-time').innerText.trim(), 10);
+			const dateNow = Math.floor(Date.now() / 1000);	// we get milliseconds, so we need to convert to seconds.
+			console.debug("Date.now() in seconds is " + dateNow + " and expiry_time is " + expiry_time);
 			if (dateNow > expiry_time) {
 				// We won't clear anything if the session already expired, so return.
 				return;