Fix: replace legacy substr with substring

substr() is legacy/deprecated, but, in this case, substring() can be replaced without a single problem! (see comments on PR #3)

Author: GwynethLlewelyn

gwynethllewelyn/postlocalstorage/styles/all/template/postlocalstorage_functions.js

@@ -55,69 +55,68 @@
 	// Kudos to @gvp9000 and for the fix below. (gwyneth 20240414)
 	// @see https://www.phpbb.com/customise/db/extension/postlocalstorage/support/topic/246616?p=877489#p877489
 
-
-// POSTING
-//possible key formats
-//./phpBB3/posting.php?mode=edit&&p=xxxxx#preview#preview#preview#preview .......
-//./phpBB3/posting.php?mode=quote&p=xxxxx#preview#preview#preview#preview .......
-//./phpBB3/posting.php?mode=reply&t=yyyyy#preview#preview#preview#preview .......
-//Remove all "#preview" strings at the end
+	// POSTING
+	//possible key formats
+	//./phpBB3/posting.php?mode=edit&&p=xxxxx#preview#preview#preview#preview .......
+	//./phpBB3/posting.php?mode=quote&p=xxxxx#preview#preview#preview#preview .......
+	//./phpBB3/posting.php?mode=reply&t=yyyyy#preview#preview#preview#preview .......
+	//Remove all "#preview" strings at the end
 	if (key.includes("posting.php?mode=")) {
 		if (key.endsWith("#preview")) {
 			var count_hash = key.split("#").length - 1;
 			for (let i = 0; i < count_hash; i++) {
-			key = key.substring(0, key.lastIndexOf('#'));
+				key = key.substring(0, key.lastIndexOf('#'));
 			}
 		}
 	}
 
-// PM'ing
-//possible key formats
+	// PM'ing
+	//possible key formats
 
-//1 case 
-//./phpBB3/ucp.php?i=pm&mode=compose
-//nothing to do here
+	//1 case
+	//./phpBB3/ucp.php?i=pm&mode=compose
+	//nothing to do here
 
-//2 case 
-//./phpBB3/ucp.php?i=ucp_pm&mode=compose returns
-//./phpBB3/ucp.php?i=pm&mode=compose
+	//2 case
+	//./phpBB3/ucp.php?i=ucp_pm&mode=compose returns
+	//./phpBB3/ucp.php?i=pm&mode=compose
 	if (key.includes("ucp.php?i=ucp_pm&mode=compose")) {
-	key = key.split("?")[0].concat("?i=pm&mode=compose");
+		key = key.split("?")[0].concat("?i=pm&mode=compose");
 	}
 
-//3 case 
-//./phpBB3/ucp.php?i=pm&mode=compose&action=post&sid=sssssssssssssssssssssssssss returns
-//./phpBB3/ucp.php?i=pm&mode=compose
+	//3 case
+	//./phpBB3/ucp.php?i=pm&mode=compose&action=post&sid=sssssssssssssssssssssssssss returns
+	//./phpBB3/ucp.php?i=pm&mode=compose
 	if (key.includes("ucp.php?i=pm&mode=compose&action=post")) {
-	key = key.split("?")[0].concat("?i=pm&mode=compose");
+		key = key.split("?")[0].concat("?i=pm&mode=compose");
 	}
 
-//4 case ./phpBB3/ucp.php?i=pm&mode=compose&action=reply&f=xxx&p=yyy
-//5 case ./phpBB3/ucp.php?i=pm&mode=compose&action=forward&f=xxx&p=yyy
-//6 case ./phpBB3/ucp.php?i=pm&mode=compose&action=quote&f=xxx&p=yyy
+	//4 case ./phpBB3/ucp.php?i=pm&mode=compose&action=reply&f=xxx&p=yyy
+	//5 case ./phpBB3/ucp.php?i=pm&mode=compose&action=forward&f=xxx&p=yyy
+	//6 case ./phpBB3/ucp.php?i=pm&mode=compose&action=quote&f=xxx&p=yyy
 	if (key.includes("ucp.php?i=pm&mode=compose&action=reply&f=") || key.includes("ucp.php?i=pm&mode=compose&action=forward&f=") || key.includes("ucp.php?i=pm&mode=compose&action=quote&f=")) {
-	var fpos = key.indexOf("&f="),
-		ppos = key.indexOf("&p=");
-	if (fpos > -1 && ppos > fpos) {
-		key = key.substr(0, fpos)+key.substr(ppos);
-	}
+		var fpos = key.indexOf("&f="),
+			ppos = key.indexOf("&p=");
+		if (fpos > -1 && ppos > fpos) {
+			key = key.substring(0, fpos) + key.substring(ppos);
+		}
 	}
-	
-//7 case 
-//./phpBB3/ucp.php?i=pm&mode=compose&action=reply&sid=sssssssssssssssssssssssssss&p=yyy returns 
-//./phpBB3/ucp.php?i=pm&mode=compose&action=reply&p=yyy
-//8th case 
-//./phpBB3/ucp.php?i=pm&mode=compose&action=forward&sid=sssssssssssssssssssssssssss&p=yyy returns 
-//./phpBB3/ucp.php?i=pm&mode=compose&action=forward&p=yyy
-//9th case 
-//./phpBB3/ucp.php?i=pm&mode=compose&action=quote&sid=sssssssssssssssssssssssssss&p=yyy returns 
-//./phpBB3/ucp.php?i=pm&mode=compose&action=quote&p=yyy
+
+	//7 case
+	//./phpBB3/ucp.php?i=pm&mode=compose&action=reply&sid=sssssssssssssssssssssssssss&p=yyy returns
+	//./phpBB3/ucp.php?i=pm&mode=compose&action=reply&p=yyy
+	//8th case
+	//./phpBB3/ucp.php?i=pm&mode=compose&action=forward&sid=sssssssssssssssssssssssssss&p=yyy returns
+	//./phpBB3/ucp.php?i=pm&mode=compose&action=forward&p=yyy
+	//9th case
+	//./phpBB3/ucp.php?i=pm&mode=compose&action=quote&sid=sssssssssssssssssssssssssss&p=yyy returns
+	//./phpBB3/ucp.php?i=pm&mode=compose&action=quote&p=yyy
 	if (key.includes("ucp.php?i=pm&mode=compose&action=reply&sid=") || key.includes("ucp.php?i=pm&mode=compose&action=forward&sid=") || key.includes("ucp.php?i=pm&mode=compose&action=quote&sid=")) {
-	var sipos = key.indexOf("&sid="),
-		pipos = key.indexOf("&p=");
-	if (sipos > -1 && pipos > sipos) {
-		key = key.substr(0, sipos)+key.substr(pipos);
-	}
+		var sipos = key.indexOf("&sid="),
+			pipos = key.indexOf("&p=");
+		if (sipos > -1 && pipos > sipos) {
+			key = key.substring(0, sipos) + key.substring(pipos);
+		}
 	}
 
 	/**
@@ -241,7 +240,7 @@
 			 * @type {number}
 			 */
 			const expiry_time = parseInt(document.getElementById('expiry-time').innerText.trim(), 10);
-			const dateNow = Math.floor(Date.now() / 1000);	// we get milliseconds, so we need to convert to seconds.
+			const dateNow = Math.floor(Date.now() / 1000); // we get milliseconds, so we need to convert to seconds.
 			console.debug("Date.now() in seconds is " + dateNow + " and expiry_time is " + expiry_time);
 			if (dateNow > expiry_time) {
 				// We won't clear anything if the session already expired, so return.
@@ -259,4 +258,4 @@
 			}
 		}
 	);
-})(this, this.document);
+})(this, this.document);