Merge branch 'master' into master

Author: GwynethLlewelyn

.all-contributorsrc

@@ -0,0 +1,28 @@
+{
+  "projectName": "post-local-storage",
+  "projectOwner": "GwynethLlewelyn",
+  "files": [
+    "README.md"
+  ],
+  "commitType": "docs",
+  "commitConvention": "angular",
+  "contributorsPerLine": 7,
+  "contributors": [
+    {
+      "login": "kylesands",
+      "name": "kylesands",
+      "avatar_url": "https://avatars.githubusercontent.com/u/9731115?v=4",
+      "profile": "https://github.com/kylesands"
+    },
+    {
+      "login": "gvp9000",
+      "name": "gvp9000",
+      "avatar_url": "https://avatars.githubusercontent.com/u/24462297?v=4",
+      "profile": "https://github.com/gvp9000"
+    }
+  ],
+  "contributions": [
+    "code",
+    "ideas"
+  ]
+}

.github/workflows/codacy.yml

@@ -56,6 +56,6 @@ jobs:
 
       # Upload the SARIF file generated in the previous step
       - name: Upload SARIF results file
-        uses: github/codeql-action/upload-sarif@v2
+        uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: results.sarif

CONTRIBUTING.md

@@ -4,8 +4,12 @@
 
 Mora _complex_ ones should be (preferably!) as a Pull Request (PR) on GitHub.
 
+And don't forget to (automatically) add yourself as a contributor: https://allcontributors.org/docs/en/bot/usage
+
 ## Trivia
 
 The magic I use for zipping things properly (on a Mac) is:
 
 `zip postlocalstorage.zip -9 -x \*/.DS_Store -r gwynethllewelyn/`
+
+I'm trying to design a workflow to make this happen automagically once a new release is pushed out.

README.md

@@ -42,17 +42,41 @@ Since I have just a limited access to a testing environment, it's worth pointing
 
 Additionally, there are "mock" pages (coming with the GitHub package, but _not_ with the phpBB3 plugin itself) that allow me to do some testing under different circumstances (I found some weird bugs that way!), beyond those that are handled by the automated CI tools that I'm currently using.
 
-## Acknowledgements
+## Contributors ✨
+
+Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key)):
+
+<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
+<!-- prettier-ignore-start -->
+<!-- markdownlint-disable -->
+<table>
+  <tbody>
+    <tr>
+      <td align="center" valign="top" width="14.28%"><a href="https://github.com/kylesands"><img src="https://avatars.githubusercontent.com/u/9731115?v=4?s=100" width="100px;" alt="kylesands"/><br /><sub><b>kylesands</b></sub></a><br /><a href="#code-kylesands" title="Code">💻</a> <a href="#ideas-kylesands" title="Ideas, Planning, & Feedback">🤔</a></td>
+      <td align="center" valign="top" width="14.28%"><a href="https://github.com/gvp9000"><img src="https://avatars.githubusercontent.com/u/24462297?v=4?s=100" width="100px;" alt="gvp9000"/><br /><sub><b>gvp9000</b></sub></a><br /><a href="#code-gvp9000" title="Code">💻</a> <a href="#ideas-gvp9000" title="Ideas, Planning, & Feedback">🤔</a></td>
+    </tr>
+  </tbody>
+</table>
+
+<!-- markdownlint-restore -->
+<!-- prettier-ignore-end -->
+
+<!-- ALL-CONTRIBUTORS-LIST:END -->
+
+This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind welcome!
+
+## More acknowledgements
 
 Many thanks to
 [@Tread](https://www.phpbb.com/community/memberlist.php?mode=viewprofile&u=1973496) and [@cabot](https://www.phpbb.com/community/memberlist.php?mode=viewprofile&u=1337922) for gently 'persuading' me to publish this code as a phpBB3.3 extension, by pointing me to all the appropriate bits and pieces of code to be 'assembled' into an extension. Yay!
 
-Kudos to [@gvp9000](https://www.phpbb.com/community/memberlist.php?mode=viewprofile&u=2227069) for finding & fixing an obscure bug that affects Firefox.
+Kudos to [@gvp9000](https://www.phpbb.com/community/memberlist.php?mode=viewprofile&u=2227069) for finding & fixing an obscure bug that affects Firefox and submitting lots of code to fix this.
 
 Kudos to [@kylesands](https://www.phpbb.com/community/memberlist.php?mode=viewprofile&u=2218926) for pointing out and providing a fix for [incorrect local storage deletion during Preview](https://www.phpbb.com/customise/db/extension/postlocalstorage/support/topic/246115?p=877342#p877342) as well as for continuing overall support.
 
 Thanks to [@TrekRed](https://www.phpbb.com/community/memberlist.php?mode=viewprofile&u=19327714) for suggesting that the subject field gets saved as well.
 
 Logo designed by [DALL·E 2](https://openai.com/product/dall-e-2).
 
-![phpBB3 Logo](https://img.shields.io/badge/phpBB-3.3-blue) [![CodeQL](https://github.com/GwynethLlewelyn/post-local-storage/actions/workflows/codeql.yml/badge.svg)](https://github.com/GwynethLlewelyn/post-local-storage/actions/workflows/codeql.yml) [![Codacy Badge](https://app.codacy.com/project/badge/Grade/83a20d04433341baa65c78d29fc3410a)](https://www.codacy.com/gh/GwynethLlewelyn/post-local-storage/dashboard?utm_source=github.com&utm_medium=referral&utm_content=GwynethLlewelyn/post-local-storage&utm_campaign=Badge_Grade) [![Codacy Security Scan](https://github.com/GwynethLlewelyn/post-local-storage/actions/workflows/codacy.yml/badge.svg)](https://github.com/GwynethLlewelyn/post-local-storage/actions/workflows/codacy.yml) [![Liberapay](https://img.shields.io/liberapay/receives/GwynethLlewelyn.svg?logo=liberapay")](https://liberapay.com/GwynethLlewelyn/donate)
+![phpBB3 Logo](https://img.shields.io/badge/phpBB-3.3-blue) [![CodeQL](https://github.com/GwynethLlewelyn/post-local-storage/actions/workflows/codeql.yml/badge.svg)](https://github.com/GwynethLlewelyn/post-local-storage/actions/workflows/codeql.yml) [![Codacy Badge](https://app.codacy.com/project/badge/Grade/83a20d04433341baa65c78d29fc3410a)](https://www.codacy.com/gh/GwynethLlewelyn/post-local-storage/dashboard?utm_source=github.com&utm_medium=referral&utm_content=GwynethLlewelyn/post-local-storage&utm_campaign=Badge_Grade) [![Codacy Security Scan](https://github.com/GwynethLlewelyn/post-local-storage/actions/workflows/codacy.yml/badge.svg)](https://github.com/GwynethLlewelyn/post-local-storage/actions/workflows/codacy.yml) [![Liberapay](https://img.shields.io/liberapay/receives/GwynethLlewelyn.svg?logo=liberapay")](https://liberapay.com/GwynethLlewelyn/donate) [![All Contributors](https://img.shields.io/github/all-contributors/GwynethLlewelyn/post-local-storage?color=ee8449&style=flat-square)](#contributors)
+

eslint.config.js

@@ -1,11 +1,12 @@
 // eslint 9.1.0 config file
+// @ts-nocheck
 module.exports = [
 	{
 		languageOptions: {
 			ecmaVersion: "latest",
 			sourceType: "script"
 		},
 		files: ["**/*.js"],
-		ignores: ["**/.*", ".*/*"]
+		ignores: ["**/.*", ".*/*"],
 	}
 ];

gwynethllewelyn/postlocalstorage/styles/all/template/postlocalstorage_functions.js

@@ -56,8 +56,8 @@
 	// @see https://www.phpbb.com/customise/db/extension/postlocalstorage/support/topic/246616?p=877489#p877489
 	//if key.includes (viewforum.php) then exit
 	if (key.includes("viewforum.php")) {
-	console.debug("viewforum, no message box");
-	return;
+	  console.debug("viewforum, no message box");
+	  return;
 	}
 
 	// POSTING
@@ -70,7 +70,7 @@
 		if (key.endsWith("#preview")) {
 			var count_hash = key.split("#").length - 1;
 			for (let i = 0; i < count_hash; i++) {
-			key = key.substring(0, key.lastIndexOf('#'));
+				key = key.substring(0, key.lastIndexOf('#'));
 			}
 		}
 	}
@@ -86,14 +86,14 @@
 	//./phpBB3/ucp.php?i=ucp_pm&mode=compose returns
 	//./phpBB3/ucp.php?i=pm&mode=compose
 	else if (key.includes("ucp.php?i=ucp_pm&mode=compose")) {
-	key = key.split("?")[0].concat("?i=pm&mode=compose");
+	  key = key.split("?")[0].concat("?i=pm&mode=compose");
 	}
 
 	//3 case
 	//./phpBB3/ucp.php?i=pm&mode=compose&action=post&sid=sssssssssssssssssssssssssss returns
 	//./phpBB3/ucp.php?i=pm&mode=compose
 	else if (key.includes("ucp.php?i=pm&mode=compose&action=post")) {
-	key = key.split("?")[0].concat("?i=pm&mode=compose");
+	  key = key.split("?")[0].concat("?i=pm&mode=compose");
 	}
 
 	//4 case
@@ -107,11 +107,11 @@
 	//./phpBB3/ucp.php?i=pm&mode=compose&action=quote&p=yyy
 
 	else if (key.includes("ucp.php?i=pm&mode=compose&action=reply&f=") || key.includes("ucp.php?i=pm&mode=compose&action=forward&f=") || key.includes("ucp.php?i=pm&mode=compose&action=quote&f=")) {
-	var fpos = key.indexOf("&f="),
-		ppos = key.indexOf("&p=");
-	if (fpos > -1 && ppos > fpos) {
-		key = key.substr(0, fpos)+key.substr(ppos);
-	}
+	  var fpos = key.indexOf("&f="),
+		  ppos = key.indexOf("&p=");
+	  if (fpos > -1 && ppos > fpos) {
+	 	  key = key.substr(0, fpos) + key.substr(ppos);
+	  }
 	}
 
 	//7 case 
@@ -123,15 +123,17 @@
 	//9th case 
 	//./phpBB3/ucp.php?i=pm&mode=compose&action=quote&sid=sssssssssssssssssssssssssss&p=yyy returns 
 	//./phpBB3/ucp.php?i=pm&mode=compose&action=quote&p=yyy
-	else if (key.includes("ucp.php?i=pm&mode=compose&action=reply&sid=") || key.includes("ucp.php?i=pm&mode=compose&action=forward&sid=") || key.includes("ucp.php?i=pm&mode=compose&action=quote&sid=")) {
-	var sipos = key.indexOf("&sid="),
-		pipos = key.indexOf("&p=");
-	if (sipos > -1 && pipos > sipos) {
-		key = key.substr(0, sipos)+key.substr(pipos);
-	}
+	else if (key.includes("ucp.php?i=pm&mode=compose&action=reply&sid=") 
+           || key.includes("ucp.php?i=pm&mode=compose&action=forward&sid=")
+           || key.includes("ucp.php?i=pm&mode=compose&action=quote&sid=")) {
+	  var sipos = key.indexOf("&sid="),
+		  pipos = key.indexOf("&p=");
+	  if (sipos > -1 && pipos > sipos) {
+		  key = key.substr(0, sipos) + key.substr(pipos);
+	  }
 	}
 	else {
-	console.debug("no appropriate message key or pm key found");
+	  console.debug("no appropriate message key or pm key found");
 	}
 
 	/**
@@ -276,4 +278,4 @@
 			}
 		}
 	);
-})(this, this.document);
+})(this, this.document);

version_check.json

@@ -1,17 +1,8 @@
 {
-	"unstable": {
-		"1.2": {
-			"current": "1.2.0",
-			"download": "https:\/\/github.com\/GwynethLlewelyn\/post-local-storage\/releases\/download\/v1.2.0\/postlocalstorage.zip",
-			"announcement": "https:\/\/www.phpbb.com\/customise\/db\/extension\/postlocalstorage\/",
-			"eol": null,
-			"security": false
-		}
-	},
 	"stable": {
-		"1.1": {
-			"current": "1.1.0",
-			"download": "https:\/\/github.com\/GwynethLlewelyn\/post-local-storage\/releases\/download\/v1.1.0\/postlocalstorage.zip",
+		"1.2": {
+			"current": "1.2.1",
+			"download": "https:\/\/github.com\/GwynethLlewelyn\/post-local-storage\/releases\/download\/v1.2.1\/postlocalstorage.zip",
 			"announcement": "https:\/\/www.phpbb.com\/customise\/db\/extension\/postlocalstorage\/",
 			"eol": null,
 			"security": false